Francesco Romani has posted comments on this change.
Change subject: Support ioTune values >2^31 in getStats over xml-rpc
......................................................................
Patch Set 2: Code-Review+1
(1 comment)
http://gerrit.ovirt.org/#/c/30215/2/vdsm/virt/vm.py
File vdsm/virt/vm.py:
Line 2849: # with numbers bigger than int32_t
Line 2850: for ioTune in decStats["ioTune"]:
Line 2851: ioTune["ioTune"] = dict((k,
utils.convertToStr(v)) for k, v
Line 2852: in
ioTune["ioTune"].iteritems())
Line 2853: stats[var] = decStats[var]
I do not want the data to be string at all, but we have to workaround
xml-r
OK, this makes sense.
Now I wonder if we should factor all the int32_t workarounds in one common place, but
that's work for a different patch.
Line 2854: elif type(decStats[var]) is not dict:
Line 2855: stats[var] = utils.convertToStr(decStats[var])
Line 2856: elif var in ('network', 'balloonInfo',
'vmJobs',
Line 2857: 'vNodeRuntimeInfo'):
--
To view, visit
http://gerrit.ovirt.org/30215
To unsubscribe, visit
http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: If5005d7fdc5397df2480fa8d0c15b003a52e8626
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Martin Sivák <msivak(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani(a)redhat.com>
Gerrit-Reviewer: Martin Sivák <msivak(a)redhat.com>
Gerrit-Reviewer: Nir Soffer <nsoffer(a)redhat.com>
Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski(a)gmail.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes