Change in vdsm[master]: Fix mbx Exception type.

List overview All Threads
Download

newer

older

Change in vdsm[master]: getVdsCaps...

Change in vdsm[master]: Fix races...

ewarszaw＠redhat.com

25 Jul 2012 25 Jul '12

1:35 p.m.

Eduardo has uploaded a new change for review.

Change subject: Fix mbx Exception type. ......................................................................

Fix mbx Exception type.

Change-Id: Id8baf1121aaf351b029945972d5e87dbfa6a0bd5 Signed-off-by: Eduardo ewarszaw@redhat.com --- M vdsm/storage/storage_mailbox.py 1 file changed, 1 insertion(+), 1 deletion(-)

git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/17/6617/1 -- To view, visit http://gerrit.ovirt.org/6617 To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: newchange Gerrit-Change-Id: Id8baf1121aaf351b029945972d5e87dbfa6a0bd5 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Eduardo ewarszaw@redhat.com

Show replies by date

Dan Kenigsberg

25 Jul 25 Jul

2:08 p.m.

Dan Kenigsberg has posted comments on this change.

Change subject: Fix mbx Exception type. ......................................................................

Patch Set 1: I would prefer that you didn't submit this

(1 inline comment)

.................................................... File vdsm/storage/storage_mailbox.py Line 642: raise IOError("%s %s" % ("_handleRequests._checkForMail - Could not read mailbox:", str(self._inbox))) IOError needs (errno, string)

-- To view, visit http://gerrit.ovirt.org/6617 To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment Gerrit-Change-Id: Id8baf1121aaf351b029945972d5e87dbfa6a0bd5 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Eduardo ewarszaw@redhat.com Gerrit-Reviewer: Dan Kenigsberg danken@redhat.com

ewarszaw＠redhat.com

2:30 p.m.

Eduardo has posted comments on this change.

Change subject: Fix mbx Exception type. ......................................................................

Patch Set 1: (1 inline comment)

...

...
...
raise IOError("%s %s" % (1, 2))

Traceback (most recent call last): File "<pyshell#2>", line 1, in <module> raise IOError("%s %s" % (1, 2)) IOError: 1 2

I leave set errno as an exercise for the reader when we interpret the rc code. If not please advise which ERRNO value is preferred by you.

-- To view, visit http://gerrit.ovirt.org/6617 To unsubscribe, visit http://gerrit.ovirt.org/settings

Jenkins CI RO

27 Jan 27 Jan

7:21 a.m.

oVirt Jenkins CI Server has posted comments on this change.

Change subject: Fix mbx Exception type. ......................................................................

Patch Set 2:

Build Started http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/966/ (1/3)

-- To view, visit http://gerrit.ovirt.org/6617 To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment Gerrit-Change-Id: Id8baf1121aaf351b029945972d5e87dbfa6a0bd5 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Eduardo ewarszaw@redhat.com Gerrit-Reviewer: Ayal Baron abaron@redhat.com Gerrit-Reviewer: Dan Kenigsberg danken@redhat.com Gerrit-Reviewer: Eduardo ewarszaw@redhat.com Gerrit-Reviewer: Yeela Kaplan ykaplan@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server

Jenkins CI RO

7:21 a.m.

oVirt Jenkins CI Server has posted comments on this change.

Change subject: Fix mbx Exception type. ......................................................................

Patch Set 2:

Build Started http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/76/ (3/3)

-- To view, visit http://gerrit.ovirt.org/6617 To unsubscribe, visit http://gerrit.ovirt.org/settings

Jenkins CI RO

7:21 a.m.

oVirt Jenkins CI Server has posted comments on this change.

Change subject: Fix mbx Exception type. ......................................................................

Patch Set 2:

Build Started http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/931/ (2/3)

-- To view, visit http://gerrit.ovirt.org/6617 To unsubscribe, visit http://gerrit.ovirt.org/settings

Jenkins CI RO

7:22 a.m.

oVirt Jenkins CI Server has posted comments on this change.

Change subject: Fix mbx Exception type. ......................................................................

Patch Set 2: Fails

Build Failed

http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/931/ : SUCCESS

http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/966/ : FAILURE

http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/76/ : FAILURE

-- To view, visit http://gerrit.ovirt.org/6617 To unsubscribe, visit http://gerrit.ovirt.org/settings

Jenkins CI RO

12:40 p.m.

oVirt Jenkins CI Server has posted comments on this change.

Change subject: Fix mbx Exception type. ......................................................................

Patch Set 2: No score

Build Started http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/77/ (3/3)

-- To view, visit http://gerrit.ovirt.org/6617 To unsubscribe, visit http://gerrit.ovirt.org/settings

Jenkins CI RO

12:42 p.m.

oVirt Jenkins CI Server has posted comments on this change.

Change subject: Fix mbx Exception type. ......................................................................

Patch Set 2: Fails

Build Failed

http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/931/ : SUCCESS

http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/966/ : FAILURE

http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/77/ : FAILURE

-- To view, visit http://gerrit.ovirt.org/6617 To unsubscribe, visit http://gerrit.ovirt.org/settings

Dan Kenigsberg

1:51 p.m.

Dan Kenigsberg has posted comments on this change.

Change subject: Fix mbx Exception type. ......................................................................

Patch Set 2: I would prefer that you didn't submit this

I just love it! the unit tests have caught a real bug!

-- To view, visit http://gerrit.ovirt.org/6617 To unsubscribe, visit http://gerrit.ovirt.org/settings

Jenkins CI RO

4:04 p.m.

oVirt Jenkins CI Server has posted comments on this change.

Change subject: Fix mbx Exception type. ......................................................................

Patch Set 3:

Build Started http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/82/ (3/3)

-- To view, visit http://gerrit.ovirt.org/6617 To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment Gerrit-Change-Id: Id8baf1121aaf351b029945972d5e87dbfa6a0bd5 Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Eduardo ewarszaw@redhat.com Gerrit-Reviewer: Ayal Baron abaron@redhat.com Gerrit-Reviewer: Dan Kenigsberg danken@redhat.com Gerrit-Reviewer: Eduardo ewarszaw@redhat.com Gerrit-Reviewer: Yeela Kaplan ykaplan@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server

Jenkins CI RO

4:04 p.m.

oVirt Jenkins CI Server has posted comments on this change.

Change subject: Fix mbx Exception type. ......................................................................

Patch Set 3:

Build Started http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/971/ (2/3)

-- To view, visit http://gerrit.ovirt.org/6617 To unsubscribe, visit http://gerrit.ovirt.org/settings

Jenkins CI RO

4:04 p.m.

oVirt Jenkins CI Server has posted comments on this change.

Change subject: Fix mbx Exception type. ......................................................................

Patch Set 3:

Build Started http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/936/ (1/3)

-- To view, visit http://gerrit.ovirt.org/6617 To unsubscribe, visit http://gerrit.ovirt.org/settings

Jenkins CI RO

4:07 p.m.

oVirt Jenkins CI Server has posted comments on this change.

Change subject: Fix mbx Exception type. ......................................................................

Patch Set 3:

Build Successful

http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/936/ : SUCCESS

http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/971/ : SUCCESS

http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/82/ : SUCCESS

-- To view, visit http://gerrit.ovirt.org/6617 To unsubscribe, visit http://gerrit.ovirt.org/settings

Dan Kenigsberg

4:19 p.m.

Dan Kenigsberg has posted comments on this change.

Change subject: Fix mbx Exception type. ......................................................................

Patch Set 3: I would prefer that you didn't submit this

(1 inline comment)

.................................................... File vdsm/storage/storage_mailbox.py Line 726: # "command: " + str(cmd)) Line 727: (rc, in_mail, err) = misc.execCmd(cmd, sudo=False, raw=True) Line 728: if rc: Line 729: raise IOError(errno.EIO, "_handleRequests._checkForMail - " Line 730: "Could not read mailbox: %s", str(self._inbox)) str() explodes on unicode (simple %s is good) self._inbox is huge and not deeply related to the error to read from file. Are you not more interested in in_mail ?

(sorry for not noticing these questions earlier) Line 731: Line 732: if (len(in_mail) != (self._outMailLen)): Line 733: self.log.error('SPM_MailMonitor: _checkForMail - dd succeeded ' Line 734: 'but read %d bytes instead of %d, cannot check '

-- To view, visit http://gerrit.ovirt.org/6617 To unsubscribe, visit http://gerrit.ovirt.org/settings

ewarszaw＠redhat.com

4:49 p.m.

Eduardo has posted comments on this change.

Change subject: Fix mbx Exception type. ......................................................................

Patch Set 3: (1 inline comment)

.................................................... File vdsm/storage/storage_mailbox.py Line 726: # "command: " + str(cmd)) Line 727: (rc, in_mail, err) = misc.execCmd(cmd, sudo=False, raw=True) Line 728: if rc: Line 729: raise IOError(errno.EIO, "_handleRequests._checkForMail - " Line 730: "Could not read mailbox: %s", str(self._inbox)) self._inbox = os.path.join(self._spmStorageDir, self._poolID, Huge? In this way is uniform with the rest of the code. Sure, this code needs a lot of changes but let start. Line 731: Line 732: if (len(in_mail) != (self._outMailLen)): Line 733: self.log.error('SPM_MailMonitor: _checkForMail - dd succeeded ' Line 734: 'but read %d bytes instead of %d, cannot check '

-- To view, visit http://gerrit.ovirt.org/6617 To unsubscribe, visit http://gerrit.ovirt.org/settings

Dan Kenigsberg

8 p.m.

Dan Kenigsberg has posted comments on this change.

Change subject: Fix mbx Exception type. ......................................................................

Patch Set 3: (1 inline comment)

Still, it only strengthen my request to avoid the needless call to str(). '%s' would do the Right Thing. Line 731: Line 732: if (len(in_mail) != (self._outMailLen)): Line 733: self.log.error('SPM_MailMonitor: _checkForMail - dd succeeded ' Line 734: 'but read %d bytes instead of %d, cannot check '

-- To view, visit http://gerrit.ovirt.org/6617 To unsubscribe, visit http://gerrit.ovirt.org/settings

Jenkins CI RO

28 Jan 28 Jan

8:09 a.m.

oVirt Jenkins CI Server has posted comments on this change.

Change subject: Fix mbx Exception type. ......................................................................

Patch Set 4:

Build Started http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/942/ (3/3)

-- To view, visit http://gerrit.ovirt.org/6617 To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment Gerrit-Change-Id: Id8baf1121aaf351b029945972d5e87dbfa6a0bd5 Gerrit-PatchSet: 4 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Eduardo ewarszaw@redhat.com Gerrit-Reviewer: Ayal Baron abaron@redhat.com Gerrit-Reviewer: Dan Kenigsberg danken@redhat.com Gerrit-Reviewer: Eduardo ewarszaw@redhat.com Gerrit-Reviewer: Yeela Kaplan ykaplan@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server

Jenkins CI RO

8:09 a.m.

oVirt Jenkins CI Server has posted comments on this change.

Change subject: Fix mbx Exception type. ......................................................................

Patch Set 4:

Build Started http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/88/ (1/3)

-- To view, visit http://gerrit.ovirt.org/6617 To unsubscribe, visit http://gerrit.ovirt.org/settings

Jenkins CI RO

8:09 a.m.

oVirt Jenkins CI Server has posted comments on this change.

Change subject: Fix mbx Exception type. ......................................................................

Patch Set 4:

Build Started http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/977/ (2/3)

-- To view, visit http://gerrit.ovirt.org/6617 To unsubscribe, visit http://gerrit.ovirt.org/settings

Jenkins CI RO

8:16 a.m.

oVirt Jenkins CI Server has posted comments on this change.

Change subject: Fix mbx Exception type. ......................................................................

Patch Set 4:

Build Successful

http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/942/ : SUCCESS

http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/977/ : SUCCESS

http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/88/ : SUCCESS

-- To view, visit http://gerrit.ovirt.org/6617 To unsubscribe, visit http://gerrit.ovirt.org/settings

Dan Kenigsberg

1:01 p.m.

Dan Kenigsberg has posted comments on this change.

Change subject: Fix mbx Exception type. ......................................................................

Patch Set 4: Looks good to me, approved

-- To view, visit http://gerrit.ovirt.org/6617 To unsubscribe, visit http://gerrit.ovirt.org/settings

abaron＠redhat.com

9:57 p.m.

Ayal Baron has posted comments on this change.

Change subject: Fix mbx Exception type. ......................................................................

Patch Set 4: I would prefer that you didn't submit this

(2 inline comments)

.................................................... Commit Message Line 3: AuthorDate: 2013-01-27 09:17:36 +0200 Line 4: Commit: Eduardo Warszawski ewarszaw@redhat.com Line 5: CommitDate: 2013-01-28 10:08:51 +0200 Line 6: Line 7: Fix mbx Exception type. s/mbx/mailbox/g Line 8: Line 9: Making mbx raised exception more precise. Line 10: May be the 1st of an improved mbx logging patches. Line 11:

.................................................... File vdsm/storage/storage_mailbox.py Line 726: # "command: " + str(cmd)) Line 727: (rc, in_mail, err) = misc.execCmd(cmd, sudo=False, raw=True) Line 728: if rc: Line 729: raise IOError(errno.EIO, "_handleRequests._checkForMail - " Line 730: "Could not read mailbox: %s", self._inbox) logging the previous version of the inbox here is misleading and incorrect. Line 731: Line 732: if (len(in_mail) != (self._outMailLen)): Line 733: self.log.error('SPM_MailMonitor: _checkForMail - dd succeeded ' Line 734: 'but read %d bytes instead of %d, cannot check '

-- To view, visit http://gerrit.ovirt.org/6617 To unsubscribe, visit http://gerrit.ovirt.org/settings

ewarszaw＠redhat.com

3 Mar 3 Mar

12:02 p.m.

Eduardo has posted comments on this change.

Change subject: Fix mbx Exception type. ......................................................................

Patch Set 4: (1 inline comment)

.................................................... File vdsm/storage/storage_mailbox.py Line 726: # "command: " + str(cmd)) Line 727: (rc, in_mail, err) = misc.execCmd(cmd, sudo=False, raw=True) Line 728: if rc: Line 729: raise IOError(errno.EIO, "_handleRequests._checkForMail - " Line 730: "Could not read mailbox: %s", self._inbox) This is not the _inbox content Line 731: Line 732: if (len(in_mail) != (self._outMailLen)): Line 733: self.log.error('SPM_MailMonitor: _checkForMail - dd succeeded ' Line 734: 'but read %d bytes instead of %d, cannot check '

-- To view, visit http://gerrit.ovirt.org/6617 To unsubscribe, visit http://gerrit.ovirt.org/settings

Jenkins CI RO

10 Mar 10 Mar

6:58 p.m.

New subject: Change in vdsm[master]: Fix mailbox Exception type.

oVirt Jenkins CI Server has posted comments on this change.

Change subject: Fix mailbox Exception type. ......................................................................

Patch Set 5:

Build Started http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/1542/ (2/2)

-- To view, visit http://gerrit.ovirt.org/6617 To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment Gerrit-Change-Id: Id8baf1121aaf351b029945972d5e87dbfa6a0bd5 Gerrit-PatchSet: 5 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Eduardo ewarszaw@redhat.com Gerrit-Reviewer: Ayal Baron abaron@redhat.com Gerrit-Reviewer: Dan Kenigsberg danken@redhat.com Gerrit-Reviewer: Eduardo ewarszaw@redhat.com Gerrit-Reviewer: Yeela Kaplan ykaplan@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server

Jenkins CI RO

6:58 p.m.

New subject: Change in vdsm[master]: Fix mailbox Exception type.

oVirt Jenkins CI Server has posted comments on this change.

Change subject: Fix mailbox Exception type. ......................................................................

Patch Set 5:

Build Started http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/1505/ (1/2)

-- To view, visit http://gerrit.ovirt.org/6617 To unsubscribe, visit http://gerrit.ovirt.org/settings

Jenkins CI RO

7:01 p.m.

New subject: Change in vdsm[master]: Fix mailbox Exception type.

oVirt Jenkins CI Server has posted comments on this change.

Change subject: Fix mailbox Exception type. ......................................................................

Patch Set 5:

Build Successful

http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/1542/ : SUCCESS

http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/1505/ : SUCCESS

-- To view, visit http://gerrit.ovirt.org/6617 To unsubscribe, visit http://gerrit.ovirt.org/settings

Jenkins CI RO

11 Mar 11 Mar

7:41 a.m.

New subject: Change in vdsm[master]: Fix mailbox Exception type.

oVirt Jenkins CI Server has posted comments on this change.

Change subject: Fix mailbox Exception type. ......................................................................

Patch Set 6:

Build Started http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/1544/ (1/2)

-- To view, visit http://gerrit.ovirt.org/6617 To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment Gerrit-Change-Id: Id8baf1121aaf351b029945972d5e87dbfa6a0bd5 Gerrit-PatchSet: 6 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Eduardo ewarszaw@redhat.com Gerrit-Reviewer: Ayal Baron abaron@redhat.com Gerrit-Reviewer: Dan Kenigsberg danken@redhat.com Gerrit-Reviewer: Eduardo ewarszaw@redhat.com Gerrit-Reviewer: Yeela Kaplan ykaplan@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server

Jenkins CI RO

7:41 a.m.

New subject: Change in vdsm[master]: Fix mailbox Exception type.

oVirt Jenkins CI Server has posted comments on this change.

Change subject: Fix mailbox Exception type. ......................................................................

Patch Set 6:

Build Started http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/1507/ (2/2)

-- To view, visit http://gerrit.ovirt.org/6617 To unsubscribe, visit http://gerrit.ovirt.org/settings

ewarszaw＠redhat.com

7:42 a.m.

New subject: Change in vdsm[master]: Fix mailbox Exception type.

Eduardo has posted comments on this change.

Change subject: Fix mailbox Exception type. ......................................................................

Patch Set 6:

Rebased on actual master.

-- To view, visit http://gerrit.ovirt.org/6617 To unsubscribe, visit http://gerrit.ovirt.org/settings

Jenkins CI RO

7:45 a.m.

New subject: Change in vdsm[master]: Fix mailbox Exception type.

oVirt Jenkins CI Server has posted comments on this change.

Change subject: Fix mailbox Exception type. ......................................................................

Patch Set 6:

Build Successful

http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/1544/ : SUCCESS

http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/1507/ : SUCCESS

-- To view, visit http://gerrit.ovirt.org/6617 To unsubscribe, visit http://gerrit.ovirt.org/settings

Jenkins CI RO

4:57 p.m.

New subject: Change in vdsm[master]: Fix mailbox Exception type.

oVirt Jenkins CI Server has posted comments on this change.

Change subject: Fix mailbox Exception type. ......................................................................

Patch Set 7:

Build Started http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/1559/ (2/2)

-- To view, visit http://gerrit.ovirt.org/6617 To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment Gerrit-Change-Id: Id8baf1121aaf351b029945972d5e87dbfa6a0bd5 Gerrit-PatchSet: 7 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Eduardo ewarszaw@redhat.com Gerrit-Reviewer: Ayal Baron abaron@redhat.com Gerrit-Reviewer: Dan Kenigsberg danken@redhat.com Gerrit-Reviewer: Eduardo ewarszaw@redhat.com Gerrit-Reviewer: Yeela Kaplan ykaplan@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server

Jenkins CI RO

4:57 p.m.

New subject: Change in vdsm[master]: Fix mailbox Exception type.

oVirt Jenkins CI Server has posted comments on this change.

Change subject: Fix mailbox Exception type. ......................................................................

Patch Set 7:

Build Started http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/1522/ (1/2)

-- To view, visit http://gerrit.ovirt.org/6617 To unsubscribe, visit http://gerrit.ovirt.org/settings

Jenkins CI RO

5:01 p.m.

New subject: Change in vdsm[master]: Fix mailbox Exception type.

oVirt Jenkins CI Server has posted comments on this change.

Change subject: Fix mailbox Exception type. ......................................................................

Patch Set 7:

Build Successful

http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/1559/ : SUCCESS

http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/1522/ : SUCCESS

-- To view, visit http://gerrit.ovirt.org/6617 To unsubscribe, visit http://gerrit.ovirt.org/settings

Dan Kenigsberg

7:24 p.m.

New subject: Change in vdsm[master]: Fix mailbox Exception type.

Dan Kenigsberg has posted comments on this change.

Change subject: Fix mailbox Exception type. ......................................................................

Patch Set 7: Looks good to me, approved

-- To view, visit http://gerrit.ovirt.org/6617 To unsubscribe, visit http://gerrit.ovirt.org/settings

Haim Ateya

13 Mar 13 Mar

7:30 a.m.

New subject: Change in vdsm[master]: Fix mailbox Exception type.

Haim Ateya has posted comments on this change.

Change subject: Fix mailbox Exception type. ......................................................................

Patch Set 7: Verified

-- To view, visit http://gerrit.ovirt.org/6617 To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment Gerrit-Change-Id: Id8baf1121aaf351b029945972d5e87dbfa6a0bd5 Gerrit-PatchSet: 7 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Eduardo ewarszaw@redhat.com Gerrit-Reviewer: Ayal Baron abaron@redhat.com Gerrit-Reviewer: Dan Kenigsberg danken@redhat.com Gerrit-Reviewer: Eduardo ewarszaw@redhat.com Gerrit-Reviewer: Haim Ateya hateya@redhat.com Gerrit-Reviewer: Yeela Kaplan ykaplan@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server

Dan Kenigsberg

7:32 a.m.

New subject: Change in vdsm[master]: Fix mailbox Exception type.

Dan Kenigsberg has submitted this change and it was merged.

Change subject: Fix mailbox Exception type. ......................................................................

Fix mailbox Exception type.

Making mailbox raised exception more precise. May be the 1st of an improved mailbox logging patches.

Change-Id: Id8baf1121aaf351b029945972d5e87dbfa6a0bd5 Signed-off-by: Eduardo ewarszaw@redhat.com --- M vdsm/storage/storage_mailbox.py 1 file changed, 3 insertions(+), 2 deletions(-)

Approvals: Haim Ateya: Verified Dan Kenigsberg: Looks good to me, approved

-- To view, visit http://gerrit.ovirt.org/6617 To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: merged Gerrit-Change-Id: Id8baf1121aaf351b029945972d5e87dbfa6a0bd5 Gerrit-PatchSet: 7 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Eduardo ewarszaw@redhat.com Gerrit-Reviewer: Ayal Baron abaron@redhat.com Gerrit-Reviewer: Dan Kenigsberg danken@redhat.com Gerrit-Reviewer: Eduardo ewarszaw@redhat.com Gerrit-Reviewer: Haim Ateya hateya@redhat.com Gerrit-Reviewer: Yeela Kaplan ykaplan@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server

4125

Age (days ago)

4356

Last active (days ago)

vdsm-patches@lists.fedorahosted.org

36 comments

5 participants

tags (0)

participants (5)

abaron＠redhat.com
Dan Kenigsberg
ewarszaw＠redhat.com
Haim Ateya
Jenkins CI RO