Change in vdsm[master]: netinfo: implement functions gathering ipv6 information

List overview All Threads
Download

newer

older

Change in vdsm[master]: Probe cpu...

mhuntxu＠gmail.com

21 Nov 2012 21 Nov '12

11:07 a.m.

Hunt Xu has uploaded a new change for review.

Change subject: netinfo: implement functions gathering ipv6 information ......................................................................

netinfo: implement functions gathering ipv6 information

Change-Id: I2318ffa7d71abe3f57cb5e480bc46565e29f3894 Signed-off-by: huntxu mhuntxu@gmail.com --- M vdsm/netinfo.py 1 file changed, 34 insertions(+), 3 deletions(-)

git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/81/9381/1

diff --git a/vdsm/netinfo.py b/vdsm/netinfo.py index b6d1a1f..e0ee606 100644 --- a/vdsm/netinfo.py +++ b/vdsm/netinfo.py @@ -22,6 +22,8 @@ import errno import glob import ethtool +import socket +import struct import shlex import logging from fnmatch import fnmatch @@ -178,6 +180,13 @@ return bitmask_to_address(netmask)

+def getipv6addrs(dev): + """Return a list of ipv6 addresses in the format of 'address/prefixlen'.""" + dev_info_list = ethtool.get_interfaces_info(dev.encode('utf8')) + ipv6addrs = dev_info_list[0].get_ipv6_addresses() + return ['/'.join([addr.address, str(addr.netmask)]) for addr in ipv6addrs] + + def gethwaddr(dev): return file('/sys/class/net/%s/address' % dev).read().strip()

@@ -223,10 +232,15 @@ return '.'.join(ip_address)

+def ipv6StrToAddress(ipv6_str): + chr_list = [chr(int(ipv6_str[x:x + 2], 16)) for x in xrange(0, 32, 2)] + return socket.inet_ntop(socket.AF_INET6, struct.pack('16c', *chr_list)) + + def getRoutes(): """Return the interface default gateway or None if not found."""

- gateways = dict() + gateways = ipv6gateways = dict()

with open("/proc/net/route") as route_file: route_file.readline() # skip header line @@ -238,7 +252,24 @@ ip_num = int(route_parm[2], 16) gateways[route_parm[0]] = intToAddress(ip_num)

- return gateways + try: + with open("/proc/net/ipv6_route") as route_file: + for route_line in route_file.xreadlines(): + route_parm = route_line.rstrip().split(' ') + dest = route_parm[0] + prefix = route_parm[1] + nexthop = route_parm[4] + device = route_parm[-1] + if dest == '0' * 32 and prefix == '00' and nexthop != '0' * 32: + ipv6gateways[device] = ipv6StrToAddress(nexthop) + except IOError as e: + if e.errno == 2: + # ipv6 module not loaded + pass + else: + raise e + + return gateways, ipv6gateways

def getIfaceCfg(iface): @@ -273,7 +304,7 @@

def get(): d = {} - routes = getRoutes() + routes, routes6 = getRoutes() # FIXME handle bridge/nic missing from ifconfig d['networks'] = {} nets = networks()

-- To view, visit http://gerrit.ovirt.org/9381 To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: newchange Gerrit-Change-Id: I2318ffa7d71abe3f57cb5e480bc46565e29f3894 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Hunt Xu mhuntxu@gmail.com

Show replies by date

Jenkins CI RO

21 Nov 21 Nov

11:07 a.m.

oVirt Jenkins CI Server has posted comments on this change.

Change subject: netinfo: implement functions gathering ipv6 information ......................................................................

Patch Set 1:

Build Started http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/80/ (1/2)

-- To view, visit http://gerrit.ovirt.org/9381 To unsubscribe, visit http://gerrit.ovirt.org/settings

Jenkins CI RO

11:07 a.m.

oVirt Jenkins CI Server has posted comments on this change.

Change subject: netinfo: implement functions gathering ipv6 information ......................................................................

Patch Set 1:

Build Started http://jenkins.ovirt.org/job/vdsm_unit_tests_manual_gerrit/114/ (2/2)

-- To view, visit http://gerrit.ovirt.org/9381 To unsubscribe, visit http://gerrit.ovirt.org/settings

Jenkins CI RO

11:09 a.m.

oVirt Jenkins CI Server has posted comments on this change.

Change subject: netinfo: implement functions gathering ipv6 information ......................................................................

Patch Set 1: Fails

Build Failed

http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/80/ : SUCCESS

http://jenkins.ovirt.org/job/vdsm_unit_tests_manual_gerrit/114/ : FAILURE

-- To view, visit http://gerrit.ovirt.org/9381 To unsubscribe, visit http://gerrit.ovirt.org/settings

Dan Kenigsberg

22 Nov 22 Nov

7:32 a.m.

Dan Kenigsberg has posted comments on this change.

Change subject: netinfo: implement functions gathering ipv6 information ......................................................................

Patch Set 1: I would prefer that you didn't submit this

(5 inline comments)

thanks! gathering ipv6 addresses is a first fine step for ipv6 support.

It would be more complex to configure ipv6...

.................................................... File vdsm/netinfo.py Line 180: return bitmask_to_address(netmask) Line 181: Line 182: Line 183: def getipv6addrs(dev): Line 184: """Return a list of ipv6 addresses in the format of 'address/prefixlen'.""" I'm very weak when it comes to ipv6, but shouldn't we report the addess's scope, too? Line 185: dev_info_list = ethtool.get_interfaces_info(dev.encode('utf8')) Line 186: ipv6addrs = dev_info_list[0].get_ipv6_addresses() Line 187: return ['/'.join([addr.address, str(addr.netmask)]) for addr in ipv6addrs] Line 188:

Line 231: Line 232: return '.'.join(ip_address) Line 233: Line 234: Line 235: def ipv6StrToAddress(ipv6_str): this seems a bit over-complex to me.

would you consider

socket.inet_ntop(socket.AF_INET6, struct.pack('QQ', *divmod(int(ipv5_str, 16), 2**64)))

instead (UNTESTED)?

would you add a unit test for this function? Line 236: chr_list = [chr(int(ipv6_str[x:x + 2], 16)) for x in xrange(0, 32, 2)] Line 237: return socket.inet_ntop(socket.AF_INET6, struct.pack('16c', *chr_list)) Line 238: Line 239:

Please move to a separate getRoutes6 (or a better name). Line 257: for route_line in route_file.xreadlines(): Line 258: route_parm = route_line.rstrip().split(' ') Line 259: dest = route_parm[0] Line 260: prefix = route_parm[1]

Line 262: device = route_parm[-1] Line 263: if dest == '0' * 32 and prefix == '00' and nexthop != '0' * 32: Line 264: ipv6gateways[device] = ipv6StrToAddress(nexthop) Line 265: except IOError as e: Line 266: if e.errno == 2: errno.ENOENT is more readable than "2". Line 267: # ipv6 module not loaded Line 268: pass Line 269: else: Line 270: raise e

Line 266: if e.errno == 2: Line 267: # ipv6 module not loaded Line 268: pass Line 269: else: Line 270: raise e use a simple "raise" (no arg) to keep the original exception with its traceback. Line 271: Line 272: return gateways, ipv6gateways Line 273: Line 274:

-- To view, visit http://gerrit.ovirt.org/9381 To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment Gerrit-Change-Id: I2318ffa7d71abe3f57cb5e480bc46565e29f3894 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Hunt Xu mhuntxu@gmail.com Gerrit-Reviewer: Antoni Segura Puimedon asegurap@redhat.com Gerrit-Reviewer: Dan Kenigsberg danken@redhat.com Gerrit-Reviewer: Mark Wu wudxw@linux.vnet.ibm.com Gerrit-Reviewer: oVirt Jenkins CI Server

mhuntxu＠gmail.com

11:45 a.m.

Hunt Xu has posted comments on this change.

Change subject: netinfo: implement functions gathering ipv6 information ......................................................................

Patch Set 1: I would prefer that you didn't submit this

(4 inline comments)

Would update when I finish the mentioned unit test. Comments are welcome.

.................................................... File vdsm/netinfo.py Line 180: return bitmask_to_address(netmask) Line 181: Line 182: Line 183: def getipv6addrs(dev): Line 184: """Return a list of ipv6 addresses in the format of 'address/prefixlen'.""" I think ipv6 address indicates its scope, from the ietf rfc. And it seems we don't that care ipv4 addresses' scope, isn't it the same? Line 185: dev_info_list = ethtool.get_interfaces_info(dev.encode('utf8')) Line 186: ipv6addrs = dev_info_list[0].get_ipv6_addresses() Line 187: return ['/'.join([addr.address, str(addr.netmask)]) for addr in ipv6addrs] Line 188:

Line 231: Line 232: return '.'.join(ip_address) Line 233: Line 234: Line 235: def ipv6StrToAddress(ipv6_str): I change 'QQ' to '>QQ' since it's network byte order and it works well. Of course a unit test should be added. Thanks Line 236: chr_list = [chr(int(ipv6_str[x:x + 2], 16)) for x in xrange(0, 32, 2)] Line 237: return socket.inet_ntop(socket.AF_INET6, struct.pack('16c', *chr_list)) Line 238: Line 239:

Line 252: ip_num = int(route_parm[2], 16) Line 253: gateways[route_parm[0]] = intToAddress(ip_num) Line 254: Line 255: try: Line 256: with open("/proc/net/ipv6_route") as route_file: Either getRoutes6 or getIPv6Routes would be fine in my mind. Line 257: for route_line in route_file.xreadlines(): Line 258: route_parm = route_line.rstrip().split(' ') Line 259: dest = route_parm[0] Line 260: prefix = route_parm[1]

Line 262: device = route_parm[-1] Line 263: if dest == '0' * 32 and prefix == '00' and nexthop != '0' * 32: Line 264: ipv6gateways[device] = ipv6StrToAddress(nexthop) Line 265: except IOError as e: Line 266: if e.errno == 2: :P Line 267: # ipv6 module not loaded Line 268: pass Line 269: else: Line 270: raise e

-- To view, visit http://gerrit.ovirt.org/9381 To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment Gerrit-Change-Id: I2318ffa7d71abe3f57cb5e480bc46565e29f3894 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Hunt Xu mhuntxu@gmail.com Gerrit-Reviewer: Antoni Segura Puimedon asegurap@redhat.com Gerrit-Reviewer: Dan Kenigsberg danken@redhat.com Gerrit-Reviewer: Hunt Xu mhuntxu@gmail.com Gerrit-Reviewer: Livnat Peer lpeer@redhat.com Gerrit-Reviewer: Mark Wu wudxw@linux.vnet.ibm.com

Jenkins CI RO

28 Nov 28 Nov

9:09 a.m.

oVirt Jenkins CI Server has posted comments on this change.

Change subject: netinfo: implement functions gathering ipv6 information ......................................................................

Patch Set 2:

Build Started http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/182/ (1/2)

-- To view, visit http://gerrit.ovirt.org/9381 To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment Gerrit-Change-Id: I2318ffa7d71abe3f57cb5e480bc46565e29f3894 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Hunt Xu mhuntxu@gmail.com Gerrit-Reviewer: Antoni Segura Puimedon asegurap@redhat.com Gerrit-Reviewer: Dan Kenigsberg danken@redhat.com Gerrit-Reviewer: Hunt Xu mhuntxu@gmail.com Gerrit-Reviewer: Livnat Peer lpeer@redhat.com Gerrit-Reviewer: Mark Wu wudxw@linux.vnet.ibm.com Gerrit-Reviewer: oVirt Jenkins CI Server

Jenkins CI RO

9:09 a.m.

oVirt Jenkins CI Server has posted comments on this change.

Change subject: netinfo: implement functions gathering ipv6 information ......................................................................

Patch Set 2:

Build Started http://jenkins.ovirt.org/job/vdsm_unit_tests_manual_gerrit/216/ (2/2)

-- To view, visit http://gerrit.ovirt.org/9381 To unsubscribe, visit http://gerrit.ovirt.org/settings

Jenkins CI RO

9:10 a.m.

oVirt Jenkins CI Server has posted comments on this change.

Change subject: netinfo: implement functions gathering ipv6 information ......................................................................

Patch Set 2: Fails

Build Failed

http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/182/ : SUCCESS

http://jenkins.ovirt.org/job/vdsm_unit_tests_manual_gerrit/216/ : FAILURE

-- To view, visit http://gerrit.ovirt.org/9381 To unsubscribe, visit http://gerrit.ovirt.org/settings

Jenkins CI RO

9:21 a.m.

oVirt Jenkins CI Server has posted comments on this change.

Change subject: netinfo: implement functions gathering ipv6 information ......................................................................

Patch Set 3:

Build Started http://jenkins.ovirt.org/job/vdsm_unit_tests_manual_gerrit/218/ (1/2)

-- To view, visit http://gerrit.ovirt.org/9381 To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment Gerrit-Change-Id: I2318ffa7d71abe3f57cb5e480bc46565e29f3894 Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Hunt Xu mhuntxu@gmail.com Gerrit-Reviewer: Antoni Segura Puimedon asegurap@redhat.com Gerrit-Reviewer: Dan Kenigsberg danken@redhat.com Gerrit-Reviewer: Hunt Xu mhuntxu@gmail.com Gerrit-Reviewer: Livnat Peer lpeer@redhat.com Gerrit-Reviewer: Mark Wu wudxw@linux.vnet.ibm.com Gerrit-Reviewer: oVirt Jenkins CI Server

Jenkins CI RO

9:21 a.m.

oVirt Jenkins CI Server has posted comments on this change.

Change subject: netinfo: implement functions gathering ipv6 information ......................................................................

Patch Set 3:

Build Started http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/184/ (2/2)

-- To view, visit http://gerrit.ovirt.org/9381 To unsubscribe, visit http://gerrit.ovirt.org/settings

Jenkins CI RO

9:22 a.m.

oVirt Jenkins CI Server has posted comments on this change.

Change subject: netinfo: implement functions gathering ipv6 information ......................................................................

Patch Set 3:

Build Successful

http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/184/ : SUCCESS

http://jenkins.ovirt.org/job/vdsm_unit_tests_manual_gerrit/218/ : SUCCESS

-- To view, visit http://gerrit.ovirt.org/9381 To unsubscribe, visit http://gerrit.ovirt.org/settings

Dan Kenigsberg

11 Dec 11 Dec

10:02 p.m.

Dan Kenigsberg has posted comments on this change.

Change subject: netinfo: implement functions gathering ipv6 information ......................................................................

Patch Set 3: I would prefer that you didn't submit this

(3 inline comments)

sorry for the delayed review, I've missed your fixed version. minor comments within.

.................................................... File tests/netinfoTests.py Line 60: for n, addr in zip(num, ip): Line 61: self.assertEqual(addr, netinfo.intToAddress(n)) Line 62: Line 63: def testIPv6StrToAddress(self): Line 64: strings = [ it's only a little test, so this could fly, but "strings" is a very general a vague name for a variable. (not that I have a better name ready) Line 65: '00000000000000000000000000000000', Line 66: '00000000000000000000000000000001', Line 67: '20010db8000000000001000000000002', Line 68: '20010db8aaaabbbbccccddddeeeeffff',

Line 183: def getipv6addrs(dev): Line 184: """Return a list of ipv6 addresses in the format of 'address/prefixlen'.""" Line 185: dev_info_list = ethtool.get_interfaces_info(dev.encode('utf8')) Line 186: ipv6addrs = dev_info_list[0].get_ipv6_addresses() Line 187: return ['/'.join([addr.address, str(addr.netmask)]) for addr in ipv6addrs] I find it awkward to use join() with a two-item list.

addr.address + '/' + str(addr.netmask)

is simpler imo. Line 188: Line 189: Line 190: def gethwaddr(dev): Line 191: return file('/sys/class/net/%s/address' % dev).read().strip()

-- To view, visit http://gerrit.ovirt.org/9381 To unsubscribe, visit http://gerrit.ovirt.org/settings

masayag＠redhat.com

19 Dec 19 Dec

1:55 p.m.

Moti Asayag has posted comments on this change.

Change subject: netinfo: implement functions gathering ipv6 information ......................................................................

Patch Set 3: (1 inline comment)

.................................................... File tests/netinfoTests.py Line 60: for n, addr in zip(num, ip): Line 61: self.assertEqual(addr, netinfo.intToAddress(n)) Line 62: Line 63: def testIPv6StrToAddress(self): Line 64: strings = [ parameters / inputs ? Line 65: '00000000000000000000000000000000', Line 66: '00000000000000000000000000000001', Line 67: '20010db8000000000001000000000002', Line 68: '20010db8aaaabbbbccccddddeeeeffff',

-- To view, visit http://gerrit.ovirt.org/9381 To unsubscribe, visit http://gerrit.ovirt.org/settings

assafmuller＠gmail.com

16 Dec 16 Dec

1:11 p.m.

Assaf Muller has posted comments on this change.

Change subject: netinfo: implement functions gathering ipv6 information ......................................................................

Patch Set 3: Verified

(1 inline comment)

I answered Dan's question regarding ipv6 address scope.

.................................................... File vdsm/netinfo.py Line 181: Line 182: Line 183: def getipv6addrs(dev): Line 184: """Return a list of ipv6 addresses in the format of 'address/prefixlen'.""" Line 185: dev_info_list = ethtool.get_interfaces_info(dev.encode('utf8')) I checked into it and indeed the address scope of an ipv6 address can be deduced from the address itself, for unicast, anycast and multicast addresses. Here are Microsoft's clear and well written articles about the subject: http://msdn.microsoft.com/en-us/library/aa921071.aspx - Unicast. http://msdn.microsoft.com/en-us/library/aa916331.aspx - Anycast. http://msdn.microsoft.com/en-us/library/aa924142.aspx - Multicast. Line 186: ipv6addrs = dev_info_list[0].get_ipv6_addresses() Line 187: return ['/'.join([addr.address, str(addr.netmask)]) for addr in ipv6addrs] Line 188: Line 189:

-- To view, visit http://gerrit.ovirt.org/9381 To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment Gerrit-Change-Id: I2318ffa7d71abe3f57cb5e480bc46565e29f3894 Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Hunt Xu mhuntxu@gmail.com Gerrit-Reviewer: Antoni Segura Puimedon asegurap@redhat.com Gerrit-Reviewer: Assaf Muller assafmuller@gmail.com Gerrit-Reviewer: Dan Kenigsberg danken@redhat.com Gerrit-Reviewer: Hunt Xu mhuntxu@gmail.com Gerrit-Reviewer: Livnat Peer lpeer@redhat.com Gerrit-Reviewer: Mark Wu wudxw@linux.vnet.ibm.com Gerrit-Reviewer: oVirt Jenkins CI Server

Jenkins CI RO

29 Jan 29 Jan

6:55 p.m.

oVirt Jenkins CI Server has posted comments on this change.

Change subject: netinfo: implement functions gathering ipv6 information ......................................................................

Patch Set 4:

Build Started http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/984/ (1/3)

-- To view, visit http://gerrit.ovirt.org/9381 To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment Gerrit-Change-Id: I2318ffa7d71abe3f57cb5e480bc46565e29f3894 Gerrit-PatchSet: 4 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Hunt Xu mhuntxu@gmail.com Gerrit-Reviewer: Antoni Segura Puimedon asegurap@redhat.com Gerrit-Reviewer: Dan Kenigsberg danken@redhat.com Gerrit-Reviewer: Hunt Xu mhuntxu@gmail.com Gerrit-Reviewer: Livnat Peer lpeer@redhat.com Gerrit-Reviewer: Mark Wu wudxw@linux.vnet.ibm.com Gerrit-Reviewer: Moti Asayag masayag@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server

Jenkins CI RO

6:57 p.m.

oVirt Jenkins CI Server has posted comments on this change.

Change subject: netinfo: implement functions gathering ipv6 information ......................................................................

Patch Set 4:

Build Started http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/130/ (2/3)

-- To view, visit http://gerrit.ovirt.org/9381 To unsubscribe, visit http://gerrit.ovirt.org/settings

Jenkins CI RO

6:58 p.m.

oVirt Jenkins CI Server has posted comments on this change.

Change subject: netinfo: implement functions gathering ipv6 information ......................................................................

Patch Set 4:

Build Started http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/1019/ (3/3)

-- To view, visit http://gerrit.ovirt.org/9381 To unsubscribe, visit http://gerrit.ovirt.org/settings

Dan Kenigsberg

7:10 p.m.

Dan Kenigsberg has posted comments on this change.

Change subject: netinfo: implement functions gathering ipv6 information ......................................................................

Patch Set 4: Looks good to me, approved

-- To view, visit http://gerrit.ovirt.org/9381 To unsubscribe, visit http://gerrit.ovirt.org/settings

Jenkins CI RO

8:01 p.m.

oVirt Jenkins CI Server has posted comments on this change.

Change subject: netinfo: implement functions gathering ipv6 information ......................................................................

Patch Set 4:

Build Successful

http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/984/ : SUCCESS

http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/1019/ : SUCCESS

http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/130/ : SUCCESS

-- To view, visit http://gerrit.ovirt.org/9381 To unsubscribe, visit http://gerrit.ovirt.org/settings

asegurap＠redhat.com

30 Jan 30 Jan

9 a.m.

Antoni Segura Puimedon has posted comments on this change.

Change subject: netinfo: implement functions gathering ipv6 information ......................................................................

Patch Set 4: Looks good to me, but someone else must approve

-- To view, visit http://gerrit.ovirt.org/9381 To unsubscribe, visit http://gerrit.ovirt.org/settings

Jenkins CI RO

5 Feb 5 Feb

12:11 p.m.

New subject: Change in vdsm[master]: netinfo: implement functions gathering IPv6 information

oVirt Jenkins CI Server has posted comments on this change.

Change subject: netinfo: implement functions gathering IPv6 information ......................................................................

Patch Set 5:

Build Started http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/251/ (1/3)

-- To view, visit http://gerrit.ovirt.org/9381 To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment Gerrit-Change-Id: I2318ffa7d71abe3f57cb5e480bc46565e29f3894 Gerrit-PatchSet: 5 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Hunt Xu mhuntxu@gmail.com Gerrit-Reviewer: Antoni Segura Puimedon asegurap@redhat.com Gerrit-Reviewer: Dan Kenigsberg danken@redhat.com Gerrit-Reviewer: Hunt Xu mhuntxu@gmail.com Gerrit-Reviewer: Livnat Peer lpeer@redhat.com Gerrit-Reviewer: Mark Wu wudxw@linux.vnet.ibm.com Gerrit-Reviewer: Moti Asayag masayag@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server

Jenkins CI RO

12:17 p.m.

New subject: Change in vdsm[master]: netinfo: implement functions gathering IPv6 information

oVirt Jenkins CI Server has posted comments on this change.

Change subject: netinfo: implement functions gathering IPv6 information ......................................................................

Patch Set 5:

Build Started http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/1105/ (2/3)

-- To view, visit http://gerrit.ovirt.org/9381 To unsubscribe, visit http://gerrit.ovirt.org/settings

Jenkins CI RO

12:27 p.m.

New subject: Change in vdsm[master]: netinfo: implement functions gathering IPv6 information

oVirt Jenkins CI Server has posted comments on this change.

Change subject: netinfo: implement functions gathering IPv6 information ......................................................................

Patch Set 5:

Build Started http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/1140/ (3/3)

-- To view, visit http://gerrit.ovirt.org/9381 To unsubscribe, visit http://gerrit.ovirt.org/settings

Jenkins CI RO

12:31 p.m.

New subject: Change in vdsm[master]: netinfo: implement functions gathering IPv6 information

oVirt Jenkins CI Server has posted comments on this change.

Change subject: netinfo: implement functions gathering IPv6 information ......................................................................

Patch Set 5:

Build Successful

http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/1105/ : SUCCESS

http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/1140/ : SUCCESS

http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/251/ : SUCCESS

-- To view, visit http://gerrit.ovirt.org/9381 To unsubscribe, visit http://gerrit.ovirt.org/settings

Dan Kenigsberg

10 p.m.

New subject: Change in vdsm[master]: netinfo: implement functions gathering IPv6 information

Dan Kenigsberg has submitted this change and it was merged.

Change subject: netinfo: implement functions gathering IPv6 information ......................................................................

netinfo: implement functions gathering IPv6 information

Change-Id: I2318ffa7d71abe3f57cb5e480bc46565e29f3894 Signed-off-by: huntxu mhuntxu@gmail.com --- M tests/netinfoTests.py M vdsm/netinfo.py 2 files changed, 57 insertions(+), 0 deletions(-)

Approvals: Dan Kenigsberg: Verified; Looks good to me, approved

-- To view, visit http://gerrit.ovirt.org/9381 To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: merged Gerrit-Change-Id: I2318ffa7d71abe3f57cb5e480bc46565e29f3894 Gerrit-PatchSet: 5 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Hunt Xu mhuntxu@gmail.com Gerrit-Reviewer: Antoni Segura Puimedon asegurap@redhat.com Gerrit-Reviewer: Dan Kenigsberg danken@redhat.com Gerrit-Reviewer: Hunt Xu mhuntxu@gmail.com Gerrit-Reviewer: Livnat Peer lpeer@redhat.com Gerrit-Reviewer: Mark Wu wudxw@linux.vnet.ibm.com Gerrit-Reviewer: Moti Asayag masayag@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server

Dan Kenigsberg

10 p.m.

New subject: Change in vdsm[master]: netinfo: implement functions gathering IPv6 information

Dan Kenigsberg has posted comments on this change.

Change subject: netinfo: implement functions gathering IPv6 information ......................................................................

Patch Set 5: Verified; Looks good to me, approved

Thanks!

-- To view, visit http://gerrit.ovirt.org/9381 To unsubscribe, visit http://gerrit.ovirt.org/settings

4165

Age (days ago)

4241

Last active (days ago)

vdsm-patches@lists.fedorahosted.org

26 comments

6 participants

tags (0)

participants (6)

asegurap＠redhat.com
assafmuller＠gmail.com
Dan Kenigsberg
Jenkins CI RO
masayag＠redhat.com
mhuntxu＠gmail.com