Saggi Mizrahi has uploaded a new change for review.
Change subject: stomp: use the atomic dict.setdefault() instead for check and set ......................................................................
stomp: use the atomic dict.setdefault() instead for check and set
This is faster and simpler.
Change-Id: I28e4925a78328c4ac6cd0b9fc8659d6a3ee27a8f Signed-off-by: Saggi Mizrahi smizrahi@redhat.com --- M lib/yajsonrpc/stomp.py 1 file changed, 1 insertion(+), 2 deletions(-)
git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/37/35937/1
diff --git a/lib/yajsonrpc/stomp.py b/lib/yajsonrpc/stomp.py index 1dda6d7..04c23ba 100644 --- a/lib/yajsonrpc/stomp.py +++ b/lib/yajsonrpc/stomp.py @@ -218,8 +218,7 @@ # the first header entry SHOULD be used as the value of header entry. # Subsequent values are only used to maintain a history of state # changes of the header and MAY be ignored. - if key not in headers: - headers[key] = value + headers.setdefault(key, value)
return True
oVirt Jenkins CI Server has posted comments on this change.
Change subject: stomp: use the atomic dict.setdefault() instead for check and set ......................................................................
Patch Set 1:
Build Failed
http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/13949/ : SUCCESS
http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit_el/13160/ : FAILURE
http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created/14113/ : FAILURE
Yaniv Bronhaim has posted comments on this change.
Change subject: stomp: use the atomic dict.setdefault() instead for check and set ......................................................................
Patch Set 1: Code-Review+1
Dan Kenigsberg has posted comments on this change.
Change subject: stomp: use the atomic dict.setdefault() instead for check and set ......................................................................
Patch Set 1: Code-Review+2
Piotr Kliczewski has posted comments on this change.
Change subject: stomp: use the atomic dict.setdefault() instead for check and set ......................................................................
Patch Set 1: Code-Review+1
automation@ovirt.org has posted comments on this change.
Change subject: stomp: use the atomic dict.setdefault() instead for check and set ......................................................................
Patch Set 2:
* Update tracker::IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a valid url. * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3'])
oVirt Jenkins CI Server has posted comments on this change.
Change subject: stomp: use the atomic dict.setdefault() instead for check and set ......................................................................
Patch Set 2:
Build Failed
http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/15990/ : FAILURE
http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit_el/15189/ : FAILURE
http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created/16160/ : FAILURE
http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created_staging/966/ : FAILURE
automation@ovirt.org has posted comments on this change.
Change subject: stomp: use the atomic dict.setdefault() instead for check and set ......................................................................
Patch Set 3:
* Update tracker::IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a valid url. * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3'])
Francesco Romani has posted comments on this change.
Change subject: stomp: use the atomic dict.setdefault() instead for check and set ......................................................................
Patch Set 3: Code-Review+1
automation@ovirt.org has posted comments on this change.
Change subject: stomp: use the atomic dict.setdefault() instead for check and set ......................................................................
Patch Set 4:
* Update tracker::IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a valid url. * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3'])
oVirt Jenkins CI Server has posted comments on this change.
Change subject: stomp: use the atomic dict.setdefault() instead for check and set ......................................................................
Patch Set 4:
Build Failed
http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/16350/ : SUCCESS
http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit_el/15550/ : FAILURE
http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created/16520/ : FAILURE
automation@ovirt.org has posted comments on this change.
Change subject: stomp: use the atomic dict.setdefault() instead for check and set ......................................................................
Patch Set 5:
* Update tracker::IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a valid url. * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3'])
oVirt Jenkins CI Server has posted comments on this change.
Change subject: stomp: use the atomic dict.setdefault() instead for check and set ......................................................................
Patch Set 5:
Build Failed
http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/16458/ : SUCCESS
http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created/16629/ : FAILURE
http://jenkins.ovirt.org/job/vdsm_master_unit_tests_el_gerrit/15657/ : FAILURE
automation@ovirt.org has posted comments on this change.
Change subject: stomp: use the atomic dict.setdefault() instead for check and set ......................................................................
Patch Set 6:
* Update tracker::IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a valid url. * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3'])
Piotr Kliczewski has posted comments on this change.
Change subject: stomp: use the atomic dict.setdefault() instead for check and set ......................................................................
Patch Set 6: Verified+1
Verified by running engine 3.5, host installing vdsm and checking the logs for potential issues.
automation@ovirt.org has posted comments on this change.
Change subject: stomp: use the atomic dict.setdefault() instead for check and set ......................................................................
Patch Set 7:
* Update tracker::IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a valid url. * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3'])
oVirt Jenkins CI Server has posted comments on this change.
Change subject: stomp: use the atomic dict.setdefault() instead for check and set ......................................................................
Patch Set 7:
Build Failed
http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/16665/ : SUCCESS
http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created/16836/ : FAILURE
automation@ovirt.org has posted comments on this change.
Change subject: stomp: use the atomic dict.setdefault() instead for check and set ......................................................................
Patch Set 8:
* Update tracker::IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a valid url. * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3'])
oVirt Jenkins CI Server has posted comments on this change.
Change subject: stomp: use the atomic dict.setdefault() instead for check and set ......................................................................
Patch Set 8:
Build Failed
http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/16763/ : SUCCESS
http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created/16935/ : FAILURE
automation@ovirt.org has posted comments on this change.
Change subject: stomp: use the atomic dict.setdefault() instead for check and set ......................................................................
Patch Set 9:
* Update tracker::IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a valid url. * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3'])
oVirt Jenkins CI Server has posted comments on this change.
Change subject: stomp: use the atomic dict.setdefault() instead for check and set ......................................................................
Patch Set 9:
Build Failed
http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/16794/ : SUCCESS
http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created/16966/ : FAILURE
automation@ovirt.org has posted comments on this change.
Change subject: stomp: use the atomic dict.setdefault() instead for check and set ......................................................................
Patch Set 10:
* Update tracker::IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a valid url. * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3'])
oVirt Jenkins CI Server has posted comments on this change.
Change subject: stomp: use the atomic dict.setdefault() instead for check and set ......................................................................
Patch Set 10:
Build Failed
http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/16871/ : SUCCESS
http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created/17043/ : FAILURE
oVirt Jenkins CI Server has posted comments on this change.
Change subject: stomp: use the atomic dict.setdefault() instead for check and set ......................................................................
Patch Set 11:
Build Started (1/2) -> http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/16959/
automation@ovirt.org has posted comments on this change.
Change subject: stomp: use the atomic dict.setdefault() instead for check and set ......................................................................
Patch Set 11:
* Update tracker::IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a valid url. * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3'])
oVirt Jenkins CI Server has posted comments on this change.
Change subject: stomp: use the atomic dict.setdefault() instead for check and set ......................................................................
Patch Set 11:
Build Started (2/2) -> http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created/17132/
oVirt Jenkins CI Server has posted comments on this change.
Change subject: stomp: use the atomic dict.setdefault() instead for check and set ......................................................................
Patch Set 11:
Build Failed
http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/16959/ : SUCCESS
http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created/17132/ : FAILURE
Dan Kenigsberg has submitted this change and it was merged.
Change subject: stomp: use the atomic dict.setdefault() instead for check and set ......................................................................
stomp: use the atomic dict.setdefault() instead for check and set
This is faster and simpler.
Change-Id: I28e4925a78328c4ac6cd0b9fc8659d6a3ee27a8f Signed-off-by: Saggi Mizrahi smizrahi@redhat.com Reviewed-on: https://gerrit.ovirt.org/35937 Reviewed-by: Yaniv Bronhaim ybronhei@redhat.com Reviewed-by: Dan Kenigsberg danken@redhat.com Reviewed-by: Piotr Kliczewski piotr.kliczewski@gmail.com Reviewed-by: Francesco Romani fromani@redhat.com Tested-by: Piotr Kliczewski piotr.kliczewski@gmail.com --- M lib/yajsonrpc/stomp.py 1 file changed, 1 insertion(+), 2 deletions(-)
Approvals: Piotr Kliczewski: Verified; Looks good to me, but someone else must approve Yaniv Bronhaim: Looks good to me, but someone else must approve Dan Kenigsberg: Looks good to me, approved Francesco Romani: Looks good to me, but someone else must approve
automation@ovirt.org has posted comments on this change.
Change subject: stomp: use the atomic dict.setdefault() instead for check and set ......................................................................
Patch Set 12:
* Update tracker::IGNORE, no Bug-Url found * Set MODIFIED::IGNORE, no Bug-Url found.
oVirt Jenkins CI Server has posted comments on this change.
Change subject: stomp: use the atomic dict.setdefault() instead for check and set ......................................................................
Patch Set 12:
Build Started (1/9) -> http://jenkins.ovirt.org/job/vdsm_master_unit-tests_merged/4806/
oVirt Jenkins CI Server has posted comments on this change.
Change subject: stomp: use the atomic dict.setdefault() instead for check and set ......................................................................
Patch Set 12:
Build Started (2/9) -> http://jenkins.ovirt.org/job/vdsm_master-libgfapi_create-rpms-el7-x86_64_mer...
oVirt Jenkins CI Server has posted comments on this change.
Change subject: stomp: use the atomic dict.setdefault() instead for check and set ......................................................................
Patch Set 12:
Build Started (3/9) -> http://jenkins.ovirt.org/job/vdsm_master-libgfapi_create-rpms-fc20-x86_64_me...
oVirt Jenkins CI Server has posted comments on this change.
Change subject: stomp: use the atomic dict.setdefault() instead for check and set ......................................................................
Patch Set 12:
Build Started (4/9) -> http://jenkins.ovirt.org/job/vdsm_master_create-rpms-el6-x86_64_merged/826/
oVirt Jenkins CI Server has posted comments on this change.
Change subject: stomp: use the atomic dict.setdefault() instead for check and set ......................................................................
Patch Set 12:
Build Started (5/9) -> http://jenkins.ovirt.org/job/vdsm_master-libgfapi_create-rpms-el6-x86_64_mer...
oVirt Jenkins CI Server has posted comments on this change.
Change subject: stomp: use the atomic dict.setdefault() instead for check and set ......................................................................
Patch Set 12:
Build Started (6/9) -> http://jenkins.ovirt.org/job/vdsm_master_create-rpms-el7-x86_64_merged/831/
oVirt Jenkins CI Server has posted comments on this change.
Change subject: stomp: use the atomic dict.setdefault() instead for check and set ......................................................................
Patch Set 12:
Build Started (7/9) -> http://jenkins.ovirt.org/job/vdsm_master_create-rpms-fc21-x86_64_merged/797/
oVirt Jenkins CI Server has posted comments on this change.
Change subject: stomp: use the atomic dict.setdefault() instead for check and set ......................................................................
Patch Set 12:
Build Started (8/9) -> http://jenkins.ovirt.org/job/vdsm_master_create-rpms-fc20-x86_64_merged/831/
oVirt Jenkins CI Server has posted comments on this change.
Change subject: stomp: use the atomic dict.setdefault() instead for check and set ......................................................................
Patch Set 12:
Build Started (9/9) -> http://jenkins.ovirt.org/job/vdsm_master-libgfapi_create-rpms-fc21-x86_64_me...
oVirt Jenkins CI Server has posted comments on this change.
Change subject: stomp: use the atomic dict.setdefault() instead for check and set ......................................................................
Patch Set 12:
Build Successful
http://jenkins.ovirt.org/job/vdsm_master_create-rpms-el6-x86_64_merged/826/ : SUCCESS
http://jenkins.ovirt.org/job/vdsm_master-libgfapi_create-rpms-fc21-x86_64_me... : SUCCESS
http://jenkins.ovirt.org/job/vdsm_master_unit-tests_merged/4806/ : SUCCESS
http://jenkins.ovirt.org/job/vdsm_master_create-rpms-fc21-x86_64_merged/797/ : SUCCESS
http://jenkins.ovirt.org/job/vdsm_master-libgfapi_create-rpms-el6-x86_64_mer... : SUCCESS
http://jenkins.ovirt.org/job/vdsm_master_create-rpms-el7-x86_64_merged/831/ : SUCCESS
http://jenkins.ovirt.org/job/vdsm_master-libgfapi_create-rpms-el7-x86_64_mer... : SUCCESS
http://jenkins.ovirt.org/job/vdsm_master-libgfapi_create-rpms-fc20-x86_64_me... : SUCCESS
http://jenkins.ovirt.org/job/vdsm_master_create-rpms-fc20-x86_64_merged/831/ : SUCCESS
vdsm-patches@lists.fedorahosted.org
-
automation＠ovirt.org -
Dan Kenigsberg -
fromani＠redhat.com -
Jenkins CI RO -
Piotr Kliczewski -
smizrahi＠redhat.com -
ybronhei＠redhat.com