9:04 a.m.
Dan Kenigsberg has uploaded a new change for review.
Change subject: update NIC: having no custom properies is valid
......................................................................
update NIC: having no custom properies is valid
Older Engines, that preceded per-vNIC custom properties (Vdsm commit
38b1f8fb) do not send the "custom" element at all. This has to be
interpreted exactly as an empty custom element.
Change-Id: If510f012039304ad16000d46d9d72a3e035539f5
Signed-off-by: Dan Kenigsberg <danken(a)redhat.com>
---
M vdsm/vm.py
1 file changed, 1 insertion(+), 1 deletion(-)
git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/22/22922/1
diff --git a/vdsm/vm.py b/vdsm/vm.py
index 6467e0e..2a845b0 100644
--- a/vdsm/vm.py
+++ b/vdsm/vm.py
@@ -3192,7 +3192,7 @@
if network == '':
network = DUMMY_BRIDGE
linkValue = 'down'
- custom = params.get('custom')
+ custom = params.get('custom', {})
specParams = params.get('specParams')
netsToMirror = params.get('portMirroring',
--
To view, visit http://gerrit.ovirt.org/22922
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: If510f012039304ad16000d46d9d72a3e035539f5
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Dan Kenigsberg <danken(a)redhat.com>
5:23 a.m.
Vinzenz Feenstra has posted comments on this change.
Change subject: update NIC: having no custom properies is valid
......................................................................
Patch Set 2: Code-Review+1
--
To view, visit http://gerrit.ovirt.org/22922
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: If510f012039304ad16000d46d9d72a3e035539f5
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Antoni Segura Puimedon <asegurap(a)redhat.com>
Gerrit-Reviewer: Assaf Muller <amuller(a)redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani(a)redhat.com>
Gerrit-Reviewer: Vinzenz Feenstra <vfeenstr(a)redhat.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei(a)redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: No
4:56 a.m.
Francesco Romani has posted comments on this change.
Change subject: update NIC: having no custom properies is valid
......................................................................
Patch Set 2: Code-Review+1
--
To view, visit http://gerrit.ovirt.org/22922
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: If510f012039304ad16000d46d9d72a3e035539f5
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Antoni Segura Puimedon <asegurap(a)redhat.com>
Gerrit-Reviewer: Assaf Muller <amuller(a)redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani(a)redhat.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei(a)redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: No
3:33 a.m.
Assaf Muller has posted comments on this change.
Change subject: update NIC: having no custom properies is valid
......................................................................
Patch Set 2: Code-Review+1
Looks like this is the only "params.get('custom')" usage... What a weird
miss.
--
To view, visit http://gerrit.ovirt.org/22922
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: If510f012039304ad16000d46d9d72a3e035539f5
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Antoni Segura Puimedon <asegurap(a)redhat.com>
Gerrit-Reviewer: Assaf Muller <amuller(a)redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani(a)redhat.com>
Gerrit-Reviewer: Vinzenz Feenstra <vfeenstr(a)redhat.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei(a)redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: No
11:27 a.m.
oVirt Jenkins CI Server has posted comments on this change.
Change subject: update NIC: having no custom properies is valid
......................................................................
Patch Set 2:
Build Successful
http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/6522/ : SUCCESS
http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/5629/ : SUCCESS
http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/6435/ : SUCCESS
--
To view, visit http://gerrit.ovirt.org/22922
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: If510f012039304ad16000d46d9d72a3e035539f5
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Antoni Segura Puimedon <asegurap(a)redhat.com>
Gerrit-Reviewer: Assaf Muller <amuller(a)redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: No
9:14 a.m.
oVirt Jenkins CI Server has posted comments on this change.
Change subject: update NIC: having no custom properies is valid
......................................................................
Patch Set 1:
Build Successful
http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/6518/ : SUCCESS
http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/5625/ : SUCCESS
http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/6431/ : SUCCESS
--
To view, visit http://gerrit.ovirt.org/22922
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: If510f012039304ad16000d46d9d72a3e035539f5
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: No
9:57 a.m.
Dan Kenigsberg has posted comments on this change.
Change subject: update NIC: having no custom properies is valid
......................................................................
Patch Set 2: Verified+1 Code-Review+2
--
To view, visit http://gerrit.ovirt.org/22922
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: If510f012039304ad16000d46d9d72a3e035539f5
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Antoni Segura Puimedon <asegurap(a)redhat.com>
Gerrit-Reviewer: Assaf Muller <amuller(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani(a)redhat.com>
Gerrit-Reviewer: Vinzenz Feenstra <vfeenstr(a)redhat.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei(a)redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: No
9:57 a.m.
Dan Kenigsberg has submitted this change and it was merged.
Change subject: update NIC: having no custom properies is valid
......................................................................
update NIC: having no custom properies is valid
Older Engines, that preceded per-vNIC custom properties (Vdsm commit
38b1f8fb) do not send the "custom" element at all. This has to be
interpreted exactly as an empty custom element.
Bug-Url: https://bugzilla.redhat.com/1047646
Change-Id: If510f012039304ad16000d46d9d72a3e035539f5
Signed-off-by: Dan Kenigsberg <danken(a)redhat.com>
Reviewed-on: http://gerrit.ovirt.org/22922
Reviewed-by: Francesco Romani <fromani(a)redhat.com>
Reviewed-by: Vinzenz Feenstra <vfeenstr(a)redhat.com>
Reviewed-by: Assaf Muller <amuller(a)redhat.com>
---
M vdsm/vm.py
1 file changed, 1 insertion(+), 1 deletion(-)
Approvals:
Vinzenz Feenstra: Looks good to me, but someone else must approve
Assaf Muller: Looks good to me, but someone else must approve
Dan Kenigsberg: Verified; Looks good to me, approved
Francesco Romani: Looks good to me, but someone else must approve
--
To view, visit http://gerrit.ovirt.org/22922
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: If510f012039304ad16000d46d9d72a3e035539f5
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Antoni Segura Puimedon <asegurap(a)redhat.com>
Gerrit-Reviewer: Assaf Muller <amuller(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani(a)redhat.com>
Gerrit-Reviewer: Vinzenz Feenstra <vfeenstr(a)redhat.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei(a)redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
3804
days inactive
3806
days old
vdsm-patches@lists.fedorahosted.org
7 comments
5 participants
participants (5)
-
amuller＠redhat.com -
Dan Kenigsberg -
fromani＠redhat.com -
Jenkins CI RO -
Vinzenz Feenstra