Francesco Romani has uploaded a new change for review.
Change subject: tests: fix pep8 errors ......................................................................
tests: fix pep8 errors
Commit: ff6f1bd45ddd7e019761d81aa2a338cf58e15caf introduced a couple of pep8 errors in tests. This patch fixes that.
Change-Id: Ieefeb049d295ed89cdfedc7ccc9daee05b7de712 Signed-off-by: Francesco Romani fromani@redhat.com --- M tests/vmTests.py 1 file changed, 4 insertions(+), 6 deletions(-)
git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/60/29960/1
diff --git a/tests/vmTests.py b/tests/vmTests.py index 2be5282..45578c6 100644 --- a/tests/vmTests.py +++ b/tests/vmTests.py @@ -24,7 +24,7 @@ import re import shutil import tempfile -import xml.dom.minidom +from xml.dom.minidom import Element as XMLElement import xml.etree.ElementTree as ET
import libvirt @@ -62,7 +62,7 @@
def _failIfRequested(self): if self._virtError != libvirt.VIR_ERR_OK: - err = libvirt.libvirtError(defmsg='') + err = libvirt.libvirtError(defmsg='') err.err = [self._virtError] raise err
@@ -879,15 +879,13 @@ def testGetVmPolicySucceded(self): with FakeVM() as fake: fake._dom = FakeDomain() - self.assertTrue(isinstance(fake._getVmPolicy(), - xml.dom.minidom.Element)) + self.assertTrue(isinstance(fake._getVmPolicy(), XMLElement))
def testGetVmPolicyEmptyOnNoMetadata(self): with FakeVM() as fake: fake._dom = FakeDomain( virtError=libvirt.VIR_ERR_NO_DOMAIN_METADATA) - self.assertTrue(isinstance(fake._getVmPolicy(), - xml.dom.minidom.Element)) + self.assertTrue(isinstance(fake._getVmPolicy(), XMLElement))
def testGetVmPolicyFailOnNoDomain(self): with FakeVM() as fake:
oVirt Jenkins CI Server has posted comments on this change.
Change subject: tests: fix pep8 errors ......................................................................
Patch Set 1:
Build Successful
http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit_el/10170/ : SUCCESS
http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/10955/ : SUCCESS
http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created/11112/ : SUCCESS
oVirt Jenkins CI Server has posted comments on this change.
Change subject: tests: fix pep8 errors ......................................................................
Patch Set 2:
Build Successful
http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit_el/10171/ : SUCCESS
http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/10956/ : SUCCESS
http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created/11113/ : SUCCESS
Francesco Romani has posted comments on this change.
Change subject: tests: fix pep8 errors ......................................................................
Patch Set 2: Verified+1
Martin Sivák has posted comments on this change.
Change subject: tests: fix pep8 errors ......................................................................
Patch Set 2: Code-Review+1
Dan Kenigsberg has posted comments on this change.
Change subject: tests: fix pep8 errors ......................................................................
Patch Set 4: Code-Review+2
Dan Kenigsberg has submitted this change and it was merged.
Change subject: tests: fix pep8 errors ......................................................................
tests: fix pep8 errors
Commit: a2890d5d614e856a44102d61576a8591a8d2e52f introduced pep8 and pyflakes errors in tests. This patch fixes that.
Change-Id: Ieefeb049d295ed89cdfedc7ccc9daee05b7de712 Signed-off-by: Francesco Romani fromani@redhat.com Reviewed-on: http://gerrit.ovirt.org/29960 Reviewed-by: Martin Sivák msivak@redhat.com Reviewed-by: Dan Kenigsberg danken@redhat.com --- M tests/vmTests.py 1 file changed, 3 insertions(+), 6 deletions(-)
Approvals: Martin Sivák: Looks good to me, but someone else must approve Dan Kenigsberg: Looks good to me, approved Francesco Romani: Verified
oVirt Jenkins CI Server has posted comments on this change.
Change subject: tests: fix pep8 errors ......................................................................
Patch Set 3:
Build Successful
http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit_el/10179/ : SUCCESS
http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/10964/ : SUCCESS
http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created/11121/ : SUCCESS
oVirt Jenkins CI Server has posted comments on this change.
Change subject: tests: fix pep8 errors ......................................................................
Patch Set 4:
Build Successful
http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit_el/10180/ : SUCCESS
http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/10965/ : SUCCESS
http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created/11122/ : SUCCESS
oVirt Jenkins CI Server has posted comments on this change.
Change subject: tests: fix pep8 errors ......................................................................
Patch Set 5:
Build Successful
http://jenkins.ovirt.org/job/vdsm_master_verify-error-codes_merged/5595/ : SUCCESS
http://jenkins.ovirt.org/job/vdsm_master_unit-tests_merged/3753/ : SUCCESS
http://jenkins.ovirt.org/job/vdsm_master_create-rpms_merged/1611/ : SUCCESS
vdsm-patches@lists.fedorahosted.org