Adam Litke has uploaded a new change for review.
Change subject: VolumeMetadata: Move getParentVolume ......................................................................
VolumeMetadata: Move getParentVolume
Move getParentVolume into VolumeMetadata. If HSM configured sdCache to return StorageDomainManifest objects then this will return VolumeMetadata objects. Otherwise it will continue to return Volume objects as it always has.
Change-Id: I74def8861e0b7b97ca4d218a969440ccba7f07dd Signed-off-by: Adam Litke alitke@redhat.com --- M vdsm/storage/volume.py 1 file changed, 11 insertions(+), 5 deletions(-)
git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/42/44042/1
diff --git a/vdsm/storage/volume.py b/vdsm/storage/volume.py index c40ba77..f7e5bc0 100644 --- a/vdsm/storage/volume.py +++ b/vdsm/storage/volume.py @@ -485,6 +485,16 @@ """ pass # Do not remove this method or the V3 upgrade will fail.
+ def getParentVolume(self): + """ + Return parent volume object + """ + puuid = self.getParent() + if puuid and puuid != BLANK_UUID: + return sdCache.produce(self.sdUUID).produceVolume(self.imgUUID, + puuid) + return None +
class Volume(object): log = logging.getLogger('Storage.Volume') @@ -1128,11 +1138,7 @@ """ Return parent volume object """ - puuid = self.getParent() - if puuid and puuid != BLANK_UUID: - return sdCache.produce(self.sdUUID).produceVolume(self.imgUUID, - puuid) - return None + return self.md.getParentVolume()
def setParent(self, puuid): """
automation@ovirt.org has posted comments on this change.
Change subject: VolumeMetadata: Move getParentVolume ......................................................................
Patch Set 1:
* Update tracker::IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a valid url. * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3'])
automation@ovirt.org has posted comments on this change.
Change subject: VolumeMetadata: Move getParentVolume ......................................................................
Patch Set 2:
* Update tracker::IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a valid url. * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3'])
automation@ovirt.org has posted comments on this change.
Change subject: VolumeMetadata: Move getParentVolume ......................................................................
Patch Set 3:
* Update tracker::IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a valid url. * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3'])
automation@ovirt.org has posted comments on this change.
Change subject: VolumeMetadata: Move getParentVolume ......................................................................
Patch Set 4:
* Update tracker::IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a valid url. * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3'])
automation@ovirt.org has posted comments on this change.
Change subject: VolumeMetadata: Move getParentVolume ......................................................................
Patch Set 5:
* Update tracker::IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a valid url. * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3'])
gerrit-hooks has posted comments on this change.
Change subject: VolumeMetadata: Add getParentVolume ......................................................................
Patch Set 13:
* Update tracker: IGNORE, no Bug-Url found
Jenkins CI RO has abandoned this change.
Change subject: VolumeMetadata: Add getParentVolume ......................................................................
Abandoned
Abandoned due to no activity - please restore if still relevant
vdsm-patches@lists.fedorahosted.org