From Yaniv Bronhaim <ybronhei(a)redhat.com>:
Yaniv Bronhaim has posted comments on this change.
Change subject: [RFC] procutils: Introduce the procutils module
......................................................................
Patch Set 2:
(5 comments)
https://gerrit.ovirt.org/#/c/74927/2//COMMIT_MSG
Commit Message:
Line 3: AuthorDate: 2017-03-28 03:38:45 +0300
Line 4: Commit: Nir Soffer <nsoffer(a)redhat.com>
Line 5: CommitDate: 2017-03-31 05:18:48 +0300
Line 6:
Line 7: [RFC] procutils: Introduce the procutils module
rpc means request for comments here? we usually use WIP or drafts
Line 8:
Line 9: This module provide utilities for working with subprocesses.
Line 10:
Line 11: The first utility is procutils.communicate(), replacing both AsyncProc,
Line 5: CommitDate: 2017-03-31 05:18:48 +0300
Line 6:
Line 7: [RFC] procutils: Introduce the procutils module
Line 8:
Line 9: This module provide utilities for working with subprocesses.
what else do you see in this module? why not to add timed_communicate as you suggested in
the past? is this part copied from Popen.communicate py3 implementation?
Line 10:
Line 11: The first utility is procutils.communicate(), replacing both AsyncProc,
Line 12: and CommandStream. This function allows reading from 2 streams in the
Line 13: same time, without using callbacks as in CommandStream, and avoiding the
Line 8:
Line 9: This module provide utilities for working with subprocesses.
Line 10:
Line 11: The first utility is procutils.communicate(), replacing both AsyncProc,
Line 12: and CommandStream. This function allows reading from 2 streams in the
write here where its needed
Line 13: same time, without using callbacks as in CommandStream, and avoiding the
Line 14: performance issues and complexity of AsyncProc.
Line 15:
Line 16: procutils.communicate() does not support writing to and reading from a
Line 35: test_asyncproc_read 1.00g in 17.02 seconds (0.06g/s) OK
Line 36: test_asyncproc_write 1.00g in 13.71 seconds (0.07g/s) OK
Line 37: test_plain_read 1.00g in 0.45 seconds (2.22g/s) OK
Line 38: test_read 1.00g in 0.53 seconds (1.89g/s) OK
Line 39: test_write 1.00g in 0.49 seconds (2.04g/s) OK
g is gb ? where is the comparation here?
Line 40:
Line 41: Change-Id: I7d193caa5da0ed564b4fab12aa85e3751f1a1df7
Line 36: test_asyncproc_write 1.00g in 13.71 seconds (0.07g/s) OK
Line 37: test_plain_read 1.00g in 0.45 seconds (2.22g/s) OK
Line 38: test_read 1.00g in 0.53 seconds (1.89g/s) OK
Line 39: test_write 1.00g in 0.49 seconds (2.04g/s) OK
Line 40:
should this function replace all communicate calls?
Line 41: Change-Id: I7d193caa5da0ed564b4fab12aa85e3751f1a1df7
--
To view, visit
https://gerrit.ovirt.org/74927
To unsubscribe, visit
https://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I7d193caa5da0ed564b4fab12aa85e3751f1a1df7
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Nir Soffer <nsoffer(a)redhat.com>
Gerrit-Reviewer: Adam Litke <alitke(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski(a)gmail.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
Gerrit-HasComments: Yes