From Dan Kenigsberg <danken(a)redhat.com>:
Dan Kenigsberg has posted comments on this change.
Change subject: hostdev: add caching of device tree
......................................................................
Patch Set 7:
(2 comments)
very partial
https://gerrit.ovirt.org/#/c/67457/7/lib/vdsm/hostdev.py
File lib/vdsm/hostdev.py:
Line 68: class UnsuitableSCSIDevice(Exception):
Line 69: pass
Line 70:
Line 71:
Line 72: class DeviceTreeCache(object):
I hope this is not going to be public
Line 73:
Line 74: def __init__(self, devices):
Line 75: self._parent_to_device_name = {}
Line 76: # Store a reference so we can look up the params
PS7, Line 407: ret[1]
this is very opaque. can you use a proper name?
--
To view, visit
https://gerrit.ovirt.org/67457
To unsubscribe, visit
https://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I5b901fac8df23aed958fb9509008f9cfaee648c3
Gerrit-PatchSet: 7
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Martin Polednik <mpolednik(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Polednik <mpolednik(a)redhat.com>
Gerrit-Reviewer: Milan Zamazal <mzamazal(a)redhat.com>
Gerrit-Reviewer: Yaniv Kaul <ykaul(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
Gerrit-HasComments: Yes