6:58 a.m.
Oved Ourfali has uploaded a new change for review.
Change subject: jsonrpc: Image_upload missing in command_info
......................................................................
jsonrpc: Image_upload missing in command_info
Change-Id: I79e28fed4caf3da5bdfefe030e4cfccb823d81d7
Bug-Url: https://bugzilla.redhat.com/1177952
Signed-off-by: Oved Ourfali <oourfali(a)redhat.com>
---
M vdsm/rpc/Bridge.py
1 file changed, 1 insertion(+), 0 deletions(-)
git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/15/36515/1
diff --git a/vdsm/rpc/Bridge.py b/vdsm/rpc/Bridge.py
index f8c06f6..a42ff97 100644
--- a/vdsm/rpc/Bridge.py
+++ b/vdsm/rpc/Bridge.py
@@ -423,6 +423,7 @@
'Image_deleteVolumes': {'ret': 'uuid'},
'Image_getVolumes': {'ret': 'uuidlist'},
'Image_download': {'ret': 'uuid'},
+ 'Image_upload': {'ret': 'uuid'},
'Image_mergeSnapshots': {'ret': 'uuid'},
'Image_move': {'ret': 'uuid'},
'Image_reconcileVolumeChain': {'ret': 'volumes'},
--
To view, visit http://gerrit.ovirt.org/36515
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I79e28fed4caf3da5bdfefe030e4cfccb823d81d7
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Oved Ourfali <oourfali(a)redhat.com>
6:58 a.m.
automation(a)ovirt.org has posted comments on this change.
Change subject: jsonrpc: Image_upload missing in command_info
......................................................................
Patch Set 1:
* Update tracker::#1177952::OK
* Check Bug-Url::OK
* Check Public Bug::#1177952::OK, public bug
* Check Product::#1177952::OK, Correct product Red Hat Enterprise Virtualization Manager
* Check TR::SKIP, not in a monitored branch (ovirt-3.5 ovirt-3.4 ovirt-3.3 ovirt-3.2)
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.5',
'ovirt-3.4', 'ovirt-3.3'])
--
To view, visit http://gerrit.ovirt.org/36515
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I79e28fed4caf3da5bdfefe030e4cfccb823d81d7
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Oved Ourfali <oourfali(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-HasComments: No
7:03 a.m.
Oved Ourfali has posted comments on this change.
Change subject: jsonrpc: Image_upload missing in command_info
......................................................................
Patch Set 1: Verified+1
--
To view, visit http://gerrit.ovirt.org/36515
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I79e28fed4caf3da5bdfefe030e4cfccb823d81d7
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Oved Ourfali <oourfali(a)redhat.com>
Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-HasComments: No
7:11 a.m.
Barak Azulay has posted comments on this change.
Change subject: jsonrpc: Image_upload missing in command_info
......................................................................
Patch Set 1: Code-Review+1
--
To view, visit http://gerrit.ovirt.org/36515
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I79e28fed4caf3da5bdfefe030e4cfccb823d81d7
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Oved Ourfali <oourfali(a)redhat.com>
Gerrit-Reviewer: Barak Azulay <bazulay(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-HasComments: No
7:12 a.m.
Yaniv Bronhaim has posted comments on this change.
Change subject: jsonrpc: Image_upload missing in command_info
......................................................................
Patch Set 1: Code-Review+1
--
To view, visit http://gerrit.ovirt.org/36515
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I79e28fed4caf3da5bdfefe030e4cfccb823d81d7
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Oved Ourfali <oourfali(a)redhat.com>
Gerrit-Reviewer: Barak Azulay <bazulay(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-HasComments: No
7:19 a.m.
oVirt Jenkins CI Server has posted comments on this change.
Change subject: jsonrpc: Image_upload missing in command_info
......................................................................
Patch Set 1:
Build Failed
http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created/14755/ : SUCCESS
http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/14587/ : SUCCESS
http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit_el/13799/ : FAILURE
--
To view, visit http://gerrit.ovirt.org/36515
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I79e28fed4caf3da5bdfefe030e4cfccb823d81d7
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Oved Ourfali <oourfali(a)redhat.com>
Gerrit-Reviewer: Barak Azulay <bazulay(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: No
7:31 a.m.
Dan Kenigsberg has posted comments on this change.
Change subject: jsonrpc: Image_upload missing in command_info
......................................................................
Patch Set 1: Code-Review+2
(1 comment)
http://gerrit.ovirt.org/#/c/36515/1/vdsm/rpc/Bridge.py
File vdsm/rpc/Bridge.py:
Line 422: 'Image_delete': {'ret': 'uuid'},
Line 423: 'Image_deleteVolumes': {'ret': 'uuid'},
Line 424: 'Image_getVolumes': {'ret': 'uuidlist'},
Line 425: 'Image_download': {'ret': 'uuid'},
Line 426: 'Image_upload': {'ret': 'uuid'},
This is out of alphabetical order. Please fix in a follow up - I understand that we are in
great hurry.
Line 427: 'Image_mergeSnapshots': {'ret': 'uuid'},
Line 428: 'Image_move': {'ret': 'uuid'},
Line 429: 'Image_reconcileVolumeChain': {'ret': 'volumes'},
Line 430: 'Image_syncData': {'ret': 'uuid'},
--
To view, visit http://gerrit.ovirt.org/36515
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I79e28fed4caf3da5bdfefe030e4cfccb823d81d7
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Oved Ourfali <oourfali(a)redhat.com>
Gerrit-Reviewer: Barak Azulay <bazulay(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
7:31 a.m.
Dan Kenigsberg has submitted this change and it was merged.
Change subject: jsonrpc: Image_upload missing in command_info
......................................................................
jsonrpc: Image_upload missing in command_info
Change-Id: I79e28fed4caf3da5bdfefe030e4cfccb823d81d7
Bug-Url: https://bugzilla.redhat.com/1177952
Signed-off-by: Oved Ourfali <oourfali(a)redhat.com>
Reviewed-on: http://gerrit.ovirt.org/36515
Reviewed-by: Barak Azulay <bazulay(a)redhat.com>
Reviewed-by: Yaniv Bronhaim <ybronhei(a)redhat.com>
Reviewed-by: Dan Kenigsberg <danken(a)redhat.com>
---
M vdsm/rpc/Bridge.py
1 file changed, 1 insertion(+), 0 deletions(-)
Approvals:
Yaniv Bronhaim: Looks good to me, but someone else must approve
Barak Azulay: Looks good to me, but someone else must approve
Dan Kenigsberg: Looks good to me, approved
Oved Ourfali: Verified
--
To view, visit http://gerrit.ovirt.org/36515
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I79e28fed4caf3da5bdfefe030e4cfccb823d81d7
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Oved Ourfali <oourfali(a)redhat.com>
Gerrit-Reviewer: Barak Azulay <bazulay(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
7:31 a.m.
automation(a)ovirt.org has posted comments on this change.
Change subject: jsonrpc: Image_upload missing in command_info
......................................................................
Patch Set 2:
* Update tracker::#1177952::OK
* Set MODIFIED::bug 1177952::::#1177952::::IGNORE, not oVirt prod but Red Hat Enterprise
Virtualization Manager
--
To view, visit http://gerrit.ovirt.org/36515
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I79e28fed4caf3da5bdfefe030e4cfccb823d81d7
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Oved Ourfali <oourfali(a)redhat.com>
Gerrit-Reviewer: Barak Azulay <bazulay(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: No
8:31 a.m.
oVirt Jenkins CI Server has posted comments on this change.
Change subject: jsonrpc: Image_upload missing in command_info
......................................................................
Patch Set 2:
Build Failed
http://jenkins.ovirt.org/job/vdsm_master_verify-error-codes_merged/6257/ : SUCCESS
http://jenkins.ovirt.org/job/vdsm_master_create-rpms-el7-x86_64_merged/436/ : SUCCESS
http://jenkins.ovirt.org/job/vdsm_master_create-rpms-el6-x86_64_merged/434/ : SUCCESS
http://jenkins.ovirt.org/job/vdsm_master_create-rpms-fc20-x86_64_merged/427/ : SUCCESS
http://jenkins.ovirt.org/job/vdsm_master_create-rpms-fc21-x86_64_merged/411/ : SUCCESS
http://jenkins.ovirt.org/job/vdsm_master-libgfapi_create-rpms-el7-x86_64_... :
SUCCESS
http://jenkins.ovirt.org/job/vdsm_master-libgfapi_create-rpms-el6-x86_64_... :
FAILURE
http://jenkins.ovirt.org/job/vdsm_master-libgfapi_create-rpms-fc20-x86_64... :
SUCCESS
http://jenkins.ovirt.org/job/vdsm_master-libgfapi_create-rpms-fc21-x86_64... :
SUCCESS
http://jenkins.ovirt.org/job/vdsm_master_unit-tests_merged/4422/ : SUCCESS
--
To view, visit http://gerrit.ovirt.org/36515
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I79e28fed4caf3da5bdfefe030e4cfccb823d81d7
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Oved Ourfali <oourfali(a)redhat.com>
Gerrit-Reviewer: Barak Azulay <bazulay(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: No
3428
days inactive
3428
days old
vdsm-patches@lists.fedorahosted.org
9 comments
6 participants
participants (6)
-
automation＠ovirt.org -
bazulay＠redhat.com -
Dan Kenigsberg -
Jenkins CI RO -
Oved Ourfali -
ybronhei＠redhat.com