Xu He Jie has uploaded a new change for review.
Change subject: split logrotate configure into two file for coredump and log ......................................................................
split logrotate configure into two file for coredump and log
We will only collected core dump for rl6 in default, so split it into two file will easy for config.
Change-Id: Ic22b4ac89583aa8a73863a7c3e1574895159c978 Signed-off-by: Xu He Jie xuhj@linux.vnet.ibm.com --- M vdsm.spec.in M vdsm/Makefile.am R vdsm/vdsm-logrotate-coredump A vdsm/vdsm-logrotate-coredump.conf.in A vdsm/vdsm-logrotate-log A vdsm/vdsm-logrotate-log.conf.in D vdsm/vdsm-logrotate.conf.in 7 files changed, 50 insertions(+), 30 deletions(-)
git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/52/5152/1 -- To view, visit http://gerrit.ovirt.org/5152 To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: newchange Gerrit-Change-Id: Ic22b4ac89583aa8a73863a7c3e1574895159c978 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Xu He Jie xuhj@linux.vnet.ibm.com
Xu He Jie has posted comments on this change.
Change subject: split logrotate configure into two file for coredump and log ......................................................................
Patch Set 1: Verified
-- To view, visit http://gerrit.ovirt.org/5152 To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment Gerrit-Change-Id: Ic22b4ac89583aa8a73863a7c3e1574895159c978 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Xu He Jie xuhj@linux.vnet.ibm.com Gerrit-Reviewer: Xu He Jie xuhj@linux.vnet.ibm.com
Dan Kenigsberg has posted comments on this change.
Change subject: split logrotate configure into two file for coredump and log ......................................................................
Patch Set 1: I would prefer that you didn't submit this
-- To view, visit http://gerrit.ovirt.org/5152 To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment Gerrit-Change-Id: Ic22b4ac89583aa8a73863a7c3e1574895159c978 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Xu He Jie xuhj@linux.vnet.ibm.com Gerrit-Reviewer: Dan Kenigsberg danken@redhat.com Gerrit-Reviewer: Xu He Jie xuhj@linux.vnet.ibm.com
Dan Kenigsberg has posted comments on this change.
Change subject: split logrotate configure into two file for coredump and log ......................................................................
Patch Set 1: (3 inline comments)
makes a lot of sense, minor text issues within.
.................................................... Commit Message Line 9: We will only collected core dump for rl6 in default, so split ->"we will only collect core dump for el6 by default, so splitting it into two files will be easier." is better English imo.
.................................................... File vdsm/vdsm-logrotate-coredump Line 7: /usr/bin/logger -t logrotate "ALERT rotated vdsm core dump exited abnormally with [$EXITVALUE]" maybe change "rotated vdsm core dump" to "vdsm core dump rotation"
.................................................... File vdsm/vdsm-logrotate-log Line 7: /usr/bin/logger -t logrotate "ALERT rotated vdsm log exited abnormally with [$EXITVALUE]" same English issue.
-- To view, visit http://gerrit.ovirt.org/5152 To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment Gerrit-Change-Id: Ic22b4ac89583aa8a73863a7c3e1574895159c978 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Xu He Jie xuhj@linux.vnet.ibm.com Gerrit-Reviewer: Dan Kenigsberg danken@redhat.com Gerrit-Reviewer: Xu He Jie xuhj@linux.vnet.ibm.com
Xu He Jie has posted comments on this change.
Change subject: split logrotate configure into two file for coredump and log ......................................................................
Patch Set 1: (3 inline comments)
.................................................... Commit Message Line 9: We will only collected core dump for rl6 in default, so split Thanks, I really should improve my English!
.................................................... File vdsm/vdsm-logrotate-coredump Line 7: /usr/bin/logger -t logrotate "ALERT rotated vdsm core dump exited abnormally with [$EXITVALUE]" Done
.................................................... File vdsm/vdsm-logrotate-log Line 7: /usr/bin/logger -t logrotate "ALERT rotated vdsm log exited abnormally with [$EXITVALUE]" Done
-- To view, visit http://gerrit.ovirt.org/5152 To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment Gerrit-Change-Id: Ic22b4ac89583aa8a73863a7c3e1574895159c978 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Xu He Jie xuhj@linux.vnet.ibm.com Gerrit-Reviewer: Dan Kenigsberg danken@redhat.com Gerrit-Reviewer: Xu He Jie xuhj@linux.vnet.ibm.com
Xu He Jie has posted comments on this change.
Change subject: split logrotate configure into two file for coredump and log ......................................................................
Patch Set 2: Verified
-- To view, visit http://gerrit.ovirt.org/5152 To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment Gerrit-Change-Id: Ic22b4ac89583aa8a73863a7c3e1574895159c978 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Xu He Jie xuhj@linux.vnet.ibm.com Gerrit-Reviewer: Dan Kenigsberg danken@redhat.com Gerrit-Reviewer: Xu He Jie xuhj@linux.vnet.ibm.com
Xu He Jie has posted comments on this change.
Change subject: split logrotate configure into two file for coredump and log ......................................................................
Patch Set 3: Verified
-- To view, visit http://gerrit.ovirt.org/5152 To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment Gerrit-Change-Id: Ic22b4ac89583aa8a73863a7c3e1574895159c978 Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Xu He Jie xuhj@linux.vnet.ibm.com Gerrit-Reviewer: Dan Kenigsberg danken@redhat.com Gerrit-Reviewer: Xu He Jie xuhj@linux.vnet.ibm.com
Dan Kenigsberg has posted comments on this change.
Change subject: split logrotate configure into two file for coredump and log ......................................................................
Patch Set 5: Looks good to me, but someone else must approve
-- To view, visit http://gerrit.ovirt.org/5152 To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment Gerrit-Change-Id: Ic22b4ac89583aa8a73863a7c3e1574895159c978 Gerrit-PatchSet: 5 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Xu He Jie xuhj@linux.vnet.ibm.com Gerrit-Reviewer: Dan Kenigsberg danken@redhat.com Gerrit-Reviewer: Xu He Jie xuhj@linux.vnet.ibm.com
Xu He Jie has posted comments on this change.
Change subject: split logrotate configure into two file for coredump and log ......................................................................
Patch Set 5: Verified
-- To view, visit http://gerrit.ovirt.org/5152 To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment Gerrit-Change-Id: Ic22b4ac89583aa8a73863a7c3e1574895159c978 Gerrit-PatchSet: 5 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Xu He Jie xuhj@linux.vnet.ibm.com Gerrit-Reviewer: Dan Kenigsberg danken@redhat.com Gerrit-Reviewer: Xu He Jie xuhj@linux.vnet.ibm.com
Dan Kenigsberg has posted comments on this change.
Change subject: split logrotate configure into two file for coredump and log ......................................................................
Patch Set 5: I would prefer that you didn't submit this
we need to fix http://gerrit.ovirt.org/5150 (and to verify it on el6, too)
-- To view, visit http://gerrit.ovirt.org/5152 To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment Gerrit-Change-Id: Ic22b4ac89583aa8a73863a7c3e1574895159c978 Gerrit-PatchSet: 5 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Xu He Jie xuhj@linux.vnet.ibm.com Gerrit-Reviewer: Dan Kenigsberg danken@redhat.com Gerrit-Reviewer: Xu He Jie xuhj@linux.vnet.ibm.com
Xu He Jie has posted comments on this change.
Change subject: split logrotate configure into two file for coredump and log ......................................................................
Patch Set 5:
Why that can pass on fedora? On fedora it will be '/usr/local/var/log/core' too. Did you know the reason?
-- To view, visit http://gerrit.ovirt.org/5152 To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment Gerrit-Change-Id: Ic22b4ac89583aa8a73863a7c3e1574895159c978 Gerrit-PatchSet: 5 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Xu He Jie xuhj@linux.vnet.ibm.com Gerrit-Reviewer: Dan Kenigsberg danken@redhat.com Gerrit-Reviewer: Xu He Jie xuhj@linux.vnet.ibm.com
Dan Kenigsberg has posted comments on this change.
Change subject: split logrotate configure into two file for coredump and log ......................................................................
Patch Set 5:
I do not know. I'm asking you to try to understand the issue.
-- To view, visit http://gerrit.ovirt.org/5152 To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment Gerrit-Change-Id: Ic22b4ac89583aa8a73863a7c3e1574895159c978 Gerrit-PatchSet: 5 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Xu He Jie xuhj@linux.vnet.ibm.com Gerrit-Reviewer: Dan Kenigsberg danken@redhat.com Gerrit-Reviewer: Xu He Jie xuhj@linux.vnet.ibm.com
oVirt Jenkins CI Server has posted comments on this change.
Change subject: split logrotate configure into two file for coredump and log ......................................................................
Patch Set 5: No score
Build Started http://jenkins.ovirt.info/job/vdsm_unit_tests_by_patch/162/
-- To view, visit http://gerrit.ovirt.org/5152 To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment Gerrit-Change-Id: Ic22b4ac89583aa8a73863a7c3e1574895159c978 Gerrit-PatchSet: 5 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Xu He Jie xuhj@linux.vnet.ibm.com Gerrit-Reviewer: Dan Kenigsberg danken@redhat.com Gerrit-Reviewer: Xu He Jie xuhj@linux.vnet.ibm.com Gerrit-Reviewer: oVirt Jenkins CI Server
oVirt Jenkins CI Server has posted comments on this change.
Change subject: split logrotate configure into two file for coredump and log ......................................................................
Patch Set 5:
Build Successful
http://jenkins.ovirt.info/job/vdsm_unit_tests_by_patch/162/ : SUCCESS
-- To view, visit http://gerrit.ovirt.org/5152 To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment Gerrit-Change-Id: Ic22b4ac89583aa8a73863a7c3e1574895159c978 Gerrit-PatchSet: 5 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Xu He Jie xuhj@linux.vnet.ibm.com Gerrit-Reviewer: Dan Kenigsberg danken@redhat.com Gerrit-Reviewer: Xu He Jie xuhj@linux.vnet.ibm.com Gerrit-Reviewer: oVirt Jenkins CI Server
Xu He Jie has abandoned this change.
Change subject: split logrotate configure into two file for coredump and log ......................................................................
Patch Set 5: Abandoned
-- To view, visit http://gerrit.ovirt.org/5152 To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: abandon Gerrit-Change-Id: Ic22b4ac89583aa8a73863a7c3e1574895159c978 Gerrit-PatchSet: 5 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Xu He Jie xuhj@linux.vnet.ibm.com Gerrit-Reviewer: Dan Kenigsberg danken@redhat.com Gerrit-Reviewer: Xu He Jie xuhj@linux.vnet.ibm.com Gerrit-Reviewer: oVirt Jenkins CI Server
vdsm-patches@lists.fedorahosted.org
-
Dan Kenigsberg -
Jenkins CI RO -
Xu He Jie