Dan Kenigsberg has uploaded a new change for review.
Change subject: netConf: fix a sloppy rebase ......................................................................
netConf: fix a sloppy rebase
Commit 5cabaaa1 is refering to ConfigWriter.NET_CONF_PREF which was dropped by a parallel commit 1ebff6e5b.
Change-Id: Ibecb8d6797f64e4239d7078566fbca5b89f030fc Signed-off-by: Dan Kenigsberg danken@redhat.com --- M vdsm/configNetwork.py 1 file changed, 2 insertions(+), 2 deletions(-)
git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/82/10582/1
diff --git a/vdsm/configNetwork.py b/vdsm/configNetwork.py index e812bcb..5290436 100755 --- a/vdsm/configNetwork.py +++ b/vdsm/configNetwork.py @@ -1177,11 +1177,11 @@ elif not bondingOtherUsers(network, vlan, bonding): # update MTU for bond interface and underlying NICs ifdown(bonding) - cf = configWriter.NET_CONF_PREF + bonding + cf = netinfo.NET_CONF_PREF + bonding configWriter._updateConfigValue(cf, 'MTU', DEFAULT_MTU, False) for nic in nics: ifdown(nic) - cf = configWriter.NET_CONF_PREF + nic + cf = netinfo.NET_CONF_PREF + nic configWriter._updateConfigValue(cf, 'MTU', DEFAULT_MTU, False)
ifup(bonding)
-- To view, visit http://gerrit.ovirt.org/10582 To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: newchange Gerrit-Change-Id: Ibecb8d6797f64e4239d7078566fbca5b89f030fc Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Dan Kenigsberg danken@redhat.com
oVirt Jenkins CI Server has posted comments on this change.
Change subject: netConf: fix a sloppy rebase ......................................................................
Patch Set 1:
Build Started http://jenkins.ovirt.org/job/vdsm_unit_tests_manual_gerrit/548/ (1/2)
-- To view, visit http://gerrit.ovirt.org/10582 To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment Gerrit-Change-Id: Ibecb8d6797f64e4239d7078566fbca5b89f030fc Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Dan Kenigsberg danken@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server
oVirt Jenkins CI Server has posted comments on this change.
Change subject: netConf: fix a sloppy rebase ......................................................................
Patch Set 1:
Build Started http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/513/ (2/2)
-- To view, visit http://gerrit.ovirt.org/10582 To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment Gerrit-Change-Id: Ibecb8d6797f64e4239d7078566fbca5b89f030fc Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Dan Kenigsberg danken@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server
oVirt Jenkins CI Server has posted comments on this change.
Change subject: netConf: fix a sloppy rebase ......................................................................
Patch Set 1:
Build Successful
http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/513/ : SUCCESS
http://jenkins.ovirt.org/job/vdsm_unit_tests_manual_gerrit/548/ : SUCCESS
-- To view, visit http://gerrit.ovirt.org/10582 To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment Gerrit-Change-Id: Ibecb8d6797f64e4239d7078566fbca5b89f030fc Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Dan Kenigsberg danken@redhat.com Gerrit-Reviewer: Antoni Segura Puimedon asegurap@redhat.com Gerrit-Reviewer: Igor Lvovsky ilvovsky@redhat.com Gerrit-Reviewer: Livnat Peer lpeer@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server
Igor Lvovsky has posted comments on this change.
Change subject: netConf: fix a sloppy rebase ......................................................................
Patch Set 1: Looks good to me, approved
-- To view, visit http://gerrit.ovirt.org/10582 To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment Gerrit-Change-Id: Ibecb8d6797f64e4239d7078566fbca5b89f030fc Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Dan Kenigsberg danken@redhat.com Gerrit-Reviewer: Antoni Segura Puimedon asegurap@redhat.com Gerrit-Reviewer: Igor Lvovsky ilvovsky@redhat.com Gerrit-Reviewer: Livnat Peer lpeer@redhat.com Gerrit-Reviewer: Mark Wu wudxw@linux.vnet.ibm.com Gerrit-Reviewer: oVirt Jenkins CI Server
Dan Kenigsberg has posted comments on this change.
Change subject: netConf: fix a sloppy rebase ......................................................................
Patch Set 1: Verified
thanks, I hate to keep 'master' broken.
-- To view, visit http://gerrit.ovirt.org/10582 To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment Gerrit-Change-Id: Ibecb8d6797f64e4239d7078566fbca5b89f030fc Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Dan Kenigsberg danken@redhat.com Gerrit-Reviewer: Antoni Segura Puimedon asegurap@redhat.com Gerrit-Reviewer: Dan Kenigsberg danken@redhat.com Gerrit-Reviewer: Igor Lvovsky ilvovsky@redhat.com Gerrit-Reviewer: Livnat Peer lpeer@redhat.com Gerrit-Reviewer: Mark Wu wudxw@linux.vnet.ibm.com Gerrit-Reviewer: oVirt Jenkins CI Server
Dan Kenigsberg has submitted this change and it was merged.
Change subject: netConf: fix a sloppy rebase ......................................................................
netConf: fix a sloppy rebase
Commit 5cabaaa1 is refering to ConfigWriter.NET_CONF_PREF which was dropped by a parallel commit 1ebff6e5b.
Change-Id: Ibecb8d6797f64e4239d7078566fbca5b89f030fc Signed-off-by: Dan Kenigsberg danken@redhat.com --- M vdsm/configNetwork.py 1 file changed, 2 insertions(+), 2 deletions(-)
Approvals: Dan Kenigsberg: Verified Igor Lvovsky: Looks good to me, approved
-- To view, visit http://gerrit.ovirt.org/10582 To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged Gerrit-Change-Id: Ibecb8d6797f64e4239d7078566fbca5b89f030fc Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Dan Kenigsberg danken@redhat.com Gerrit-Reviewer: Antoni Segura Puimedon asegurap@redhat.com Gerrit-Reviewer: Dan Kenigsberg danken@redhat.com Gerrit-Reviewer: Igor Lvovsky ilvovsky@redhat.com Gerrit-Reviewer: Livnat Peer lpeer@redhat.com Gerrit-Reviewer: Mark Wu wudxw@linux.vnet.ibm.com Gerrit-Reviewer: oVirt Jenkins CI Server
vdsm-patches@lists.fedorahosted.org