From Dan Kenigsberg <danken(a)redhat.com>:
Dan Kenigsberg has posted comments on this change.
Change subject: net: modify VF MAC addresses on creation to a valid address
......................................................................
Patch Set 30:
(1 comment)
https://gerrit.ovirt.org/#/c/71029/30/lib/vdsm/network/api.py
File lib/vdsm/network/api.py:
PS30, Line 107: TARGET_MAC
I'm
not sure that pep8 says that now function-level constants are allowed. Anyway, I like
keeping ALL CAPS here.
--
To view, visit
https://gerrit.ovirt.org/71029
To unsubscribe, visit
https://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ib740d45206d41b330fd1b33f31765050cadbd679
Gerrit-PatchSet: 30
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Leon Goldberg <lgoldber(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Edward Haas <edwardh(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Leon Goldberg <lgoldber(a)redhat.com>
Gerrit-Reviewer: Meni Yakove <myakove(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
Gerrit-HasComments: Yes