Dan Kenigsberg has uploaded a new change for review.
Change subject: drop type() call ......................................................................
drop type() call
Python method resolution knows to find class methods as it is.
Change-Id: Ifd37f580c392412159cc7641336074d8894bd501 Signed-off-by: Dan Kenigsberg danken@redhat.com --- M vdsm/storage/imageRepository/formatConverter.py 1 file changed, 1 insertion(+), 1 deletion(-)
git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/16/8816/1
diff --git a/vdsm/storage/imageRepository/formatConverter.py b/vdsm/storage/imageRepository/formatConverter.py index d118e87..422cb39 100644 --- a/vdsm/storage/imageRepository/formatConverter.py +++ b/vdsm/storage/imageRepository/formatConverter.py @@ -149,7 +149,7 @@
log.debug("Creating the volume lease for %s", volUUID) metaId = vol.getMetadataId() - type(vol).newVolumeLease(metaId, domain.sdUUID, volUUID) + vol.newVolumeLease(metaId, domain.sdUUID, volUUID)
# If this volume is used as a template let's update the other # volume's permissions and share the volume lease (at the moment
-- To view, visit http://gerrit.ovirt.org/8816 To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: newchange Gerrit-Change-Id: Ifd37f580c392412159cc7641336074d8894bd501 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Dan Kenigsberg danken@redhat.com
Dan Kenigsberg has posted comments on this change.
Change subject: drop type() call ......................................................................
Patch Set 1:
Federico, please tell me if you had a hidden intention here.
-- To view, visit http://gerrit.ovirt.org/8816 To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment Gerrit-Change-Id: Ifd37f580c392412159cc7641336074d8894bd501 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Dan Kenigsberg danken@redhat.com Gerrit-Reviewer: Dan Kenigsberg danken@redhat.com Gerrit-Reviewer: Federico Simoncelli fsimonce@redhat.com
Zhou Zheng Sheng has posted comments on this change.
Change subject: drop type() call ......................................................................
Patch Set 1: Looks good to me, but someone else must approve
-- To view, visit http://gerrit.ovirt.org/8816 To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment Gerrit-Change-Id: Ifd37f580c392412159cc7641336074d8894bd501 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Dan Kenigsberg danken@redhat.com Gerrit-Reviewer: Dan Kenigsberg danken@redhat.com Gerrit-Reviewer: Federico Simoncelli fsimonce@redhat.com Gerrit-Reviewer: Zhou Zheng Sheng zhshzhou@linux.vnet.ibm.com
Federico Simoncelli has posted comments on this change.
Change subject: drop type() call ......................................................................
Patch Set 1: I would prefer that you didn't submit this
I think we can clean it from other places too: fileVolume.py and volume.py (at least).
-- To view, visit http://gerrit.ovirt.org/8816 To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment Gerrit-Change-Id: Ifd37f580c392412159cc7641336074d8894bd501 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Dan Kenigsberg danken@redhat.com Gerrit-Reviewer: Dan Kenigsberg danken@redhat.com Gerrit-Reviewer: Federico Simoncelli fsimonce@redhat.com Gerrit-Reviewer: Zhou Zheng Sheng zhshzhou@linux.vnet.ibm.com
Federico Simoncelli has posted comments on this change.
Change subject: drop type() calls ......................................................................
Patch Set 2: Looks good to me, but someone else must approve
-- To view, visit http://gerrit.ovirt.org/8816 To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment Gerrit-Change-Id: Ifd37f580c392412159cc7641336074d8894bd501 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Dan Kenigsberg danken@redhat.com Gerrit-Reviewer: Dan Kenigsberg danken@redhat.com Gerrit-Reviewer: Federico Simoncelli fsimonce@redhat.com Gerrit-Reviewer: Zhou Zheng Sheng zhshzhou@linux.vnet.ibm.com
Shu Ming has posted comments on this change.
Change subject: drop type() calls ......................................................................
Patch Set 2: Looks good to me, but someone else must approve
-- To view, visit http://gerrit.ovirt.org/8816 To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment Gerrit-Change-Id: Ifd37f580c392412159cc7641336074d8894bd501 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Dan Kenigsberg danken@redhat.com Gerrit-Reviewer: Dan Kenigsberg danken@redhat.com Gerrit-Reviewer: Federico Simoncelli fsimonce@redhat.com Gerrit-Reviewer: Shu Ming shuming@linux.vnet.ibm.com Gerrit-Reviewer: Zhou Zheng Sheng zhshzhou@linux.vnet.ibm.com
Zhou Zheng Sheng has posted comments on this change.
Change subject: drop type() calls ......................................................................
Patch Set 2: Looks good to me, but someone else must approve
This patch is not based on the latest master, so you will expect a lot of pep8 errors when building the patch. Those error are suppressed in the latest master. I rebase the patch and build successfully.
The changes in the code look OK.
-- To view, visit http://gerrit.ovirt.org/8816 To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment Gerrit-Change-Id: Ifd37f580c392412159cc7641336074d8894bd501 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Dan Kenigsberg danken@redhat.com Gerrit-Reviewer: Dan Kenigsberg danken@redhat.com Gerrit-Reviewer: Federico Simoncelli fsimonce@redhat.com Gerrit-Reviewer: Shu Ming shuming@linux.vnet.ibm.com Gerrit-Reviewer: Zhou Zheng Sheng zhshzhou@linux.vnet.ibm.com
Dan Kenigsberg has posted comments on this change.
Change subject: drop type() calls ......................................................................
Patch Set 2: Verified
verified by Basan
-- To view, visit http://gerrit.ovirt.org/8816 To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment Gerrit-Change-Id: Ifd37f580c392412159cc7641336074d8894bd501 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Dan Kenigsberg danken@redhat.com Gerrit-Reviewer: Dan Kenigsberg danken@redhat.com Gerrit-Reviewer: Federico Simoncelli fsimonce@redhat.com Gerrit-Reviewer: Shu Ming shuming@linux.vnet.ibm.com Gerrit-Reviewer: Zhou Zheng Sheng zhshzhou@linux.vnet.ibm.com
Dan Kenigsberg has posted comments on this change.
Change subject: drop type() calls ......................................................................
Patch Set 2: Looks good to me, approved
verified by Basan
-- To view, visit http://gerrit.ovirt.org/8816 To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment Gerrit-Change-Id: Ifd37f580c392412159cc7641336074d8894bd501 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Dan Kenigsberg danken@redhat.com Gerrit-Reviewer: Dan Kenigsberg danken@redhat.com Gerrit-Reviewer: Federico Simoncelli fsimonce@redhat.com Gerrit-Reviewer: Shu Ming shuming@linux.vnet.ibm.com Gerrit-Reviewer: Zhou Zheng Sheng zhshzhou@linux.vnet.ibm.com
Dan Kenigsberg has submitted this change and it was merged.
Change subject: drop type() calls ......................................................................
drop type() calls
Python method resolution knows to find class methods as it is.
Change-Id: Ifd37f580c392412159cc7641336074d8894bd501 Signed-off-by: Dan Kenigsberg danken@redhat.com --- M vdsm/storage/fileVolume.py M vdsm/storage/imageRepository/formatConverter.py M vdsm/storage/volume.py 3 files changed, 4 insertions(+), 4 deletions(-)
Approvals: Shu Ming: Looks good to me, but someone else must approve Federico Simoncelli: Looks good to me, but someone else must approve Dan Kenigsberg: Verified; Looks good to me, approved Zhou Zheng Sheng: Looks good to me, but someone else must approve
-- To view, visit http://gerrit.ovirt.org/8816 To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged Gerrit-Change-Id: Ifd37f580c392412159cc7641336074d8894bd501 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Dan Kenigsberg danken@redhat.com Gerrit-Reviewer: Dan Kenigsberg danken@redhat.com Gerrit-Reviewer: Federico Simoncelli fsimonce@redhat.com Gerrit-Reviewer: Shu Ming shuming@linux.vnet.ibm.com Gerrit-Reviewer: Zhou Zheng Sheng zhshzhou@linux.vnet.ibm.com
vdsm-patches@lists.fedorahosted.org