Xu He Jie has uploaded a new change for review.
Change subject: add vdsm-tool verb configure-core-dump ......................................................................
add vdsm-tool verb configure-core-dump
Change-Id: Ifed530a35339e1e2a366a61f1bce1a8c9e71db53 Signed-off-by: Xu He Jie xuhj@linux.vnet.ibm.com --- M vdsm-tool/Makefile.am A vdsm-tool/configureCoreDump.py M vdsm.spec.in M vdsm/constants.py.in M vdsm/vdsmd.init.in 5 files changed, 48 insertions(+), 17 deletions(-)
git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/54/5154/1 -- To view, visit http://gerrit.ovirt.org/5154 To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: newchange Gerrit-Change-Id: Ifed530a35339e1e2a366a61f1bce1a8c9e71db53 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Xu He Jie xuhj@linux.vnet.ibm.com
Xu He Jie has posted comments on this change.
Change subject: add vdsm-tool verb configure-core-dump ......................................................................
Patch Set 1: Verified
-- To view, visit http://gerrit.ovirt.org/5154 To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment Gerrit-Change-Id: Ifed530a35339e1e2a366a61f1bce1a8c9e71db53 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Xu He Jie xuhj@linux.vnet.ibm.com Gerrit-Reviewer: Xu He Jie xuhj@linux.vnet.ibm.com
Xu He Jie has posted comments on this change.
Change subject: add vdsm-tool verb configure-core-dump ......................................................................
Patch Set 2: Verified
-- To view, visit http://gerrit.ovirt.org/5154 To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment Gerrit-Change-Id: Ifed530a35339e1e2a366a61f1bce1a8c9e71db53 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Xu He Jie xuhj@linux.vnet.ibm.com Gerrit-Reviewer: Federico Simoncelli fsimonce@redhat.com Gerrit-Reviewer: Xu He Jie xuhj@linux.vnet.ibm.com
Federico Simoncelli has posted comments on this change.
Change subject: add vdsm-tool verb configure-core-dump ......................................................................
Patch Set 4: I would prefer that you didn't submit this
(2 inline comments)
.................................................... File vdsm-tool/configureCoreDump.py Line 30: if not config.getboolean('vars', 'core_dump_enable'): This doesn't catch the case where it was enabled and we want to disable it.
Line 38: with open(SYS_CORE_PATTERN, 'w+') as sysCorePattern: I disagree with this approach. We should configure this in /etc/sysctl.conf so that it survives reboots. Check also the other things that are supposed to go in the same file.
-- To view, visit http://gerrit.ovirt.org/5154 To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment Gerrit-Change-Id: Ifed530a35339e1e2a366a61f1bce1a8c9e71db53 Gerrit-PatchSet: 4 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Xu He Jie xuhj@linux.vnet.ibm.com Gerrit-Reviewer: Dan Kenigsberg danken@redhat.com Gerrit-Reviewer: Federico Simoncelli fsimonce@redhat.com Gerrit-Reviewer: Xu He Jie xuhj@linux.vnet.ibm.com
Xu He Jie has posted comments on this change.
Change subject: add vdsm-tool verb configure-core-dump ......................................................................
Patch Set 4: (2 inline comments)
.................................................... File vdsm-tool/configureCoreDump.py Line 30: if not config.getboolean('vars', 'core_dump_enable'): Done
Line 38: with open(SYS_CORE_PATTERN, 'w+') as sysCorePattern: It looks need write something to modify /etc/sysctl.d/vdsm at runtime. Thanks for the review!
-- To view, visit http://gerrit.ovirt.org/5154 To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment Gerrit-Change-Id: Ifed530a35339e1e2a366a61f1bce1a8c9e71db53 Gerrit-PatchSet: 4 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Xu He Jie xuhj@linux.vnet.ibm.com Gerrit-Reviewer: Dan Kenigsberg danken@redhat.com Gerrit-Reviewer: Federico Simoncelli fsimonce@redhat.com Gerrit-Reviewer: Xu He Jie xuhj@linux.vnet.ibm.com
Xu He Jie has abandoned this change.
Change subject: add vdsm-tool verb configure-core-dump ......................................................................
Patch Set 4: Abandoned
-- To view, visit http://gerrit.ovirt.org/5154 To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: abandon Gerrit-Change-Id: Ifed530a35339e1e2a366a61f1bce1a8c9e71db53 Gerrit-PatchSet: 4 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Xu He Jie xuhj@linux.vnet.ibm.com Gerrit-Reviewer: Dan Kenigsberg danken@redhat.com Gerrit-Reviewer: Federico Simoncelli fsimonce@redhat.com Gerrit-Reviewer: Xu He Jie xuhj@linux.vnet.ibm.com Gerrit-Reviewer: oVirt Jenkins CI Server
vdsm-patches@lists.fedorahosted.org
-
Federico Simoncelli -
Xu He Jie