Francesco Romani has uploaded a new change for review.
Change subject: spec: conflict with plain QEMU ......................................................................
spec: conflict with plain QEMU
The only stack supported by VDSM is VDSM - libvirt - qemu-kvm{ev,rhev}
Multiple qemu versions are not supported, yet some users managed to install them. This triggers a bug in the caps.getEmulatedMachines() function.
We will improve that function in a future patch to make it more robust, but first we should enforce the recommended configuration.
NOTE: this patch is relevant for RPM systems only, where there is distinction between qemu and qemu-kvm. Debian-based system do not have this split, so the misconfiguration is not possible.
https://bugzilla.redhat.com/1239258 Change-Id: Ib0cbc400f2a6711bc014d67931a4136c871bdd46 Signed-off-by: Francesco Romani fromani@redhat.com --- M vdsm.spec.in 1 file changed, 1 insertion(+), 0 deletions(-)
git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/23/45323/1
diff --git a/vdsm.spec.in b/vdsm.spec.in index 72e7df6..777b832 100644 --- a/vdsm.spec.in +++ b/vdsm.spec.in @@ -210,6 +210,7 @@ Requires: qemu-kvm >= 2:2.0.0-1 Requires: qemu-img >= 2:2.0.0-1 %endif # rhel +Conflicts: qemu
# GlusterFS client-side RPMs needed for Gluster SD %if 0%{?with_gluster}
automation@ovirt.org has posted comments on this change.
Change subject: spec: conflict with plain QEMU ......................................................................
Patch Set 1:
* Update tracker::IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a valid url. * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3'])
Martin Polednik has posted comments on this change.
Change subject: spec: conflict with plain QEMU ......................................................................
Patch Set 1: Code-Review+1
I'm okay with the idea, not sure if the spec works as expected (not enough knowledge on that front)
automation@ovirt.org has posted comments on this change.
Change subject: spec: conflict with plain QEMU ......................................................................
Patch Set 2:
* Update tracker::IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a valid url. * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3'])
Francesco Romani has posted comments on this change.
Change subject: spec: conflict with plain QEMU ......................................................................
Patch Set 2:
Verified conflicts works as expected . On CentOS, the only practical way (I'm aware of) to install qemu packages is to grab them from fedora repos. So I did. On a system with patched VDSM:
KENji> 10:57:33 fromani [~/rpmbuild/RPMS/x86_64]$ rpm -qa | grep vdsm vdsm-python-4.17.2-84.git4c0ce12.el7.centos.noarch vdsm-jsonrpc-4.17.2-84.git4c0ce12.el7.centos.noarch vdsm-xmlrpc-4.17.2-84.git4c0ce12.el7.centos.noarch vdsm-debuginfo-4.17.0-745.git5a18c64.el7.centos.x86_64 vdsm-4.17.2-84.git4c0ce12.el7.centos.noarch vdsm-python-zombiereaper-4.16.20-0.el7.centos.noarch rvdsm-infra-4.17.2-84.git4c0ce12.el7.centos.noarch pvdsm-yajsonrpc-4.17.2-84.git4c0ce12.el7.centos.noarch m vdsm-cli-4.17.2-84.git4c0ce12.el7.centos.noarch KENji> 10:57:39 fromani [~/rpmbuild/RPMS/x86_64]$ rpm -q --conflicts vdsm qemu-system-x86 vdsm-hook-sriov KENji> 10:57:44 fromani [~/rpmbuild/RPMS/x86_64]$ rpm -ivh qemu-common-1.6.1-2.fc20.x86_64.rpm qemu-system-x86-1.6.1-2.fc20.x86_64.rpm warning: qemu-common-1.6.1-2.fc20.x86_64.rpm: Header V3 RSA/SHA256 Signature, key ID 246110c1: NOKEY error: Failed dependencies: ceph-libs >= 0.61 is needed by qemu-common-2:1.6.1-2.fc20.x86_64 libfdt.so.1()(64bit) is needed by qemu-system-x86-2:1.6.1-2.fc20.x86_64 libfdt.so.1(LIBFDT_1.2)(64bit) is needed by qemu-system-x86-2:1.6.1-2.fc20.x86_64 libpng16.so.16()(64bit) is needed by qemu-system-x86-2:1.6.1-2.fc20.x86_64 libpng16.so.16(PNG16_0)(64bit) is needed by qemu-system-x86-2:1.6.1-2.fc20.x86_64 qemu-system-x86 conflicts with (installed) vdsm-4.17.2-84.git4c0ce12.el7.centos.noarch
will do sanity check before tick V+1
Francesco Romani has posted comments on this change.
Change subject: spec: conflict with plain QEMU ......................................................................
Patch Set 2: Verified+1
works on RHEL: HOji> 14:38:31 root [~]$ rpm -qa | grep -w vdsm vdsm-4.17.2-85.git3c8f4d8.el7.noarch vdsm-debuginfo-4.17.0-787.git66c48de.el7.x86_64 vdsm-python-zombiereaper-4.16.26-2.git6b2ac0a.el7.noarch vdsm-xmlrpc-4.17.2-85.git3c8f4d8.el7.noarch vdsm-jsonrpc-4.17.2-85.git3c8f4d8.el7.noarch vdsm-bootstrap-4.17.0-822.git9b11a18.el7.noarch vdsm-python-4.17.2-85.git3c8f4d8.el7.noarch vdsm-cli-4.17.2-85.git3c8f4d8.el7.noarch vdsm-yajsonrpc-4.17.2-85.git3c8f4d8.el7.noarch vdsm-infra-4.17.2-85.git3c8f4d8.el7.noarch HOji> 14:38:41 root [~]$ rpm -q --conflicts vdsm qemu-system-x86 vdsm-hook-sriov HOji> 14:38:56 root [~]$ rpm -qa | grep qemu qemu-kvm-tools-rhev-2.1.2-23.el7_1.8.x86_64 qemu-img-rhev-2.1.2-23.el7_1.8.x86_64 qemu-kvm-rhev-2.1.2-23.el7_1.8.x86_64 qemu-kvm-common-rhev-2.1.2-23.el7_1.8.x86_64 libvirt-daemon-driver-qemu-1.2.8-16.el7_1.3.x86_64 ipxe-roms-qemu-20130517-7.gitc4bce43.el7.noarch
V+1
Martin Polednik has posted comments on this change.
Change subject: spec: conflict with plain QEMU ......................................................................
Patch Set 2: Code-Review+1
automation@ovirt.org has posted comments on this change.
Change subject: spec: conflict with plain QEMU ......................................................................
Patch Set 3:
* Update tracker::IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a valid url. * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3'])
Dan Kenigsberg has posted comments on this change.
Change subject: spec: conflict with plain QEMU ......................................................................
Patch Set 3:
seems like a real test issue
08:33:29 Error: vdsm conflicts with 2:qemu-system-x86-2.3.0-5.fc21.x86_64
Francesco Romani has posted comments on this change.
Change subject: spec: conflict with plain QEMU ......................................................................
Patch Set 3: Code-Review-1
check why CI fails, apparently this is the patch which causes the failure.
automation@ovirt.org has posted comments on this change.
Change subject: spec: conflict with plain QEMU ......................................................................
Patch Set 4:
* Update tracker::IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a valid url. * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3'])
Francesco Romani has abandoned this change.
Change subject: spec: conflict with plain QEMU ......................................................................
Abandoned
two reasons to abandon - don't fix outside RH-based distros - breaks our CI
automation@ovirt.org has posted comments on this change.
Change subject: spec: conflict with plain QEMU ......................................................................
Patch Set 4:
* Update tracker::IGNORE, no Bug-Url found
vdsm-patches@lists.fedorahosted.org
-
automation＠ovirt.org -
Dan Kenigsberg -
fromani＠redhat.com -
Martin Polednik