Hello Antoni Segura Puimedon, Amador Pahim,
I'd like you to do a code review. Please visit
to review the following change.
Change subject: deployUtil: expect integer vlan id from new netinfo ......................................................................
deployUtil: expect integer vlan id from new netinfo
Commit 8b2bbe6e5 changed netinfo.getVlanID() to return the vlan id as an integer, istead of a string. This makes a lot of sense, but breaks compatibility with ancient deployUtil code.
Change-Id: Ibc1c5875e0d13b110f61f9eabf6d1964fc4c1237 Bug-Url: https://bugzilla.redhat.com/1037277 Signed-off-by: Dan Kenigsberg danken@redhat.com Reviewed-on: http://gerrit.ovirt.org/21948 Reviewed-by: Amador Pahim apahim@redhat.com Reviewed-by: Antoni Segura Puimedon asegurap@redhat.com --- M vdsm_reg/deployUtil.py.in 1 file changed, 1 insertion(+), 0 deletions(-)
git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/82/21982/1
diff --git a/vdsm_reg/deployUtil.py.in b/vdsm_reg/deployUtil.py.in index 2d379f6..ba45d64 100644 --- a/vdsm_reg/deployUtil.py.in +++ b/vdsm_reg/deployUtil.py.in @@ -1061,6 +1061,7 @@ else: vlan, bonding, nic = _getRHELBridgeParams(mgtIface, bridgeName=bridgeName) + vlan = str(vlan) fReturn = (nic is not None)
#Delete existing bridge in oVirt
Antoni Segura Puimedon has posted comments on this change.
Change subject: deployUtil: expect integer vlan id from new netinfo ......................................................................
Patch Set 1: Code-Review+1
Amador Pahim has posted comments on this change.
Change subject: deployUtil: expect integer vlan id from new netinfo ......................................................................
Patch Set 1: Code-Review+1
Douglas Schilling Landgraf has posted comments on this change.
Change subject: deployUtil: expect integer vlan id from new netinfo ......................................................................
Patch Set 1: Code-Review+1
Dan Kenigsberg has posted comments on this change.
Change subject: deployUtil: expect integer vlan id from new netinfo ......................................................................
Patch Set 1: Verified+1 Code-Review+2
Verified by author Vladimir Tananko
Yaniv Bronhaim has posted comments on this change.
Change subject: deployUtil: expect integer vlan id from new netinfo ......................................................................
Patch Set 2: Verified+1 Code-Review+2
Yaniv Bronhaim has submitted this change and it was merged.
Change subject: deployUtil: expect integer vlan id from new netinfo ......................................................................
deployUtil: expect integer vlan id from new netinfo
Commit 8b2bbe6e5 changed netinfo.getVlanID() to return the vlan id as an integer, istead of a string. This makes a lot of sense, but breaks compatibility with ancient deployUtil code.
Change-Id: Ibc1c5875e0d13b110f61f9eabf6d1964fc4c1237 Bug-Url: https://bugzilla.redhat.com/1037277 Signed-off-by: Dan Kenigsberg danken@redhat.com Reviewed-on: http://gerrit.ovirt.org/21948 Reviewed-by: Amador Pahim apahim@redhat.com Reviewed-by: Antoni Segura Puimedon asegurap@redhat.com Reviewed-on: http://gerrit.ovirt.org/21982 Reviewed-by: Yaniv Bronhaim ybronhei@redhat.com Tested-by: Yaniv Bronhaim ybronhei@redhat.com --- M vdsm_reg/deployUtil.py.in 1 file changed, 1 insertion(+), 0 deletions(-)
Approvals: Yaniv Bronhaim: Verified; Looks good to me, approved
vdsm-patches@lists.fedorahosted.org
-
apahim＠redhat.com -
asegurap＠redhat.com -
Dan Kenigsberg -
Douglas Schilling Landgraf -
ybronhei＠redhat.com