Nir Soffer has posted comments on this change.
Change subject: build: Cleanup conditionals in the build system
......................................................................
Patch Set 6:
(1 comment)
https://gerrit.ovirt.org/#/c/48446/6/vdsm.spec.in
File vdsm.spec.in:
Line 626: %if %{with_gluster_mgmt} == no
Line 627: --disable-gluster-mgmt \
Line 628: %endif
Line 629: %if %{rhev_build} == yes
Line 630: --enable-hooks \
we're building it --with-hooks anyway so no need to remove this
(I don't th
I know, but this it no the place for policy (how we build rhev), for
options (how to build according to the current configuration).
hooks are disabled by default currently - if we always build with hooks in any type of
build, we should enable it by default, like gluster.
Yaniv, what do you think?
Line 631: --enable-rhev \
Line 632: --with-smbios-manufacturer='Red Hat' \
Line 633: --with-smbios-osname='RHEV Hypervisor' \
Line 634: --with-qemu-kvm='qemu-kvm-rhev' \
--
To view, visit
https://gerrit.ovirt.org/48446
To unsubscribe, visit
https://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I9c94d206eb94ba51752423831ce4e01214a6a6d3
Gerrit-PatchSet: 6
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Nir Soffer <nsoffer(a)redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Barak Korren <bkorren(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Federico Simoncelli <fsimonce(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer <nsoffer(a)redhat.com>
Gerrit-Reviewer: Yaniv Bronhaim
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
Gerrit-HasComments: Yes