Change in vdsm[master]: Fix broken NFS.

List overview All Threads
Download

newer

older

Change in vdsm[master]: Probe cpu...

Change in vdsm[master]: BZ#829110...

ewarszaw＠redhat.com

6 Feb 2013 6 Feb '13

4:51 a.m.

Eduardo has uploaded a new change for review.

Change subject: Fix broken NFS. ......................................................................

Fix broken NFS.

self.sdUUID does not exist when self.validateFileSystemFeatures is called.

Broken by Icf14d1c4737.

Change-Id: Iabe379eb1c422ee21de0be2d21d9dea009d550ec Signed-off-by: Eduardo ewarszaw@redhat.com --- M vdsm/storage/fileSD.py 1 file changed, 2 insertions(+), 2 deletions(-)

git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/02/11802/1

diff --git a/vdsm/storage/fileSD.py b/vdsm/storage/fileSD.py index 242ec1e..141906e 100644 --- a/vdsm/storage/fileSD.py +++ b/vdsm/storage/fileSD.py @@ -153,10 +153,10 @@ self.metafile = os.path.join(domainPath, sd.DOMAIN_META_DATA, sd.METADATA)

- self.validateFileSystemFeatures() + sdUUID = os.path.basename(domainPath) + validateFileSystemFeatures(sdUUID, self.mountpoint)

metadata = FileSDMetadata(self.metafile) - sdUUID = metadata[sd.DMDK_SDUUID] domaindir = os.path.join(self.mountpoint, sdUUID) sd.StorageDomain.__init__(self, sdUUID, domaindir, metadata)

-- To view, visit http://gerrit.ovirt.org/11802 To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: newchange Gerrit-Change-Id: Iabe379eb1c422ee21de0be2d21d9dea009d550ec Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Eduardo ewarszaw@redhat.com

Show replies by date

Jenkins CI RO

6 Feb 6 Feb

4:51 a.m.

oVirt Jenkins CI Server has posted comments on this change.

Change subject: Fix broken NFS. ......................................................................

Patch Set 1:

Build Started http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/305/ (1/3)

-- To view, visit http://gerrit.ovirt.org/11802 To unsubscribe, visit http://gerrit.ovirt.org/settings

Jenkins CI RO

4:51 a.m.

oVirt Jenkins CI Server has posted comments on this change.

Change subject: Fix broken NFS. ......................................................................

Patch Set 1:

Build Started http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/1159/ (2/3)

-- To view, visit http://gerrit.ovirt.org/11802 To unsubscribe, visit http://gerrit.ovirt.org/settings

Jenkins CI RO

4:51 a.m.

oVirt Jenkins CI Server has posted comments on this change.

Change subject: Fix broken NFS. ......................................................................

Patch Set 1:

Build Started http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/1194/ (3/3)

-- To view, visit http://gerrit.ovirt.org/11802 To unsubscribe, visit http://gerrit.ovirt.org/settings

Jenkins CI RO

4:53 a.m.

oVirt Jenkins CI Server has posted comments on this change.

Change subject: Fix broken NFS. ......................................................................

Patch Set 1:

Build Successful

http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/1159/ : SUCCESS

http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/1194/ : SUCCESS

http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/305/ : SUCCESS

-- To view, visit http://gerrit.ovirt.org/11802 To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment Gerrit-Change-Id: Iabe379eb1c422ee21de0be2d21d9dea009d550ec Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Eduardo ewarszaw@redhat.com Gerrit-Reviewer: Ayal Baron abaron@redhat.com Gerrit-Reviewer: Dan Kenigsberg danken@redhat.com Gerrit-Reviewer: Yaniv Bronhaim ybronhei@redhat.com Gerrit-Reviewer: Yeela Kaplan ykaplan@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server

ykaplan＠redhat.com

6:09 a.m.

Yeela Kaplan has posted comments on this change.

Change subject: Fix broken NFS. ......................................................................

Patch Set 1: I would prefer that you didn't submit this

(1 inline comment)

.................................................... File vdsm/storage/fileSD.py Line 165: self.imageGarbageCollector() Line 166: self._registerResourceNamespaces() Line 167: Line 168: def validateFileSystemFeatures(self): Line 169: validateFileSystemFeatures(self.sdUUID, self.mountpoint) Since you have removed the only use of this function I would remove it. Line 170: Line 171: def setMetadataPermissions(self): Line 172: procPool = oop.getProcessPool(self.sdUUID) Line 173: for metaFile in (sd.LEASES, sd.IDS, sd.INBOX, sd.OUTBOX):

-- To view, visit http://gerrit.ovirt.org/11802 To unsubscribe, visit http://gerrit.ovirt.org/settings

ykaplan＠redhat.com

6:33 a.m.

Yeela Kaplan has posted comments on this change.

Change subject: Fix broken NFS. ......................................................................

Patch Set 1: (1 inline comment)

.................................................... Commit Message Line 3: AuthorDate: 2013-02-06 16:47:44 +0200 Line 4: Commit: Eduardo Warszawski ewarszaw@redhat.com Line 5: CommitDate: 2013-02-06 16:47:44 +0200 Line 6: Line 7: Fix broken NFS. Extract sdUUID explicitly from domain path Line 8: Line 9: self.sdUUID does not exist when self.validateFileSystemFeatures Line 10: is called. Line 11:

-- To view, visit http://gerrit.ovirt.org/11802 To unsubscribe, visit http://gerrit.ovirt.org/settings

Jenkins CI RO

6:35 a.m.

oVirt Jenkins CI Server has posted comments on this change.

Change subject: Fix broken NFS. ......................................................................

Patch Set 2:

Build Started http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/1165/ (2/3)

-- To view, visit http://gerrit.ovirt.org/11802 To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment Gerrit-Change-Id: Iabe379eb1c422ee21de0be2d21d9dea009d550ec Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Eduardo ewarszaw@redhat.com Gerrit-Reviewer: Ayal Baron abaron@redhat.com Gerrit-Reviewer: Dan Kenigsberg danken@redhat.com Gerrit-Reviewer: Eduardo ewarszaw@redhat.com Gerrit-Reviewer: Yaniv Bronhaim ybronhei@redhat.com Gerrit-Reviewer: Yeela Kaplan ykaplan@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server

Jenkins CI RO

6:35 a.m.

oVirt Jenkins CI Server has posted comments on this change.

Change subject: Fix broken NFS. ......................................................................

Patch Set 2:

Build Started http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/311/ (1/3)

-- To view, visit http://gerrit.ovirt.org/11802 To unsubscribe, visit http://gerrit.ovirt.org/settings

Jenkins CI RO

6:35 a.m.

oVirt Jenkins CI Server has posted comments on this change.

Change subject: Fix broken NFS. ......................................................................

Patch Set 2:

Build Started http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/1200/ (3/3)

-- To view, visit http://gerrit.ovirt.org/11802 To unsubscribe, visit http://gerrit.ovirt.org/settings

Jenkins CI RO

6:37 a.m.

oVirt Jenkins CI Server has posted comments on this change.

Change subject: Fix broken NFS. ......................................................................

Patch Set 2:

Build Successful

http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/1165/ : SUCCESS

http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/1200/ : SUCCESS

http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/311/ : SUCCESS

-- To view, visit http://gerrit.ovirt.org/11802 To unsubscribe, visit http://gerrit.ovirt.org/settings

ybronhei＠redhat.com

7:06 a.m.

Yaniv Bronhaim has posted comments on this change.

Change subject: Fix broken NFS. ......................................................................

Patch Set 2: Verified

works over fedora.

-- To view, visit http://gerrit.ovirt.org/11802 To unsubscribe, visit http://gerrit.ovirt.org/settings

smizrahi＠redhat.com

9:13 a.m.

Saggi Mizrahi has posted comments on this change.

Change subject: Fix broken NFS. ......................................................................

Patch Set 2: Looks good to me, but someone else must approve

-- To view, visit http://gerrit.ovirt.org/11802 To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment Gerrit-Change-Id: Iabe379eb1c422ee21de0be2d21d9dea009d550ec Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Eduardo ewarszaw@redhat.com Gerrit-Reviewer: Ayal Baron abaron@redhat.com Gerrit-Reviewer: Dan Kenigsberg danken@redhat.com Gerrit-Reviewer: Eduardo ewarszaw@redhat.com Gerrit-Reviewer: Saggi Mizrahi smizrahi@redhat.com Gerrit-Reviewer: Yaniv Bronhaim ybronhei@redhat.com Gerrit-Reviewer: Yeela Kaplan ykaplan@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server

Dan Kenigsberg

12:32 p.m.

Dan Kenigsberg has posted comments on this change.

Change subject: Fix broken NFS. ......................................................................

Patch Set 2: Looks good to me, approved

Thanks, Eduardo, for quickly unbreaking master.

-- To view, visit http://gerrit.ovirt.org/11802 To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment Gerrit-Change-Id: Iabe379eb1c422ee21de0be2d21d9dea009d550ec Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Eduardo ewarszaw@redhat.com Gerrit-Reviewer: Ayal Baron abaron@redhat.com Gerrit-Reviewer: Dan Kenigsberg danken@redhat.com Gerrit-Reviewer: Eduardo ewarszaw@redhat.com Gerrit-Reviewer: Saggi Mizrahi smizrahi@redhat.com Gerrit-Reviewer: Yaniv Bronhaim ybronhei@redhat.com Gerrit-Reviewer: Yeela Kaplan ykaplan@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server

Dan Kenigsberg

12:32 p.m.

Dan Kenigsberg has submitted this change and it was merged.

Change subject: Fix broken NFS. ......................................................................

Fix broken NFS.

self.sdUUID does not exist when self.validateFileSystemFeatures is called.

Broken by Icf14d1c4737.

Change-Id: Iabe379eb1c422ee21de0be2d21d9dea009d550ec Signed-off-by: Eduardo ewarszaw@redhat.com --- M vdsm/storage/fileSD.py 1 file changed, 2 insertions(+), 5 deletions(-)

Approvals: Yaniv Bronhaim: Verified Saggi Mizrahi: Looks good to me, but someone else must approve Dan Kenigsberg: Looks good to me, approved

-- To view, visit http://gerrit.ovirt.org/11802 To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: merged Gerrit-Change-Id: Iabe379eb1c422ee21de0be2d21d9dea009d550ec Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Eduardo ewarszaw@redhat.com Gerrit-Reviewer: Ayal Baron abaron@redhat.com Gerrit-Reviewer: Dan Kenigsberg danken@redhat.com Gerrit-Reviewer: Eduardo ewarszaw@redhat.com Gerrit-Reviewer: Saggi Mizrahi smizrahi@redhat.com Gerrit-Reviewer: Yaniv Bronhaim ybronhei@redhat.com Gerrit-Reviewer: Yeela Kaplan ykaplan@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server

4162

Age (days ago)

4162

Last active (days ago)

vdsm-patches@lists.fedorahosted.org

14 comments

6 participants

tags (0)

participants (6)

Dan Kenigsberg
ewarszaw＠redhat.com
Jenkins CI RO
smizrahi＠redhat.com
ybronhei＠redhat.com
ykaplan＠redhat.com