Change in vdsm[master]: Specify the ACPI flag when shutting down VMs

List overview All Threads
Download

newer

older

Change in vdsm[master]: vm:...

Change in vdsm[master]: pep8:...

Federico Simoncelli

8 Aug 2012 8 Aug '12

10:08 a.m.

Federico Simoncelli has uploaded a new change for review.

Change subject: Specify the ACPI flag when shutting down VMs ......................................................................

Specify the ACPI flag when shutting down VMs

In commit e460308 has been introduced the qemu guest agent support. When such agent channel is present the default shutdown method uses the guest agent (which might be missing). For consistency and to maintain the old behavior we should specify to use ACPI to shutdown the guest.

Signed-off-by: Federico Simoncelli fsimonce@redhat.com Change-Id: I6ca628ce6f4a5c7f6a937a14b12a5078b32e89dd --- M vdsm/libvirtvm.py 1 file changed, 1 insertion(+), 1 deletion(-)

git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/96/6996/1 -- To view, visit http://gerrit.ovirt.org/6996 To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: newchange Gerrit-Change-Id: I6ca628ce6f4a5c7f6a937a14b12a5078b32e89dd Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Federico Simoncelli fsimonce@redhat.com

Show replies by date

Jenkins CI RO

8 Aug 8 Aug

4:29 p.m.

oVirt Jenkins CI Server has posted comments on this change.

Change subject: Specify the ACPI flag when shutting down VMs ......................................................................

Patch Set 1: No score

Build Started http://jenkins.ovirt.info/job/vdsm_unit_tests_by_patch/1/

-- To view, visit http://gerrit.ovirt.org/6996 To unsubscribe, visit http://gerrit.ovirt.org/settings

Jenkins CI RO

4:32 p.m.

oVirt Jenkins CI Server has posted comments on this change.

Change subject: Specify the ACPI flag when shutting down VMs ......................................................................

Patch Set 1:

Build Successful

http://jenkins.ovirt.info/job/vdsm_unit_tests_by_patch/1/ : SUCCESS

-- To view, visit http://gerrit.ovirt.org/6996 To unsubscribe, visit http://gerrit.ovirt.org/settings

Jenkins CI RO

4:40 p.m.

oVirt Jenkins CI Server has posted comments on this change.

Change subject: Specify the ACPI flag when shutting down VMs ......................................................................

Patch Set 1:

Build Started http://jenkins.ovirt.info/job/vdsm_unit_tests_by_patch/2/

-- To view, visit http://gerrit.ovirt.org/6996 To unsubscribe, visit http://gerrit.ovirt.org/settings

Jenkins CI RO

4:42 p.m.

oVirt Jenkins CI Server has posted comments on this change.

Change subject: Specify the ACPI flag when shutting down VMs ......................................................................

Patch Set 1:

Build Successful

http://jenkins.ovirt.info/job/vdsm_unit_tests_by_patch/2/ : SUCCESS

-- To view, visit http://gerrit.ovirt.org/6996 To unsubscribe, visit http://gerrit.ovirt.org/settings

Jenkins CI RO

5:23 p.m.

oVirt Jenkins CI Server has posted comments on this change.

Change subject: Specify the ACPI flag when shutting down VMs ......................................................................

Patch Set 1:

Build Started http://jenkins.ovirt.info/job/vdsm_unit_tests_by_patch/3/

-- To view, visit http://gerrit.ovirt.org/6996 To unsubscribe, visit http://gerrit.ovirt.org/settings

Jenkins CI RO

5:25 p.m.

oVirt Jenkins CI Server has posted comments on this change.

Change subject: Specify the ACPI flag when shutting down VMs ......................................................................

Patch Set 1:

Build Successful

http://jenkins.ovirt.info/job/vdsm_unit_tests_by_patch/3/ : SUCCESS

-- To view, visit http://gerrit.ovirt.org/6996 To unsubscribe, visit http://gerrit.ovirt.org/settings

Jenkins CI RO

5:26 p.m.

oVirt Jenkins CI Server has posted comments on this change.

Change subject: Specify the ACPI flag when shutting down VMs ......................................................................

Patch Set 1:

Build Started http://jenkins.ovirt.info/job/vdsm_unit_tests_by_patch/4/

-- To view, visit http://gerrit.ovirt.org/6996 To unsubscribe, visit http://gerrit.ovirt.org/settings

Jenkins CI RO

5:28 p.m.

oVirt Jenkins CI Server has posted comments on this change.

Change subject: Specify the ACPI flag when shutting down VMs ......................................................................

Patch Set 1:

Build Successful

http://jenkins.ovirt.info/job/vdsm_unit_tests_by_patch/4/ : SUCCESS

-- To view, visit http://gerrit.ovirt.org/6996 To unsubscribe, visit http://gerrit.ovirt.org/settings

Jenkins CI RO

5:36 p.m.

oVirt Jenkins CI Server has posted comments on this change.

Change subject: Specify the ACPI flag when shutting down VMs ......................................................................

Patch Set 1:

Build Started http://jenkins.ovirt.info/job/vdsm_unit_tests_by_patch/5/

-- To view, visit http://gerrit.ovirt.org/6996 To unsubscribe, visit http://gerrit.ovirt.org/settings

Jenkins CI RO

5:36 p.m.

oVirt Jenkins CI Server has posted comments on this change.

Change subject: Specify the ACPI flag when shutting down VMs ......................................................................

Patch Set 1: Fails

Build Failed

http://jenkins.ovirt.info/job/vdsm_unit_tests_by_patch/5/ : FAILURE

-- To view, visit http://gerrit.ovirt.org/6996 To unsubscribe, visit http://gerrit.ovirt.org/settings

Jenkins CI RO

5:38 p.m.

oVirt Jenkins CI Server has posted comments on this change.

Change subject: Specify the ACPI flag when shutting down VMs ......................................................................

Patch Set 1: No score

Build Started http://jenkins.ovirt.info/job/vdsm_unit_tests_by_patch/16/

-- To view, visit http://gerrit.ovirt.org/6996 To unsubscribe, visit http://gerrit.ovirt.org/settings

Jenkins CI RO

5:38 p.m.

oVirt Jenkins CI Server has posted comments on this change.

Change subject: Specify the ACPI flag when shutting down VMs ......................................................................

Patch Set 1: Fails

Build Failed

http://jenkins.ovirt.info/job/vdsm_unit_tests_by_patch/16/ : FAILURE

-- To view, visit http://gerrit.ovirt.org/6996 To unsubscribe, visit http://gerrit.ovirt.org/settings

Jenkins CI RO

5:43 p.m.

oVirt Jenkins CI Server has posted comments on this change.

Change subject: Specify the ACPI flag when shutting down VMs ......................................................................

Patch Set 1: No score

Build Started http://jenkins.ovirt.info/job/vdsm_unit_tests_by_patch/17/

-- To view, visit http://gerrit.ovirt.org/6996 To unsubscribe, visit http://gerrit.ovirt.org/settings

Jenkins CI RO

5:43 p.m.

oVirt Jenkins CI Server has posted comments on this change.

Change subject: Specify the ACPI flag when shutting down VMs ......................................................................

Patch Set 1: Fails

Build Failed

http://jenkins.ovirt.info/job/vdsm_unit_tests_by_patch/17/ : FAILURE

-- To view, visit http://gerrit.ovirt.org/6996 To unsubscribe, visit http://gerrit.ovirt.org/settings

Jenkins CI RO

5:45 p.m.

oVirt Jenkins CI Server has posted comments on this change.

Change subject: Specify the ACPI flag when shutting down VMs ......................................................................

Patch Set 1: No score

Build Started http://jenkins.ovirt.info/job/vdsm_unit_tests_by_patch/18/

-- To view, visit http://gerrit.ovirt.org/6996 To unsubscribe, visit http://gerrit.ovirt.org/settings

Jenkins CI RO

5:46 p.m.

oVirt Jenkins CI Server has posted comments on this change.

Change subject: Specify the ACPI flag when shutting down VMs ......................................................................

Patch Set 1:

Build Successful

http://jenkins.ovirt.info/job/vdsm_unit_tests_by_patch/18/ : SUCCESS

-- To view, visit http://gerrit.ovirt.org/6996 To unsubscribe, visit http://gerrit.ovirt.org/settings

Jenkins CI RO

6:26 p.m.

oVirt Jenkins CI Server has posted comments on this change.

Change subject: Specify the ACPI flag when shutting down VMs ......................................................................

Patch Set 1:

Build Started http://jenkins.ovirt.info/job/vdsm_unit_tests_by_patch/28/

-- To view, visit http://gerrit.ovirt.org/6996 To unsubscribe, visit http://gerrit.ovirt.org/settings

Jenkins CI RO

6:28 p.m.

oVirt Jenkins CI Server has posted comments on this change.

Change subject: Specify the ACPI flag when shutting down VMs ......................................................................

Patch Set 1:

Build Successful

http://jenkins.ovirt.info/job/vdsm_unit_tests_by_patch/28/ : SUCCESS

-- To view, visit http://gerrit.ovirt.org/6996 To unsubscribe, visit http://gerrit.ovirt.org/settings

Jenkins CI RO

6:33 p.m.

oVirt Jenkins CI Server has posted comments on this change.

Change subject: Specify the ACPI flag when shutting down VMs ......................................................................

Patch Set 1:

Build Started http://jenkins.ovirt.info/job/vdsm_unit_tests_by_patch/29/

-- To view, visit http://gerrit.ovirt.org/6996 To unsubscribe, visit http://gerrit.ovirt.org/settings

Jenkins CI RO

6:35 p.m.

oVirt Jenkins CI Server has posted comments on this change.

Change subject: Specify the ACPI flag when shutting down VMs ......................................................................

Patch Set 1:

Build Successful

http://jenkins.ovirt.info/job/vdsm_unit_tests_by_patch/29/ : SUCCESS

-- To view, visit http://gerrit.ovirt.org/6996 To unsubscribe, visit http://gerrit.ovirt.org/settings

Dan Kenigsberg

9 Aug 9 Aug

8:53 p.m.

Dan Kenigsberg has posted comments on this change.

Change subject: Specify the ACPI flag when shutting down VMs ......................................................................

Patch Set 1: Looks good to me, but someone else must approve

(1 inline comment)

.................................................... File vdsm/libvirtvm.py Line 2000: def _acpiShutdown(self): agreed. a function named like that should keep using acpi.

however, it does not strike me as horrible to use guest agent when it is available. Why is it a problem for anyone?

-- To view, visit http://gerrit.ovirt.org/6996 To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment Gerrit-Change-Id: I6ca628ce6f4a5c7f6a937a14b12a5078b32e89dd Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Federico Simoncelli fsimonce@redhat.com Gerrit-Reviewer: Bing Bu Cao mars@linux.vnet.ibm.com Gerrit-Reviewer: Dan Kenigsberg danken@redhat.com Gerrit-Reviewer: Gal Hammer ghammer@redhat.com Gerrit-Reviewer: Michal Skrivanek michal.skrivanek@redhat.com Gerrit-Reviewer: Royce Lv lvroyce@linux.vnet.ibm.com Gerrit-Reviewer: oVirt Jenkins CI Server

Federico Simoncelli

11:17 p.m.

Federico Simoncelli has posted comments on this change.

Change subject: Specify the ACPI flag when shutting down VMs ......................................................................

Patch Set 1: (1 inline comment)

.................................................... File vdsm/libvirtvm.py Line 2000: def _acpiShutdown(self): The problem is that you need to remember to install the guest agent (currently in all the VMs) and if it's missing (not started or crashed) the command is going to fail (and the VM won't shutdown). Do you know why it is preferable to use the guest agent when it's available?

-- To view, visit http://gerrit.ovirt.org/6996 To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment Gerrit-Change-Id: I6ca628ce6f4a5c7f6a937a14b12a5078b32e89dd Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Federico Simoncelli fsimonce@redhat.com Gerrit-Reviewer: Bing Bu Cao mars@linux.vnet.ibm.com Gerrit-Reviewer: Dan Kenigsberg danken@redhat.com Gerrit-Reviewer: Federico Simoncelli fsimonce@redhat.com Gerrit-Reviewer: Gal Hammer ghammer@redhat.com Gerrit-Reviewer: Michal Skrivanek michal.skrivanek@redhat.com Gerrit-Reviewer: Royce Lv lvroyce@linux.vnet.ibm.com Gerrit-Reviewer: oVirt Jenkins CI Server

lvroyce＠linux.vnet.ibm.com

12 Aug 12 Aug

4:25 a.m.

Royce Lv has posted comments on this change.

Change subject: Specify the ACPI flag when shutting down VMs ......................................................................

Patch Set 1: Looks good to me, but someone else must approve

-- To view, visit http://gerrit.ovirt.org/6996 To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment Gerrit-Change-Id: I6ca628ce6f4a5c7f6a937a14b12a5078b32e89dd Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Federico Simoncelli fsimonce@redhat.com Gerrit-Reviewer: Bing Bu Cao mars@linux.vnet.ibm.com Gerrit-Reviewer: Dan Kenigsberg danken@redhat.com Gerrit-Reviewer: Federico Simoncelli fsimonce@redhat.com Gerrit-Reviewer: Gal Hammer ghammer@redhat.com Gerrit-Reviewer: Michal Skrivanek michal.skrivanek@redhat.com Gerrit-Reviewer: Royce Lv lvroyce@linux.vnet.ibm.com Gerrit-Reviewer: oVirt Jenkins CI Server

Dan Kenigsberg

13 Aug 13 Aug

12:16 p.m.

Dan Kenigsberg has posted comments on this change.

Change subject: Specify the ACPI flag when shutting down VMs ......................................................................

Patch Set 1: Looks good to me, approved

-- To view, visit http://gerrit.ovirt.org/6996 To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment Gerrit-Change-Id: I6ca628ce6f4a5c7f6a937a14b12a5078b32e89dd Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Federico Simoncelli fsimonce@redhat.com Gerrit-Reviewer: Bing Bu Cao mars@linux.vnet.ibm.com Gerrit-Reviewer: Dan Kenigsberg danken@redhat.com Gerrit-Reviewer: Federico Simoncelli fsimonce@redhat.com Gerrit-Reviewer: Gal Hammer ghammer@redhat.com Gerrit-Reviewer: Leonid Natapov leonidnatapov@gmail.com Gerrit-Reviewer: Michal Skrivanek michal.skrivanek@redhat.com Gerrit-Reviewer: Royce Lv lvroyce@linux.vnet.ibm.com Gerrit-Reviewer: oVirt Jenkins CI Server

Dan Kenigsberg

12:16 p.m.

Dan Kenigsberg has submitted this change and it was merged.

Change subject: Specify the ACPI flag when shutting down VMs ......................................................................

Specify the ACPI flag when shutting down VMs

Signed-off-by: Federico Simoncelli fsimonce@redhat.com Change-Id: I6ca628ce6f4a5c7f6a937a14b12a5078b32e89dd --- M vdsm/libvirtvm.py 1 file changed, 1 insertion(+), 1 deletion(-)

Approvals: Royce Lv: Looks good to me, but someone else must approve Leonid Natapov: Verified Dan Kenigsberg: Looks good to me, approved

-- To view, visit http://gerrit.ovirt.org/6996 To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: merged Gerrit-Change-Id: I6ca628ce6f4a5c7f6a937a14b12a5078b32e89dd Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Federico Simoncelli fsimonce@redhat.com Gerrit-Reviewer: Bing Bu Cao mars@linux.vnet.ibm.com Gerrit-Reviewer: Dan Kenigsberg danken@redhat.com Gerrit-Reviewer: Federico Simoncelli fsimonce@redhat.com Gerrit-Reviewer: Gal Hammer ghammer@redhat.com Gerrit-Reviewer: Leonid Natapov leonidnatapov@gmail.com Gerrit-Reviewer: Michal Skrivanek michal.skrivanek@redhat.com Gerrit-Reviewer: Royce Lv lvroyce@linux.vnet.ibm.com Gerrit-Reviewer: oVirt Jenkins CI Server

Dan Kenigsberg

5 Dec 5 Dec

1:27 p.m.

Dan Kenigsberg has posted comments on this change.

Change subject: Specify the ACPI flag when shutting down VMs ......................................................................

Patch Set 1: (1 inline comment)

.................................................... File vdsm/libvirtvm.py Line 1996: blockDevAlias, d.domainID, d.volumeID, err, Line 1997: physical, alloc) Line 1998: self._lvExtend(d.name) Line 1999: Line 2000: def _acpiShutdown(self): I have a feeling that preferring guest-agent shutdown is a remnant from the days where we had guests that did not support acpi. Now they are very rare, and the guest-agent can do its shutting-down stuff when it senses ACPI_POWER_BTN pressed. Line 2001: self._dom.shutdownFlags(libvirt.VIR_DOMAIN_SHUTDOWN_ACPI_POWER_BTN) Line 2002: Line 2003: def _getPid(self): Line 2004: pid = '0'

-- To view, visit http://gerrit.ovirt.org/6996 To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment Gerrit-Change-Id: I6ca628ce6f4a5c7f6a937a14b12a5078b32e89dd Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Federico Simoncelli fsimonce@redhat.com Gerrit-Reviewer: Bing Bu Cao mars@linux.vnet.ibm.com Gerrit-Reviewer: Dan Kenigsberg danken@redhat.com Gerrit-Reviewer: Federico Simoncelli fsimonce@redhat.com Gerrit-Reviewer: Gal Hammer ghammer@redhat.com Gerrit-Reviewer: Leonid Natapov leonidnatapov@gmail.com Gerrit-Reviewer: Michal Skrivanek michal.skrivanek@redhat.com Gerrit-Reviewer: Royce Lv lvroyce@linux.vnet.ibm.com Gerrit-Reviewer: oVirt Jenkins CI Server

4227

Age (days ago)

4346

Last active (days ago)

vdsm-patches@lists.fedorahosted.org

26 comments

4 participants

tags (0)

participants (4)

Dan Kenigsberg
Federico Simoncelli
Jenkins CI RO
lvroyce＠linux.vnet.ibm.com