9:39 a.m.
Yaniv Bronhaim has uploaded a new change for review.
Change subject: getServices returns wrong order for depended services for libvirt module
......................................................................
getServices returns wrong order for depended services for libvirt module
Configure verb runs over getServices returned list and stop those
services, configure vdsm, and start them in reverse order. In this patch
I fix current order which starts vdsm before supervdsmd service
Change-Id: If8aba9ebdacc16e3af8153fb44360d3c4537e362
Signed-off-by: Yaniv Bronhaim <ybronhei(a)redhat.com>
---
M lib/vdsm/tool/configurator.py
1 file changed, 1 insertion(+), 1 deletion(-)
git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/18/28818/1
diff --git a/lib/vdsm/tool/configurator.py b/lib/vdsm/tool/configurator.py
index c8373fb..da05931 100644
--- a/lib/vdsm/tool/configurator.py
+++ b/lib/vdsm/tool/configurator.py
@@ -101,7 +101,7 @@
return self.FILES[fname]['path']
def getServices(self):
- return ["supervdsmd", "vdsmd", "libvirtd"]
+ return ["vdsmd", "supervdsmd", "libvirtd"]
def configure(self):
if os.getuid() != 0:
--
To view, visit http://gerrit.ovirt.org/28818
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: If8aba9ebdacc16e3af8153fb44360d3c4537e362
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Yaniv Bronhaim <ybronhei(a)redhat.com>
10:01 a.m.
Antoni Segura Puimedon has posted comments on this change.
Change subject: getServices returns wrong order for depended services for libvirt module
......................................................................
Patch Set 1: Code-Review+1
--
To view, visit http://gerrit.ovirt.org/28818
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: If8aba9ebdacc16e3af8153fb44360d3c4537e362
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Yaniv Bronhaim <ybronhei(a)redhat.com>
Gerrit-Reviewer: Antoni Segura Puimedon <asegurap(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: mooli tayer <mtayer(a)redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: No
10:14 a.m.
oVirt Jenkins CI Server has posted comments on this change.
Change subject: getServices returns wrong order for depended services for libvirt module
......................................................................
Patch Set 2:
Build Successful
http://jenkins.ovirt.org/job/vdsm_master_create-rpms_merged/1485/ : SUCCESS
--
To view, visit http://gerrit.ovirt.org/28818
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: If8aba9ebdacc16e3af8153fb44360d3c4537e362
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Yaniv Bronhaim <ybronhei(a)redhat.com>
Gerrit-Reviewer: Antoni Segura Puimedon <asegurap(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: mooli tayer <mtayer(a)redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: No
10:11 a.m.
Dan Kenigsberg has submitted this change and it was merged.
Change subject: getServices returns wrong order for depended services for libvirt module
......................................................................
getServices returns wrong order for depended services for libvirt module
Configure verb runs over getServices returned list and stop those
services, configure vdsm, and start them in reverse order. In this patch
I fix current order which starts vdsm before supervdsmd service
Change-Id: If8aba9ebdacc16e3af8153fb44360d3c4537e362
Signed-off-by: Yaniv Bronhaim <ybronhei(a)redhat.com>
Reviewed-on: http://gerrit.ovirt.org/28818
Reviewed-by: Antoni Segura Puimedon <asegurap(a)redhat.com>
Reviewed-by: mooli tayer <mtayer(a)redhat.com>
Reviewed-by: Dan Kenigsberg <danken(a)redhat.com>
---
M lib/vdsm/tool/configurator.py
1 file changed, 1 insertion(+), 1 deletion(-)
Approvals:
Yaniv Bronhaim: Verified
Antoni Segura Puimedon: Looks good to me, but someone else must approve
mooli tayer: Looks good to me, but someone else must approve
Dan Kenigsberg: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/28818
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: If8aba9ebdacc16e3af8153fb44360d3c4537e362
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Yaniv Bronhaim <ybronhei(a)redhat.com>
Gerrit-Reviewer: Antoni Segura Puimedon <asegurap(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: mooli tayer <mtayer(a)redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
10:11 a.m.
Dan Kenigsberg has posted comments on this change.
Change subject: getServices returns wrong order for depended services for libvirt module
......................................................................
Patch Set 1: Code-Review+2
Raising score
--
To view, visit http://gerrit.ovirt.org/28818
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: If8aba9ebdacc16e3af8153fb44360d3c4537e362
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Yaniv Bronhaim <ybronhei(a)redhat.com>
Gerrit-Reviewer: Antoni Segura Puimedon <asegurap(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: mooli tayer <mtayer(a)redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: No
10:07 a.m.
mooli tayer has posted comments on this change.
Change subject: getServices returns wrong order for depended services for libvirt module
......................................................................
Patch Set 1: Code-Review+1
--
To view, visit http://gerrit.ovirt.org/28818
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: If8aba9ebdacc16e3af8153fb44360d3c4537e362
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Yaniv Bronhaim <ybronhei(a)redhat.com>
Gerrit-Reviewer: Antoni Segura Puimedon <asegurap(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: mooli tayer <mtayer(a)redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: No
9:46 a.m.
oVirt Jenkins CI Server has posted comments on this change.
Change subject: getServices returns wrong order for depended services for libvirt module
......................................................................
Patch Set 1:
Build Failed
http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit_el/9327/ : SUCCESS
http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/10111/ : SUCCESS
http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit/10267/ : SUCCESS
http://jenkins.ovirt.org/job/vdsm_master_verify-error-codes_merged/5193/ : FAILURE
http://jenkins.ovirt.org/job/vdsm_master_unit-tests_merged/3351/ : SUCCESS
--
To view, visit http://gerrit.ovirt.org/28818
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: If8aba9ebdacc16e3af8153fb44360d3c4537e362
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Yaniv Bronhaim <ybronhei(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: mooli tayer <mtayer(a)redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: No
9:40 a.m.
Yaniv Bronhaim has posted comments on this change.
Change subject: getServices returns wrong order for depended services for libvirt module
......................................................................
Patch Set 1: Verified+1
--
To view, visit http://gerrit.ovirt.org/28818
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: If8aba9ebdacc16e3af8153fb44360d3c4537e362
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Yaniv Bronhaim <ybronhei(a)redhat.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-HasComments: No
3641
days inactive
3643
days old
vdsm-patches@lists.fedorahosted.org
7 comments
5 participants
participants (5)
-
asegurap＠redhat.com -
Dan Kenigsberg -
Jenkins CI RO -
mtayer＠redhat.com -
ybronhei＠redhat.com