On Tue, 2010-03-16 at 09:38 -0400, James Laska wrote:
On Tue, 2010-03-16 at 08:14 -0400, Kamil Paral wrote:
But shouldn't we just place this file into /etc ? I can see for example this structure:
/etc/cron.d/autoqa /etc/autoqa/autoqa.conf /etc/autoqa/repoinfo.conf
/etc/autoqa/tests/rats_sanity/irb.cfg
Nice, I like that structure better for test specific configs.
Are any changes in the irb tests (rats_*) needed to change to accommodate moving the config around? I think Will played around with this a while back.
This will break rats_*/irb; see below.
The reason irb.cfg exists inside the test directory is due to the nature in which autotest rsync's content to the test clients.
Correct. irb.cfg needs to be available on the test client machines, because the test is reading the config data (including the username/password for the autoqa account in FAS) from that file.
The problem with putting that data into the systemwide config is that the data in the systemwide config gets passed into the tests and shows up *in plain text* in the test logs.
Obviously we can't have the autoqa password show up in the test logs, so we need to keep it in a file that gets copied onto the test client.
Since the test directory gets copied onto the test client, the simplest thing is to keep the config in the test directory.
If anyone has a better idea for how to pass files from the autotest server to the test client *without* it showing up in plaintext in the test logs/results, I'd love to hear about that - we could use that to copy /etc/autoqa/irb.conf (etc) onto the clients.
Otherwise irb.conf needs to stay where it is.
-w