Re: Review Request 3: Initial Support for FAS Authentication
by Martin Krizek
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard-tflink.rhcloud.com/r/3/
-----------------------------------------------------------
(Updated Feb. 12, 2013, 10:22 p.m.)
Review request for blockerbugs.
Changes
-------
trying to trigger email notification of available review
Summary (updated)
-----------------
Initial Support for FAS Authentication
Bugs: 335
https://fedorahosted.org/fedora-qa/ticket/335
Repository: blockerbugs
Description
-------
Initial support for logins using FAS for authentication.
* The admin pages have been changed to check for membership in the FAS group 'qa-admin' instead of internal auth
* auth is against admin.stg.fedoraproject.org instead of production FAS for DEV mode
* apache configuration is changed to force SSL (mod_rewrite for now)
Diffs
-----
runapp.py 34c5be0538baafa41b56f0f3d1105300c30a9956
requirements.txt 2728e4ac49a98c69d5b8f21d8a5c5fe42ab40172
conf/blockerbugs.conf a92f9d881810347d197b7f2bc5f3c2acdcb6a202
blockerbugs/templates/login.html 1d04e336c54d6ba731e49684b7d5b4db8d13f4a0
blockerbugs/templates/layout.html 3b1b6b625062d396b86cda89f40f7a5ba00d7a7d
blockerbugs/controllers/users.py PRE-CREATION
blockerbugs/controllers/admin.py 4a30f273ac515eaa7f75cda3050ac688cf60db2d
blockerbugs/config.py 009e7a97f57e31fcc499dba87fe7d33e41252a2c
blockerbugs/__init__.py ad051ca2523aa70ca2d4d26843e9a2bdf0b5cd00
Diff: http://reviewboard-tflink.rhcloud.com/r/3/diff/
Testing
-------
I've tested mostly against admin.stg.fedoraproject.org but I've verified that the following do work:
- logins
- checking for membership before allowing access to admin pages
I don't have a FAS login to test for denying access to admin pages, though.
Thanks,
Tim Flink
11 years, 2 months
Code Reviews (Again?)
by Tim Flink
As I'm sure you may have figured out with the email from reviewboard, I
was finally able to get a code review system working with both email
and a post-commit workflow.
- http://reviewboard-tflink.rhcloud.com/
Unfortunately, there is no support for FAS (either directly or through
openid) for reviewboard yet. All authentication is handled inside the
reviewboard instance for now.
If we want to use this for autoqa, resultsdb or other qa related
projects, I'm happy to set it up. Adding projects and review groups
is easy to do.
As far as the namespace/DNS entries go, I figured that we could leave
it as is for now. If we want to create an qa-devel openshift account,
I'm happy to get that set up - now that I've figured out how to get the
thing set up I can make a new one without much effort.
Tim
11 years, 2 months
Fwd: Blocker Tracking App Source Move
by Kamil Paral
----- Forwarded Message -----
From: "Tim Flink" <tflink(a)redhat.com>
To: test(a)lists.fedoraproject.org
Sent: Tuesday, February 12, 2013 5:33:34 PM
Subject: Blocker Tracking App Source Move
It was brought to my attention that this hadn't been announced but we
moved the source for the blocker tracking app from the fedora-qa repo
to a standalone repo to make diffs less messy and isolate it a bit
more. The permissions still the same, it's just in a new an shiny
location :)
The new repo is:
http://git.fedorahosted.org/cgit/blockerbugs.git
Tim
11 years, 2 months
Updating and Rebooting Hosts
by Tim Flink
I'm going to be taking down the autoqa and autoqa-stg hosts for updates
shortly since the virthost they are on is going to be rebooted.
I don't expect any issues but I'll send out another email when
everything is done.
Tim
11 years, 3 months
