This patch looks OK, with one comment:
On Tue, 2010-08-31 at 13:07 +0200, Josef Skladanka wrote:
- def initialize(self, config):
- self.config = config_loader(config, self.tmpdir)
- #URL of logs/results stored on autotest-server
- self.autotest_url = autoqa.util.make_autotest_url(self.config)
-
- def setup(self):
- pass
+ def __init__(self, *args, **kwargs):
+ super(upgradepath, self).__init__(*args, **kwargs)
+ self.log = []
+ self.envr_list = set()
This is kind of confusing - is there a reason you need to use __init__()
and not initialize(), as suggested by the test template? For example:
def initialize(self, *args, **kwargs):
super(upgradepath, self).initialize(config)
self.log = []
self.envr_list = set()
Even simpler - why not just set self.log and self.envr_list at the top
of run_once()? Then you don't have to worry about running super(...) at
all.
-w