----- Original Message ----- > Hey gang, > > While testing packaging and deployment, I just noticed that the > autoqa.conf in master doesn't have a value for the field > 'bodhi_server'. > > > # URL of Bodhi instance used for communication about package updates > > # (leave blank for default) > > bodhi_server = > > Should that be empty, or should a default value of > https://admin.fedoraproject.org/updates be there? I just wanted to > confirm my understanding. This is from bodhi_utils.py: > server = autoqa_conf.get('resources', 'bodhi_server') > ops = {'base_url': server} if server else {} > bodhi = fedora.client.bodhi.BodhiClient(username=user, password=pswd, **ops) If 'server' is empty, the default one from BodhiClient class is used (yes, that's https://admin.fedoraproject.org/updates). We could have it explicitly defined in autoqa.conf and thus always passed into BodhiClient through **ops, but mkrizek and I decided it's better just to leave it empty, if we really want to use the default one (although improbable, it can change in the future, etc).

That's why the "# (leave blank for default)" comment is included in the conf file. Do you think we should improve the comment somehow? Or use different approach?