This renames -t/--tag option of post-koji-build watcher to -g/--tag option, because -t already exists on autoqa as -t/--test. Therefore it fixes crash that would occur when running eg.: $ autoqa post-koji-build -l --- hooks/post-koji-build/hook.py | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/hooks/post-koji-build/hook.py b/hooks/post-koji-build/hook.py index 347dc77..68f3e5a 100644 --- a/hooks/post-koji-build/hook.py +++ b/hooks/post-koji-build/hook.py @@ -15,7 +15,7 @@ def extend_parser(parser): '''Extend the given OptionParser object with settings for this hook.''' parser.set_usage('%%prog %s [options] PACKAGENVR' % name) group = optparse.OptionGroup(parser, '%s options' % name) - group.add_option('-t', '--tag', default='', + group.add_option('-g', '--tag', default='', help='Koji tag that has just been applied to this new build') group.add_option('-n', '--name', default='', help='The name of the package, by itself')
----- "Kamil Páral" kparal@redhat.com wrote:
This renames -t/--tag option of post-koji-build watcher to -g/--tag option, because -t already exists on autoqa as -t/--test. Therefore it fixes crash that would occur when running eg.: $ autoqa post-koji-build -l
This is the exception would otherwise get:
# autoqa post-koji-build -l Traceback (most recent call last): File "/usr/bin/autoqa", line 129, in <module> hook.extend_parser(parser) File "/usr/share/autoqa/post-koji-build/hook.py", line 19, in extend_parser help='Koji tag that has just been applied to this new build') File "/usr/lib64/python2.6/optparse.py", line 1014, in add_option self._check_conflict(option) File "/usr/lib64/python2.6/optparse.py", line 989, in _check_conflict option) optparse.OptionConflictError: option -t/--tag: conflicting option string(s): -t
On Thu, 2009-11-12 at 07:01 -0500, Kamil Paral wrote:
----- "Kamil Páral" kparal@redhat.com wrote:
This renames -t/--tag option of post-koji-build watcher to -g/--tag option, because -t already exists on autoqa as -t/--test. Therefore it fixes crash that would occur when running eg.: $ autoqa post-koji-build -l
This is the exception would otherwise get:
# autoqa post-koji-build -l Traceback (most recent call last): File "/usr/bin/autoqa", line 129, in <module> hook.extend_parser(parser) File "/usr/share/autoqa/post-koji-build/hook.py", line 19, in extend_parser help='Koji tag that has just been applied to this new build') File "/usr/lib64/python2.6/optparse.py", line 1014, in add_option self._check_conflict(option) File "/usr/lib64/python2.6/optparse.py", line 989, in _check_conflict option) optparse.OptionConflictError: option -t/--tag: conflicting option string(s): -t
This was already fixed in the wwoods-autotest branch by removing the -t, but using -g is a good idea, so I added that. Thanks!
-w
autoqa-devel@lists.fedorahosted.org
-
Kamil Paral -
Will Woods