#207: post-koji-build watcher does not watch for new updates-candidate builds
-----------------------+----------------------------------------------------
Reporter: kparal | Owner:
Type: defect | Status: new
Priority: major | Milestone: Package Update Acceptance Test Plan
Component: watchers | Version: 1.0
Resolution: | Keywords:
-----------------------+----------------------------------------------------
Comment (by jlaska):
Replying to [ticket:207 kparal]:
I have found out that our post-koji-build watches only these tags:
dist-f10 dist-f10-updates dist-f10-updates-testing dist-f11
dist-f11-updates dist-f11-updates-testing dist-f12 dist-f12-updates
dist-f12-updates-testing dist-f13 dist-f13-updates dist-f13-updates-
testing dist-f14
Which is incorrect, we should be watching dist-f*-updates-candidate (and
maybe dist-f14, I don't know). We don't need to watch for the rest of
it.
The change happened in commit 580734d4f2aa768aefa1c0498904df2296747918.
See the diff and inspect current contents of repoinfo.conf to grasp the
change.
Uh oh, that's my commit :( Great catch.
I thought we ironed this out when we revised repoinfo.conf and cleaned up
the koji watcher methods. But I recall thinking that this was another
hook that could use a test framework to aid in validating changes
(different topic). I'm seeing fc14, fc13 and fc12 builds on autoqa-
results(a)lists.fedorahosted.org. But as you point out, the hook is
skipping any dist-f*-updates-candidate builds. I *wonder* if this is
intentional for the hook but I could be very wrong.
Since I always have a hard time walking through the koji and bodhi hooks,
where the test data changes constantly, I added some extra debugging to
the hook to find a sample build. A good sample build that was skipped is
[
http://koji.fedoraproject.org/koji/buildinfo?buildID=181071
fwbackups-1.43.3-0.9.rc5.fc12] (tag: dist-f12-updates-testing). This
build was submitted to F12 updates-testing, and pushed on 2010-07-05 (see
[
https://admin.fedoraproject.org/updates/fwbackups-1.43.3-0.9.rc5.fc12
bodhi]).
A *quick* fix is to add config sections to repoinfo.conf for [f13-updates-
candidate]. While in my testing this includes the desired builds, I'm not
sure that's the right fix since repoinfo is for package repositories, and
there is no updates-candidate repository.
The result is that we don't currently test almost any packages
except
f14 ones. Do we have it already deployed on our production machine?
Yes, v0.3.5 includes this change
(
http://git.fedorahosted.org/git/?p=autoqa.git;a=shortlog;h=refs/tags/v0.3...).
--
Ticket URL: <
https://fedorahosted.org/autoqa/ticket/207#comment:1>
AutoQA <
http://autoqa.fedorahosted.org>
Automated QA project