On Wed, Jan 25, 2017 at 9:21 AM, Pierre-Yves Chibon <pingou(a)pingoured.fr>
wrote:
On Wed, Jan 25, 2017 at 09:05:03AM +0100, Michal Novotny wrote:
> On Tue, Jan 24, 2017 at 10:40 PM, Pierre-Yves Chibon <
pingou(a)pingoured.fr>
> wrote:
>
> On Tue, Jan 24, 2017 at 01:36:59PM +0100, Michal Novotny wrote:
> >Â Â On Tue, Jan 24, 2017 at 11:44 AM, Pierre-Yves Chibon
> <pingou(a)pingoured.fr>
> >Â Â wrote:
> >
> >Â Â Â On Tue, Jan 24, 2017 at 11:30:33AM +0100, Michal Novotny
> wrote:
> >Â Â Â >Ã*Â Ã*Â Yes, untested changes got into production. We
are
> sorry. I am
> >Â Â Â currently
> >Â Â Â >Ã*Â Ã*Â working on a fix.
> >
> >Â Â Â If that made it up to production, then we'll need to
adjust
> fedmsg_meta
> >Â Â Â to
> >Â Â Â support these messages as well.
> >
> >Â Â Â fedmsg_meta should work for all our published messages
> (published and
> >Â Â Â stored on
> >Â Â Â datagrepper).
> >
> >Â Â Okay, these messages have all empty body (the "msg"
attribute),
> e.g
> >Â Â `build.end`:
> >
> >Â {
> >Â Â "source_name": "datanommer",
> >Â Â "i": 3,
> ...
> >Â Â "timestamp": 1485166967.0,
> >Â Â "msg_id":
"2017-db23086c-2001-496e-a59f-10b92c466ae5",
> >Â Â "topic":
"org.fedoraproject.prod.copr.build.end",
> >Â Â "source_version": "0.6.5",
> >Â Â "signature":
> "HJEOhP93vZFUk3cjIzggxZqIT+IRaLpKF/t21Kn0AcQ9B1VJEe+
myerAAJMZfuXppGQqsFyzcPFx\nu+9p7geI5NqNxnN+diUXNlxbXN9/
VN0X3vX7U4mbc0/zLyGcbKWIn/pcskbM5qYC2lJHLov0pMwq\nrbq/B0N3CxBL2og0Fj8=\n",
> >Â Â "msg": {}
> >Â }
> >
> >Â Â Does fedmsg_meta need to be adjusted even so?
>
> Yeah, fedmsg_meta should be able to process all the messages stored
in
> datagrepper, otherwise it breaks datagrepper and a few other apps.
>
> So we'll end up with some not so useful message: "a build ended in
copr"
> but we
> should add them.
>
> A malformed message (processed with the current fedmsg_meta:
>
> copr.build.start Automated build of the None copr has been started
JSON
>
> fedmsg_meta might already account for the case of missing fields.
Looking
> at the
>
> code, I think this is the case. Let me, please, know what you think.
Well, in the first email on this thread there is an error from fedmsg_meta
so
there is likely one part of fedmsg_meta that won't like the missing fields.
I proposed this PR in fmn.consumer to fix it:
https://github.com/fedora-infra/fmn.consumer/pull/97/commits/fdfcec49d019...
Pierre
_______________________________________________
copr-devel mailing list -- copr-devel(a)lists.fedorahosted.org
To unsubscribe send an email to copr-devel-leave(a)lists.fedorahosted.org