Pushed to git.
Thanks for the review.
On 06/30/2010 01:30 PM, Denys Vlasenko wrote:
remote = (remote_str.find('1') != std::string::npos);
Maybe use more readable construct: remote = (remote_str == "1");
(Two instances of this)
That .find() works also for " 1" and "\n1\n" - hand written
"remote"
file. Poor man's boolean parser.
+# Generate backtrace for remote crashes
+BacktraceRemotes = no
Makes sense to be more verbose here. Clearer doc -> fewer confused
users -> less death threats in our emails.
Something like:
# Generate backtrace for crashes uploaded from remote machines.
# Note that for reliable backtrace generation, your local machine
# needs to have the crashed executable and all libraries it uses,
# and they need to be the same versions as on remote machines.
# If you cannot ensure that, it's better to set this option to "no"
BacktraceRemotes = no
Agreed. Included.