[review-o-matic] TODO list
by Orcan Ogetbil
Hi folks,
>From the template I use for my reviews I prepared this TODO list for the implementation of all the checks that need to be implemented on r-o-m:
http://oget.fedorapeople.org/r-o-m/review-o-matic
The list is pretty much complete. I think it covers almost all of the guidelines, still there might be a few things that we can add.
The boxes on the left hand side of any check indicate which of the following files is needed to do that check: SPEC, SRPM, RPMs, buildlog. I tried to be accurate by putting those x's but there might be minor flaws. Feel free to correct me.
I think this would be a good starting point. Note that the implementation of certain guidelines is very hard. Examples:
- The SPEC file must be written in American English
- If there is a -devel package, check for the header files inside the package to figure out "Requires:" for the -devel package.
- If applicable, package must obey the specific Guidelines (python, java etc)
I think what we should do is to create minimal check files for all the items in this list. Whenever the script runs, the minimal check file should tell the reviewer what needs to be checked manually. In time, whenever we implement some of these checks, we will replace those directives with the proper ones.
Does everybody agree? If yes, I will write the minimal check files rightaway.
-Orcan
15 years, 4 months
[review-o-matic] New check: BuildRootCheck
by Orcan Ogetbil
Hi folks,
I wrote this check a few days ago. Tonight I sat down and polished it. It is actually a very simple one that checks if the Buildroot tag is specified correctly in the specfile.
Here is the link:
http://oget.fedorapeople.org/r-o-m/BuildRootCheck.py
I like the way you designed the API. I will write more checks whenever I have time. Right now I can only do SPEC file check. It would be nice if you could tell me how I can work with the SRPM of the package that is being reviewed. I can write more checks with that in hand.
Please let me know if you have objections, comments, warnings, suggestions, ideas or some extra beer.
Cheers,
Orcan
15 years, 5 months
