[Fedora-haskell-list] [Bug 648007] Review Request: ghc-binary-shared - Haskell library for sharing binary elements
by Red Hat Bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=648007
Ben Boeckel <mathstuf(a)gmail.com> changed:
What |Removed |Added
----------------------------------------------------------------------------
Flag| |fedora-review+
--- Comment #6 from Ben Boeckel <mathstuf(a)gmail.com> 2011-04-17 12:11:56 EDT ---
[+]MUST: rpmlint must be run on every package. The output should be posted in
the review.
See above.
[+]MUST: The package must be named according to the Package Naming Guidelines.
[+]MUST: The spec file name must match the base package %{name}, in the format
%{name}.spec
[+]MUST: The package must meet the Packaging Guidelines.
Naming-Yes
Version-release - Matches
License - OK
No prebuilt external bits - OK
Spec legibity - OK
Package template - OK
Arch support - OK
Libexecdir - OK
rpmlint - yes
changelogs - OK
Source url tag - OK, validated.
Buildroot is ignored - present anyway. OK
%clean is ignored - present anyway. OK
Build Requires list - OK
Summary and description - OK
API documentation - OK
[+]MUST: The package must be licensed with a Fedora approved license and meet
the Licensing Guidelines .
[+]MUST: The License field in the package spec file must match the actual
license.
[+]MUST: If (and only if) the source package includes the text of the
license(s) in its own file, then that file, containing the text of the
license(s) for the package must be included in %doc.
Yes, LICENSE file is present and included.
[+]MUST: The spec file must be written in American English.
[+]MUST: The spec file for the package MUST be legible.
[+]MUST: The sources used to build the package must match the upstream
source,as provided in the spec URL. Reviewers should use md5sum for this task.
--
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.
13 years, 1 month
[Fedora-haskell-list] [Bug 651656] Review Request: ghc-ltk - A UI toolkit for Leksah
by Red Hat Bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=651656
--- Comment #10 from Lakshmi Narasimhan <lakshminaras2002(a)gmail.com> 2011-04-15 09:50:48 EDT ---
Spec file:
http://narasim.fedorapeople.org/package_reviews/ghc-ltk.spec
SRPM link:
http://narasim.fedorapeople.org/package_reviews/ghc-ltk-0.10.0-1.fc14.src...
rpmlint -i *.rpm ghc-ltk-0.10.0-1.fc15.src/ghc-ltk.spec
ghc-ltk.i686: W: spelling-error Summary(en_US) Leksah -> Leks ah, Leks-ah,
Leukas
The value of this tag appears to be misspelled. Please double-check.
ghc-ltk.src: W: spelling-error Summary(en_US) Leksah -> Leks ah, Leks-ah,
Leukas
The value of this tag appears to be misspelled. Please double-check.
ghc-ltk-devel.i686: W: spelling-error Summary(en_US) Leksah -> Leks ah,
Leks-ah, Leukas
The value of this tag appears to be misspelled. Please double-check.
ghc-ltk-prof.i686: E: devel-dependency ghc-ltk-devel
Your package has a dependency on a devel package but it's not a devel package
itself.
ghc-ltk-prof.i686: W: spelling-error Summary(en_US) Leksah -> Leks ah, Leks-ah,
Leukas
The value of this tag appears to be misspelled. Please double-check.
ghc-ltk-prof.i686: W: no-documentation
The package contains no documentation (README, doc, etc). You have to include
documentation files.
ghc-ltk-prof.i686: W: devel-file-in-non-devel-package
/usr/lib/ghc-7.0.2/ltk-0.10.0/libHSltk-0.10.0_p.a
A development file (usually source code) is located in a non-devel package. If
you want to include source code in your package, be sure to create a
development package.
4 packages and 1 specfiles checked; 1 errors, 6 warnings.
--
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.
13 years, 1 month