On Wed, Apr 07, 2021 at 04:14:28PM +0200, Paul Bolle wrote:
Don Zickus schreef op di 06-04-2021 om 10:30 [-0400]:
> To me, duplicates meant that same config setting in fedora and (common or
> ark).
common is for settings that are identical in fedora and ark, right?
Yeah, in theory, though in reality if we are overriding the configs in
'common', are they really identical? :-/ So, aaahh, some better
principles need to be thought up and applied there.
If so, I used to have a local patch to merge.pl. It warned about pointless
overrides (e.g., a config in generic "overriden" to the same value in, say
s390x). That might be of help with part of your work. If I understand you
correctly, that is.
Interesting. Yes that could be useful. Prarit wrote a script called
redhat/configs/evaluate_configs.sh that was supposed to help address those
issues. It seems like your change shows gaps in the tool or our process,
which is probably a good thing. :-)
On the other hand, detecting identical values in separate config directories
that should actually be set in a common sublevel turned out to be a tricky
problem. I tried a few times, but never was satisfied with my results.
Yeah agreed. See my first comment above where theory and reality are not as
aligned as they should be. I think without better principles for those
directories, it is going to be challenging to fix the problems in there.
I welcome any feedback as someone who tried to help. :-D
Cheers,
Don