On Thu, Nov 19, 2020 at 8:00 AM Prarit Bhargava <prarit(a)redhat.com> wrote:
On 11/19/20 7:56 AM, GitLab Bridge on behalf of jeremycline wrote:
> From: Fedora Kernel Team <kernel-team(a)fedoraproject.org>
>
> Hi,
>
> As part of the ongoing rebase effort, the following configuration
> options need to be reviewed.
>
> As a reminder, the ARK configuration flow involves moving unreviewed
> configuration options from the pending directory to the ark directory.
> In the diff below, options are removed from the pending directory and
> added to the ark hierarchy. The final options that need to be ACKed
> are the files that are being added to the ark hierarchy.
>
> If the value for a file that is added should be changed, please reply
> with a better option.
>
jforbes, did something mis-fire here? The patch is empty.
This is already set in configs/ark/generic. It was not in Fedora
because a dependent option was turned off. When I turned it on
yesterday, it added the Fedora pending last night, but it should not
have created an MR. So yes, it is a misfire, but I am guessing it is a
script bug. If I had to guess, the script checks configs/common, but
not configs/ark. The empty is created because there is no default to
change it to as the option is already set.
Justin