Re: filesystem patch

On Mon, Dec 29, 2008 at 03:44:54PM +0100, Farkas Levente wrote: > Farkas Levente wrote: >> Daniel P. Berrange wrote: >>> I still really don't think we should be passing all these args to >>> 'make' or 'make install' by default because its diverging from what >>> native builds do. For native builds '%__make' just expands to >>> '/usr/bin/make' and %configure is where all these paths are setup. >>> Only in a very few cases of broken apps not using autotools would >>> args to make be needed and they can be done in those app's .spec >>> >>> Daniel >> you've got right, the most important part here to set env variable >> setting and not make's args ie. it can be: >> %_mingw32_make %{_mingw32_env} ; make >> too. >> but the %_mingw32_makeinstall should have to remain this way (imho) > so here's my last patch in this series which removes the parameters from > make. [...] > +%_mingw32_make %{_mingw32_env} ; make I think, as per Daniel's reply above, that %_mingw32_make should just expand to plain 'make'. Note that almost every specfile we have just runs 'make' (and 'make install'). This macro isn't really used anywhere, so I'm not sure why it is necessary.