On 01/04/15 12:49, Jacek Caban wrote:
Maybe I missed some better options for us. None of above is perfect
and
I'm not sure what we should do about it. Solution 2. seems the least
problematic.
Looking deeper at this, current implementation has one more problem. We
can't really have localtime_r, because it needs to depend on
_USE_32BIT_TIME_T macro. So if we really wanted to have a real function
in mingwex, we'd need it as localtime32_r and localtime64_r and an
inline wrapper. Given that, I think we should live with inline
implementation. Esp. since we may use localtime_s (which already has
wrapper inline as well as compatibility stub in libmsvcrt.a), which
makes the implementation trivial. Please review the attached patch. I
believe we should do the same for ctime_r and asctime_r.
Jacek