Re: NSPR (Netscape Portable Runtime) and NSS (Netscape Security lib) uploaded
Richard W.M. Jones wrote:
I just uploaded NSPR and NSS, source in the Mercurial repository,
binaries
for Rawhide in the temporary yum repository:
http://homes.merjis.com/~rich/mingw/
These are major libraries, used directly or indirectly by a lot of
software, so any testing / bug reports gratefully received.
first quick look and no patches:
- nss
PatchX: missing from spec?
------------------------------
rpmlint mingw32-nss.spec
mingw32-nss.spec:96: W: rpm-buildroot-usage %build %{__mkdir_p}
$RPM_BUILD_ROOT/%{_libdir}/pkgconfig
mingw32-nss.spec:103: W: rpm-buildroot-usage %build
$RPM_BUILD_ROOT/%{_libdir}/pkgconfig/nss.pc
mingw32-nss.spec:115: W: rpm-buildroot-usage %build %{__mkdir_p}
$RPM_BUILD_ROOT/%{_bindir}
mingw32-nss.spec:123: W: rpm-buildroot-usage %build >
$RPM_BUILD_ROOT/%{_bindir}/nss-config
mingw32-nss.spec:125: W: rpm-buildroot-usage %build chmod 755
$RPM_BUILD_ROOT/%{_bindir}/nss-config
------------------------------
why eg. %{__mkdir_p} $RPM_BUILD_ROOT/%{_bindir} in the %build section
and not in the %install section?
and it's rather complicated so i can't take the plunge to review it now:-(
- nspr
why:
%{_mingw32_configure} \
--prefix=%{_mingw32_prefix} \
--libdir=%{_mingw32_libdir} \
since _mingw32_configure already contains it.
in stead of:
make \
NSINSTALL=$(pwd)/config/nsinstall \
RANLIB=i686-pc-mingw32-ranlib \
RC=i686-pc-mingw32-windres \
%{?_smp_mflags}
at least use _mingw32_ranlib etc or even better %{_mingw32_make}
i've got flu and fever so won't send any patches in this week to these
packages.
--
Levente "Si vis pacem para bellum!"