Richard W.M. Jones wrote:
On Wed, Feb 18, 2009 at 04:36:52PM +0100, Farkas Levente wrote:
> Richard W.M. Jones wrote:
>> I just uploaded NSPR and NSS, source in the Mercurial repository, binaries
>> for Rawhide in the temporary yum repository:
>>
>>
http://homes.merjis.com/~rich/mingw/
>>
>> These are major libraries, used directly or indirectly by a lot of
>> software, so any testing / bug reports gratefully received.
> first quick look and no patches:
> - nss
> PatchX: missing from spec?
> ------------------------------
> rpmlint mingw32-nss.spec
> mingw32-nss.spec:96: W: rpm-buildroot-usage %build %{__mkdir_p}
> $RPM_BUILD_ROOT/%{_libdir}/pkgconfig
> mingw32-nss.spec:103: W: rpm-buildroot-usage %build
> $RPM_BUILD_ROOT/%{_libdir}/pkgconfig/nss.pc
> mingw32-nss.spec:115: W: rpm-buildroot-usage %build %{__mkdir_p}
> $RPM_BUILD_ROOT/%{_bindir}
> mingw32-nss.spec:123: W: rpm-buildroot-usage %build >
> $RPM_BUILD_ROOT/%{_bindir}/nss-config
> mingw32-nss.spec:125: W: rpm-buildroot-usage %build chmod 755
> $RPM_BUILD_ROOT/%{_bindir}/nss-config
> ------------------------------
> why eg. %{__mkdir_p} $RPM_BUILD_ROOT/%{_bindir} in the %build section
> and not in the %install section?
> and it's rather complicated so i can't take the plunge to review it now:-(
>
> - nspr
> why:
> %{_mingw32_configure} \
> --prefix=%{_mingw32_prefix} \
> --libdir=%{_mingw32_libdir} \
> since _mingw32_configure already contains it.
>
> in stead of:
> make \
> NSINSTALL=$(pwd)/config/nsinstall \
> RANLIB=i686-pc-mingw32-ranlib \
> RC=i686-pc-mingw32-windres \
> %{?_smp_mflags}
> at least use _mingw32_ranlib etc or even better %{_mingw32_make}
Thanks - these are all good suggestions.
I've actually been tipped off[0] that these NSPR/NSS packages probably
won't work because gcc ignores the __declspec(thread) annotations
(Thread Local Storage under Windows, q.v.[1]). I'm going to look at a
fix for this shortly.
Rich.
[0] Novell's packages:
http://download.opensuse.org/repositories/home:/fstrba:/CrossMingw:/test/...
hoops i don't know they take our spec files and now even ahead of us or
at least take all of our specs:-( it'd be nice if they can also help us...
--
Levente "Si vis pacem para bellum!"