Re: GD package for MinGW64/32

Boszormenyi Zoltan schreef op vr 02-12-2011 om 21:15 [+0100]: > 2011-12-02 16:57 keltezéssel, Erik van Pienbroek írta: >> Would you also be interested in becoming package maintainer for this >> package in Fedora once the mingw-w64 toolchain is available in Fedora? > How much work is it? Basically it means that you'll have to update the package once upstream releases new versions and that you'll take care of any bugreports which might get filed against this package. Of course we (the Fedora MinGW SIG) will help you with this, but being package owner will mean that you'll become the primary point of contact. For a package like GD (which doesn't have that much upstream releases these days) I think it doesn't require that much maintenance.

> I used this SRPM from your repo as template > http://build1.openftd.org/fedora-cross/src/mingw-glib2-2.29.2-3.fc15_cros... > so any bugs are copy&paste from mingw-glib2.spec and leftovers > from the original Fedora gd.spec. Ah I see. The .src.rpm you mentioned is a bit outdated right now. The most recent version of the .spec files in the mingw-w64 testing repo can be found at http://svn.openftd.org/svn/fedora_cross/ (which will also be the location where I'll add your package for the time being). The reason why I didn't upload all the recent .src.rpm's is a lack of disk space on the webhost. All .src.rpm's can easily be regenerated by checking out the svn repo I just mentioned.

>> - In the %install section there are some places where just used >> 'i686-w64-mingw32' and 'x86_64-w64-mingw32' literally. Please use the >> macros %{mingw32_target} and %{mingw64_target} there > You mean in the loops to rename %{whatever_target_prefix}-binaries? > OK, I will change these. I wasn't sure about the macro names for > targets, thanks for telling them. You can see all the available RPM macros in the files /etc/rpm/macros.mingw, /etc/rpm/macros.mingw32 and /etc/rpm/macros.mingw64. Additionally almost all these RPM macros are also documented in the new Fedora MinGW Packaging Guidelines: https://fedoraproject.org/wiki/Packaging:MinGW_Future

>> Could you update the .spec file? > Here it is. I even suppressed the empty mingw-gd package now. > Thanks for the review again. Very good! I just tried to build your package in mock, but it failed to build: ...

With all these additional BuildRequires the package builds fine in mock. After you've made these changes I'll add the package to the mingw-w64 testing repo.

Kind regards, Erik van Pienbroek _______________________________________________ mingw mailing list mingw(a)lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/mingw