openlmi-reviews September 2013

openlmi-reviews@lists.fedorahosted.org

2 participants
127 discussions

Review Request 810: openlmi-tools [2/2] added LMI_SoftwareVerificationJob to supported jobs
by Stephen Gallagher 02 Sep '13

02 Sep '13

1 2

Review Request 809: openlmi-tools [1/2] use NocaseDict instead of dict where appropriate
by Stephen Gallagher 02 Sep '13

02 Sep '13

----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviewboard-openlmi.rhcloud.com/r/809/ ----------------------------------------------------------- Review request for OpenLMI Developers. Repository: openlmi-tools Description ------- use NocaseDict instead of dict where appropriate NocaseDict should be used for properties of instances, instance names and output parameters of method to allow for case-insesitive comparisons. This fixes a bug, where job was not found in output parameters of asynchronous method, when treating it as a synchronoush one. Diffs ----- cli/lmi/shell/LMIInstance.py 17646deedde5e39cd6dc129bae7b84d29c491a6e cli/lmi/shell/LMIInstanceName.py b4dcc4235437923a392dd26262fdcdddc5db228d cli/lmi/shell/LMIMethod.py a5bad8dfeb8047f60e6bcd4c7909fd4aa00d2106 cli/lmi/shell/LMIReturnValue.py 92030409b4159a60ad4fbc776f3835e96dcdf0fa cli/lmi/shell/LMIUtil.py 9f34d21dba408a4a908495a68011c2faef35224b Diff: http://reviewboard-openlmi.rhcloud.com/r/809/diff/ Testing ------- Thanks, Michal Minar

1 2

Review Request 813: openlmi-software(fix) [1/1] software: fixed installation of rpm package from uri
by Stephen Gallagher 02 Sep '13

02 Sep '13

1 2

Review Request 812: Account [2/2] Account: Remove unused code
by Stephen Gallagher 02 Sep '13

02 Sep '13

1 2

Review Request 808: [1/1] Account: Use constants for method return values
by Stephen Gallagher 02 Sep '13

02 Sep '13

1 3

Review Request 764: journald: Include process name and PID in the message
by Stephen Gallagher 02 Sep '13

02 Sep '13

1 2

Review Request 759: journald: Map the PRIORITY field to CIM_RecordForLog.PerceivedSeverity
by Stephen Gallagher 02 Sep '13

02 Sep '13

----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviewboard-openlmi.rhcloud.com/r/759/ ----------------------------------------------------------- Review request for OpenLMI Developers. Repository: openlmi-providers Description ------- journald: Map the PRIORITY field to CIM_RecordForLog.PerceivedSeverity Records in journal may contain syslog-style priority value so let's use them. Unfortunately mapping the particular values between syslog and CIM classes is not linear, manual mapping is needed. The LOG_ERR may also map to PerceivedSeverity = Major but it's kept on Minor for the moment. If no such information is provided by the Journal, the CIM property is left unset for the particular record. See e.g. http://schemas.dmtf.org/wbem/cim-html/2.34.0/CIM_RecordForLog.html for valuemap description. Diffs ----- src/journald/instutil.c PRE-CREATION Diff: http://reviewboard-openlmi.rhcloud.com/r/759/diff/ Testing ------- Thanks, Tomáš Bžatek

1 2

Review Request 690: [1/1] journald: Basic provider implementation
by Stephen Gallagher 02 Sep '13

02 Sep '13

----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviewboard-openlmi.rhcloud.com/r/690/ ----------------------------------------------------------- Review request for OpenLMI Developers. Repository: openlmi-providers Description ------- journald: Basic provider implementation This is a fully functional basic implementation of the provider. Maximum number of enumerated instances is limited, see the code. Diffs ----- CMakeLists.txt f150e4c77b3cf0475ff906b019da8bdcfab79676 mof/60_LMI_Journald.mof PRE-CREATION src/CMakeLists.txt a9dc85d293b82805d4d956f1adbd212c873fd743 src/journald/CMakeLists.txt PRE-CREATION src/journald/LMI_JournalLogRecordProvider.c PRE-CREATION src/journald/LMI_JournalMessageLogProvider.c PRE-CREATION src/journald/LMI_JournalRecordInLogProvider.c PRE-CREATION src/journald/README PRE-CREATION src/journald/TODO PRE-CREATION src/journald/cmpiLMI_Journald-cimprovagt PRE-CREATION src/journald/instutil.h PRE-CREATION src/journald/instutil.c PRE-CREATION src/journald/journal.h PRE-CREATION Diff: http://reviewboard-openlmi.rhcloud.com/r/690/diff/ Testing ------- Thanks, Tomáš Bžatek

1 11

Review Request 734: journald: Use lmi logging infrastructure for error messages
by Stephen Gallagher 02 Sep '13

02 Sep '13

----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviewboard-openlmi.rhcloud.com/r/734/ ----------------------------------------------------------- Review request for OpenLMI Developers. Repository: openlmi-providers Description ------- journald: Use lmi logging infrastructure for error messages -- This is an addendum to review #731 Diffs ----- src/journald/LMI_JournalLogRecordInstanceCreationIndicationProvider.c PRE-CREATION src/journald/LMI_JournalLogRecordProvider.c PRE-CREATION src/journald/LMI_JournalMessageLogProvider.c PRE-CREATION src/journald/LMI_JournalRecordInLogProvider.c PRE-CREATION src/journald/instutil.c PRE-CREATION src/journald/journal.h PRE-CREATION Diff: http://reviewboard-openlmi.rhcloud.com/r/734/diff/ Testing ------- Thanks, Tomáš Bžatek

1 4

Review Request 731: journald: Add indications
by Stephen Gallagher 02 Sep '13

02 Sep '13

----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviewboard-openlmi.rhcloud.com/r/731/ ----------------------------------------------------------- Review request for OpenLMI Developers. Repository: openlmi-providers Description ------- journald: Add indications Also contains simple test suite to test indications. Still contains some TODOs as there's a copy-pasted code that could live in a shared place. Diffs ----- mof/60_LMI_Journald.mof PRE-CREATION src/journald/CMakeLists.txt PRE-CREATION src/journald/LMI_JournalLogRecordInstanceCreationIndicationProvider.c PRE-CREATION src/journald/instutil.h PRE-CREATION src/journald/instutil.c PRE-CREATION src/journald/test/TestIndications.py PRE-CREATION src/journald/test/common.py PRE-CREATION src/journald/test/localtest.sh PRE-CREATION Diff: http://reviewboard-openlmi.rhcloud.com/r/731/diff/ Testing ------- Thanks, Tomáš Bžatek

1 9

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

openlmi-reviews September 2013