openlmi-reviews September 2013

openlmi-reviews@lists.fedorahosted.org

2 participants
127 discussions

Start a nNew thread

Review Request 856: software [1/1] software: fixed critical section problem
by Stephen Gallagher 12 Sep '13

12 Sep '13

1 2

Review Request 857: [1/2] logicalfile: warn if udev context creation fails
by Stephen Gallagher 12 Sep '13

12 Sep '13

1 2

Review Request 858: [2/2] logicalfile: ignore some key properties
by Stephen Gallagher 12 Sep '13

12 Sep '13

----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviewboard-openlmi.rhcloud.com/r/858/ ----------------------------------------------------------- Review request for OpenLMI Developers. Repository: openlmi-providers Description ------- logicalfile: ignore some key properties CIM_LogicalFile and CIM_UnixFile have some key properties that are not needed when calling GetInstance(). On Linux systems, all is needed to get information about a file is its path. Type of the filesystem that the file resides on and the file type itself are not needed. In fact, its not desirable to require those when querying remote systems. Ignore FSCreationClassName, FSName, LFCreationClassName and CreationClassName. This commit reverts most of the functionality of commit 5c3e1a6203e495bec37acd8c3731ca41377beb94. Diffs ----- src/logicalfile/LMI_FileIdentityProvider.c 7ada7873c0b90f88bcbf5b3ba1a44aa704c713e4 src/logicalfile/LMI_RootDirectoryProvider.c 2be709f0d0a0ca50271508dffe67bbfc357cc710 src/logicalfile/LMI_UnixFileProvider.c 5da5bb0a471228653fabc30c5a7793c526ebaff3 src/logicalfile/file.h b7ecb53cf43ee2f290c5bbdf091165c81b86ac2d src/logicalfile/file.c e6968dea33240a307c389abba8c1340e3b098bb6 src/logicalfile/test/test_basic.py fbcf6d57829d35e134cfdedab9501043fd3c372a src/logicalfile/LMI_DirectoryContainsFileProvider.c 753cb00d184a71bbaa3a3d63883110480750d8d9 Diff: http://reviewboard-openlmi.rhcloud.com/r/858/diff/ Testing ------- Thanks, Jan Synacek

1 1

Review Request 840: [1/1] Account: First upstream account test from qa.
by Stephen Gallagher 12 Sep '13

12 Sep '13

1 7

Review Request 846: [1/1] Account: Added associative thread locking.
by Stephen Gallagher 11 Sep '13

11 Sep '13

1 6

Review Request 850: [1/1] Account: Removed unused macro undefinitions.
by Stephen Gallagher 11 Sep '13

11 Sep '13

1 2

Review Request 842: [1/1] Account: Added associative thread locking.
by Stephen Gallagher 10 Sep '13

10 Sep '13

1 11

Review Request 844: service-provider [1/1] Service: Fix detection of service state
by Stephen Gallagher 10 Sep '13

10 Sep '13

1 2

Review Request 816: software(fix) [1/1] fixed getting information about verification job
by Stephen Gallagher 10 Sep '13

10 Sep '13

1 1

Review Request 822: software(fixes) [1/2] fix issues when creating instance for broken repository
by Stephen Gallagher 10 Sep '13

10 Sep '13

1 2

← Newer
1
...
5
6
7
8
9
10
11
12
13
Older →

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

openlmi-reviews September 2013