Review Request 1284: networking [1/1] Allow to use SlaveSettingData for activation of slave settings
----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviewboard-openlmi.rhcloud.com/r/1284/ -----------------------------------------------------------
Review request for OpenLMI Developers.
Repository: openlmi-networking
Description -------
Allow to use SlaveSettingData for activation of slave settings
Bridge and bond slaves now can be activated either referencing MasterSettingData or SlaveSettingData. SlaveSettingData is preferred (and documented) way to do it.
Tests has been added to check both ways.
Diffs -----
doc/admin/usage.rst 7975bea8b995809e93810c6575996a03618ea15c src/LMI_IPConfigurationServiceProvider.c 64f39f60d01d20c1857d10709ee74295a0b7a17a src/connection.c 64529ef5fdae75896a39115043f5fea527c115bd src/port_nm.c 31002bf23b3f2b2d260e040c4efc9ac922ea82f7 test/test_bonding.py 725abeadb4fd95a11d4b5c91caaf1df429e7722d test/test_bridging.py d91b9d3d1fff9617b4cd910d1c840591deff9bff
Diff: http://reviewboard-openlmi.rhcloud.com/r/1284/diff/
Testing -------
Thanks,
Radek Novacek
----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviewboard-openlmi.rhcloud.com/r/1284/#review1783 -----------------------------------------------------------
Autoscan started for review(s) 1284
- scanbot
On Nov. 25, 2013, 12:19 p.m., Radek Novacek wrote:
This is an automatically generated e-mail. To reply, visit: http://reviewboard-openlmi.rhcloud.com/r/1284/
(Updated Nov. 25, 2013, 12:19 p.m.)
Review request for OpenLMI Developers.
Repository: openlmi-networking
Description
Allow to use SlaveSettingData for activation of slave settings
Bridge and bond slaves now can be activated either referencing MasterSettingData or SlaveSettingData. SlaveSettingData is preferred (and documented) way to do it.
Tests has been added to check both ways.
Diffs
doc/admin/usage.rst 7975bea8b995809e93810c6575996a03618ea15c src/LMI_IPConfigurationServiceProvider.c 64f39f60d01d20c1857d10709ee74295a0b7a17a src/connection.c 64529ef5fdae75896a39115043f5fea527c115bd src/port_nm.c 31002bf23b3f2b2d260e040c4efc9ac922ea82f7 test/test_bonding.py 725abeadb4fd95a11d4b5c91caaf1df429e7722d test/test_bridging.py d91b9d3d1fff9617b4cd910d1c840591deff9bff
Diff: http://reviewboard-openlmi.rhcloud.com/r/1284/diff/
Testing
Thanks,
Radek Novacek
----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviewboard-openlmi.rhcloud.com/r/1284/#review1788 -----------------------------------------------------------
Autoscan finished OK
Scanned reviews: 1284
- scanbot
On Nov. 25, 2013, 12:19 p.m., Radek Novacek wrote:
This is an automatically generated e-mail. To reply, visit: http://reviewboard-openlmi.rhcloud.com/r/1284/
(Updated Nov. 25, 2013, 12:19 p.m.)
Review request for OpenLMI Developers.
Repository: openlmi-networking
Description
Allow to use SlaveSettingData for activation of slave settings
Bridge and bond slaves now can be activated either referencing MasterSettingData or SlaveSettingData. SlaveSettingData is preferred (and documented) way to do it.
Tests has been added to check both ways.
Diffs
doc/admin/usage.rst 7975bea8b995809e93810c6575996a03618ea15c src/LMI_IPConfigurationServiceProvider.c 64f39f60d01d20c1857d10709ee74295a0b7a17a src/connection.c 64529ef5fdae75896a39115043f5fea527c115bd src/port_nm.c 31002bf23b3f2b2d260e040c4efc9ac922ea82f7 test/test_bonding.py 725abeadb4fd95a11d4b5c91caaf1df429e7722d test/test_bridging.py d91b9d3d1fff9617b4cd910d1c840591deff9bff
Diff: http://reviewboard-openlmi.rhcloud.com/r/1284/diff/
Testing
Thanks,
Radek Novacek
----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviewboard-openlmi.rhcloud.com/r/1284/#review1798 -----------------------------------------------------------
Ship it!
Ship It!
- Jan Safranek
On Nov. 25, 2013, 1:19 p.m., Radek Novacek wrote:
This is an automatically generated e-mail. To reply, visit: http://reviewboard-openlmi.rhcloud.com/r/1284/
(Updated Nov. 25, 2013, 1:19 p.m.)
Review request for OpenLMI Developers.
Repository: openlmi-networking
Description
Allow to use SlaveSettingData for activation of slave settings
Bridge and bond slaves now can be activated either referencing MasterSettingData or SlaveSettingData. SlaveSettingData is preferred (and documented) way to do it.
Tests has been added to check both ways.
Diffs
doc/admin/usage.rst 7975bea8b995809e93810c6575996a03618ea15c src/LMI_IPConfigurationServiceProvider.c 64f39f60d01d20c1857d10709ee74295a0b7a17a src/connection.c 64529ef5fdae75896a39115043f5fea527c115bd src/port_nm.c 31002bf23b3f2b2d260e040c4efc9ac922ea82f7 test/test_bonding.py 725abeadb4fd95a11d4b5c91caaf1df429e7722d test/test_bridging.py d91b9d3d1fff9617b4cd910d1c840591deff9bff
Diff: http://reviewboard-openlmi.rhcloud.com/r/1284/diff/
Testing
Thanks,
Radek Novacek
----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviewboard-openlmi.rhcloud.com/r/1284/ -----------------------------------------------------------
(Updated Nov. 27, 2013, 9:50 a.m.)
Status ------
This change has been marked as submitted.
Review request for OpenLMI Developers.
Repository: openlmi-networking
Description -------
Allow to use SlaveSettingData for activation of slave settings
Bridge and bond slaves now can be activated either referencing MasterSettingData or SlaveSettingData. SlaveSettingData is preferred (and documented) way to do it.
Tests has been added to check both ways.
Diffs -----
doc/admin/usage.rst 7975bea8b995809e93810c6575996a03618ea15c src/LMI_IPConfigurationServiceProvider.c 64f39f60d01d20c1857d10709ee74295a0b7a17a src/connection.c 64529ef5fdae75896a39115043f5fea527c115bd src/port_nm.c 31002bf23b3f2b2d260e040c4efc9ac922ea82f7 test/test_bonding.py 725abeadb4fd95a11d4b5c91caaf1df429e7722d test/test_bridging.py d91b9d3d1fff9617b4cd910d1c840591deff9bff
Diff: http://reviewboard-openlmi.rhcloud.com/r/1284/diff/
Testing -------
Thanks,
Radek Novacek
openlmi-reviews@lists.fedorahosted.org
-
Stephen Gallagher