[Bug 189717] New: Review Request: gcompris - Educational suite for kids 2-10 years old
by Red Hat Bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.
https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=189717
Summary: Review Request: gcompris - Educational suite for kids 2-
10 years old
Product: Fedora Extras
Version: devel
Platform: All
OS/Version: Linux
Status: NEW
Severity: normal
Priority: normal
Component: Package Review
AssignedTo: bugzilla-sink(a)leemhuis.info
ReportedBy: j.w.r.degoede(a)hhs.nl
QAContact: fedora-package-review(a)redhat.com
Spec URL: http://home.zonnet.nl/jwrdegoede/gcompris.spec
Files URL: http://home.zonnet.nl/jwrdegoede/gcompris-files.tar.gz
Description:
GCompris / I Got IT is an educationnal game for children starting at 2.
More than 100 different activities are proposed:
* Click on the animals => learn the mouse/click usage
* Type the falling letters => learn the keyboard usage
* Falling Dices
* Falling words
* Basic algebra
* Time learning with an analog clock
* Puzzle game with famous paintings
* Drive Plane to catch clouds in increasing number
* Balance the scales
* And much more ...
Some activities make use of sounds. For those you'll have to install the
gcompris-sound package for the languages you intend to use.
---
First of all sorry, no SRPM the upstream sources are way too large for my sucky ISP provided homepage. You can get the upstream tarball from:
http://sf.net/projects/gcompris
And then the files section.
All other needed SOURCES files are in gcompris-files.tar.gz, just untar this in your SOURCES dir and drop the main tarball in your SOURCES dir and you're good to go.
Notice that part of gcompris (1 activity) needs gnucap, which I've packaged too:
https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=189699
Last some small know issues, which I've also reported upstream:
1) If you switch the language to dutch and then start gcompris from a
cmdline the following messages appear:
parser error : EntityRef: expecting ';'
parser error : EntityRef: expecting ';'
These are libxml messages, things work fine though.
2) If you don't have any (valid) alphabet sounds and try to run the
letter-click (click the letter you hear) board a message is shown
saying that you need to install some alphabet sounds, it is however
possible to still start and play the game behind the message box by
clicking the letters. Also it is possible to exit to the main menu
by pressing the home icon, the message box stays in place then , but
its drawn over the home menu instead of over the letter click board.
--
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug, or are watching the QA contact.
18 years, 1 month
[Bug 183912] Review Request: jack-audio-connection-kit - The Jack Audio Connection Kit
by Red Hat Bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.
Summary: Review Request: jack-audio-connection-kit - The Jack Audio Connection Kit
https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=183912
------- Additional Comments From green(a)redhat.com 2006-04-30 06:54 EST -------
(In reply to comment #24)
> W: jack-audio-connection-kit one-line-command-in-%post /sbin/ldconfig
> W: jack-audio-connection-kit one-line-command-in-%postun /sbin/ldconfig
>
> I don't know why mock is complaining. You've got exactly whats in
> ScriptletSnippets. Ignore it?
I believe it will stop complaining if you write one line commands like so:
%post -p /sbin/ldconfig
%postun -p /sbin/ldconfig
ScriptletSnippets should probably be updated.
--
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug, or are watching the QA contact.
18 years, 1 month
[Bug 188369] Review Request: ctapi-cyberjack
by Red Hat Bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.
Summary: Review Request: ctapi-cyberjack
https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=188369
------- Additional Comments From frank-buettner(a)gmx.net 2006-04-30 06:24 EST -------
So I have try to fix it but I have found an big bug in rpmbuild:(
to support FC4 and FC5 I have written this:
#use this for FC4
#%define readers_dir XXXX
#use this for FC5
#%define readers_dir YYYY
but rpmbuild ignore the # so when remove the # for FC4
the variable readers_dir ist not XXXX it is YYYY
--
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug, or are watching the QA contact.
18 years, 1 month
[Bug 188369] Review Request: ctapi-cyberjack
by Red Hat Bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.
Summary: Review Request: ctapi-cyberjack
https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=188369
------- Additional Comments From j.w.r.degoede(a)hhs.nl 2006-04-30 04:53 EST -------
Well thats a nice start:
[hans@shalem ~]$ rpmbuild -ba /usr/src/redhat/SPECS/ctapi-cyberjack.spec
error: parse error in expression
error: /usr/src/redhat/SPECS/ctapi-cyberjack.spec:15: parseExpressionBoolean
returns -1
error: Package has no %description: ctapi-cyberjack
This is caused by the following lines in the spec:
%if %{dist} == "FC4"
%define readers_dir %{_libdir}/readers
%else
%define readers_dir %(pkg-config libpcsclite --variable=usbdropdir)
%endif
I was already planning on adding a "MUST Fix" item for those, but not this soon
in the review. This is not the Fedora Extras way of doing things to avoid %if
filled specfiles we have one specfile per release in our CVS. Reviews should
always happen against the devel release, but in most cases (this one included)
the latest stable is fine too.
So for this review please target FC-5 and FC-5 only then once your package is
approved and imported (into the devel branch where all imports happen) you can
request CVS branches for FC-5 and FC-4 and then change the specfile for FC-4 .
It is ok to add a comment to the specfile submitted for review about nescesarry
changes for older releases. So you could change the above lines to:
# define this to %{_libdir}/readers when building on FC-4
%define readers_dir %(pkg-config libpcsclite --variable=usbdropdir)
Since it looks like I won't be able todo a full review right now after all
because of lack of time and because there is alot to fix in a first glance, here
is a quick and probably incomplete list of "MUST Fix" items:
MUST Fix
========
* Don't use release conditional %if constructs, instead target FC-5 with the
spec submitted for review (see above).
* Don't use German in the specfile not even in comments
* Remove the unused "%define _realrelease 1"
* Replace "4%{dist}" with "4%{?dist}" watch the ?
* Have you tried replacing "make" with "make %{?_smp_mflags}" ?
Ifso please add a comment that make breaks with %{?_smp_mflags} if not
please add %{?_smp_mflags}.
* When linking libctapi-cyberjack.so it doesn't get passed an soname flag, the
ld -x --shared -lusb -o libctapi-cyberjack.so ctn_list.o cjctapi_beep.o ...
command should get passed "-soname libctapi-cyberjack.so.0"
* When installing libctapi-cyberjack.so you install it as
libctapi-cyberjack.so.%{version} this is not correct you should install it as
libctapi-cyberjack.so.0 (matching the -soname above).
When the ABI of the library changes (which it will probably never will) you
change both the -soname and the install command to libctapi-cyberjack.so.1,
when the ABI changes again to .2 etc.
* Don't use a .so.%{version} install for the ifd, this is a plugin which always
gets dlopen-ed and as such should be installed as a plain .so, thus you also
do not need to add -soname to the link command for the ifd only for the ctapi
lib.
* libcyberjack_ifd.so gets staticly linked against libctapi-cyberjack, please
make this dynamic (currently the link command includes:
"../ctapi/libctapi-cyberjack.a" replace this with "-L../ctapi
-llibctapi-cyberjack").
* drop the "Requires: %{name} = %{version}" for PC-SC subpackage,
currently it is staticly linked and the dyn link which should be there will
lead to an autodependency generated by rpm.
* Rename the "PC-SC" subpakcage to pcsc to match the way pcsc is written in
other packages names (pcsc-lite, pcsc-tools, pcsc-perl)
* Don't create the docdir and install the docs there just name the docs
as they are releative to the builddir afyter %doc, rpmbuild will copy
them for you and create the docdir itself.
And some personal preferences of mine, not obligatory in anyway:
* Don't put a "," between BuildRequires whitespace alone is enough.
* Don't use %{buildroot} because %{buildroot}%{_datadir} is hard to read,
instead use $RPM_BUILD_ROOT, $RPM_BUILD_ROOT%{_datadir} is IMHO much easier
to read.
Phew, long list. Good luck fixing all these, most are trivial to fix though and
don't get scared away by this you picked a hard package to start with and as
package more software your reviews will go more and more smoothly. Please post a
new version addressing all the above MUST Fix items, then I'll take a second
stab at doing a Full review and hopefully approving your first package. Feel
free to ask questions about the above if there is anything you don't understand
or disagree with.
--
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug, or are watching the QA contact.
18 years, 1 month
[Bug 188369] Review Request: ctapi-cyberjack
by Red Hat Bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.
Summary: Review Request: ctapi-cyberjack
https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=188369
j.w.r.degoede(a)hhs.nl changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|NEW |ASSIGNED
AssignedTo|bugzilla-sink(a)leemhuis.info |j.w.r.degoede(a)hhs.nl
CC|j.w.r.degoede(a)hhs.nl |
OtherBugsDependingO|163776 |163778
nThis| |
------- Additional Comments From j.w.r.degoede(a)hhs.nl 2006-04-30 04:05 EST -------
Still needs a bit of work, I'll do a full review shortly.
--
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug, or are watching the QA contact.
18 years, 1 month