[Bug 188625] Review Request: AllegroOgg - Ogg library for use with the Allegro game library
by Red Hat Bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.
Summary: Review Request: AllegroOgg - Ogg library for use with the Allegro game library
https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=188625
wart(a)kobold.org changed:
What |Removed |Added
----------------------------------------------------------------------------
OtherBugsDependingO|163778 |163779
nThis| |
------- Additional Comments From wart(a)kobold.org 2006-04-29 23:00 EST -------
Most of the initial review still holds true, so I'll only comment on the new
changes:
* pkgconfig file part of -devel
* header file and .so (no suffix) part of -devel
* Package named correctly (Ogg -> OGG is fine, and even matches upstream better)
rpmlint output:
W: AllegroOGG-devel no-documentation
...which is ok to ignore since there is no -devel specific documentation and
-devel requires the base package, which provides the package documentation.
APPROVED
--
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug, or are watching the QA contact.
18 years, 1 month
[Bug 182064] Review Request: facter
by Red Hat Bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.
Summary: Review Request: facter
https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=182064
------- Additional Comments From jpmahowald(a)gmail.com 2006-04-29 20:42 EST -------
(In reply to comment #13)
> Strange .. it looks like the rpm was built on a machine that had
> Config::CONFIG["sitelibdir"] set to /usr/lib64/ruby/site_ruby/1.8. Are you sure
> the rpm wasn't built against a newer ruby package (e.g., the new 1.8.4-4 test
> packages that Akira Tagoh has put out) ? Those moved site_ruby from %_libdir to
> %_libdir/ruby.
That's what I get for building rawhide on a FC5 box. My mock logs actually show
1.8.4-4.fc6
--
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug, or are watching the QA contact.
18 years, 1 month
[Bug 181369] Review Request: libedit - The NetBSD Editline library
by Red Hat Bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.
Summary: Review Request: libedit - The NetBSD Editline library
https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=181369
bugzilla(a)redhat.com changed:
What |Removed |Added
----------------------------------------------------------------------------
QAContact|fedora-extras- |fedora-package-
|list(a)redhat.com |review(a)redhat.com
michael(a)knox.net.nz changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|ASSIGNED |CLOSED
Resolution| |NEXTRELEASE
--
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug, or are watching the QA contact.
18 years, 1 month
[Bug 187964] Review Request: bsd-games - A collection of text-based games
by Red Hat Bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.
Summary: Review Request: bsd-games - A collection of text-based games
https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=187964
------- Additional Comments From wart(a)kobold.org 2006-04-29 18:00 EST -------
(In reply to comment #39)
> (In reply to comment #37)
> > (In reply to comment #36)
> Wouldn't it be easier to just write:
> %{_datadir}/bsd-games
Why yes, it would.
>
> In that case concider dropping these 3 lines from the spec?
Done.
> > > * Shouldn't the highscore files be marked %config(noreplace) ?
> >
> > I say no. If the high score file formats changes at any time then we want to
> > make sure that the old ones get removed. We could mark them as %config only,
> > but that seems pointless because the only reason to preserve the old scoreboard
> > files is if a migration tool is also provided to move it to the new format, and
> > I don't see that happening for any of these games.
> >
>
> Do you concider the changing of these files format likely? If you don't makr
> them %config(noreplace) the highscores will get reset on each package update, I
> don't think you / we want that.
I was under the mistaken impression that rpm would not touch files during an
upgrade that hadn't changed from one release to the next, but it seems that's
not the case for these scoreboard files.
I'll fix these three minor issues before building.
Thanks a bunch for the review. I know it was time consuming since this is like
40 packages all rolled into one. :)
--
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug, or are watching the QA contact.
18 years, 1 month