package-review April 2006

package-review@lists.fedoraproject.org

1 participants
906 discussions

Start a nNew thread

[Bug 187964] Review Request: bsd-games - A collection of text-based games
by Red Hat Bugzilla 28 Apr '06

28 Apr '06

1 0

[Bug 168719] Review Request: gdal
by Red Hat Bugzilla 28 Apr '06

28 Apr '06

Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: gdal https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=168719 ------- Additional Comments From rc040203(a)freenet.de 2006-04-28 10:31 EST ------- (In reply to comment #16) > Ping? I think, this PR has been lingering around long enough and should be closed to give others who might be more interested into this package that the OP an opportunity to take over. -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug, or are watching the QA contact.

1 0

[Bug 177106] Review Request: libgdgeda - graphical library for gEDA
by Red Hat Bugzilla 28 Apr '06

28 Apr '06

Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: libgdgeda - graphical library for gEDA https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=177106 ------- Additional Comments From j.w.r.degoede(a)hhs.nl 2006-04-28 10:26 EST ------- Cool, keep up the good work! -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug, or are watching the QA contact.

1 0

[Bug 177106] Review Request: libgdgeda - graphical library for gEDA
by Red Hat Bugzilla 28 Apr '06

28 Apr '06

Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: libgdgeda - graphical library for gEDA https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=177106 ------- Additional Comments From wk(a)ire.pw.edu.pl 2006-04-28 10:03 EST ------- Adding "-lgl " to GDGEDA_LIBS makes libgeda to require libgd.so.2. Now I am going to try a complete build without libgdgeda. -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug, or are watching the QA contact.

1 0

[Bug 187799] Review Request: perl-Cairo - Perl interface to the cairo library
by Red Hat Bugzilla 28 Apr '06

28 Apr '06

Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: perl-Cairo - Perl interface to the cairo library https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=187799 jpo(a)di.uminho.pt changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |CLOSED Resolution| |NEXTRELEASE ------- Additional Comments From jpo(a)di.uminho.pt 2006-04-28 09:35 EST ------- Thanks for the review. Imported and built for FC-5 and devel. Now I have to update perl-Gtk2 (FC-5 and devel). -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug, or are watching the QA contact.

1 0

[Bug 169345] Review Request: SEC - Simple Event Correlator
by Red Hat Bugzilla 28 Apr '06

28 Apr '06

Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: SEC - Simple Event Correlator https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=169345 ------- Additional Comments From Didier.Moens(a)dmbr.UGent.be 2006-04-28 08:56 EST ------- SRPM upgraded to upstream 2.3.3 ; fixed spec-file in accordance with comment #1. http://www.dmbr.ugent.be/~didier/sec/sec-2.3.3-1.src.rpm http://www.dmbr.ugent.be/~didier/sec/sec.spec TIA for reviewing ! -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug, or are watching the QA contact.

1 0

[Bug 175047] Review Request: NetworkManager-openvpn
by Red Hat Bugzilla 28 Apr '06

28 Apr '06

Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: NetworkManager-openvpn https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=175047 ------- Additional Comments From redhat-bugzilla(a)niemueller.de 2006-04-28 06:46 EST ------- I'm currently investigating some problems in the code, when that is done I will post a new version of the srpm. Expect this for next week. -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug, or are watching the QA contact.

1 0

[Bug 175047] Review Request: NetworkManager-openvpn
by Red Hat Bugzilla 28 Apr '06

28 Apr '06

Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: NetworkManager-openvpn https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=175047 ------- Additional Comments From david(a)readingroom.com 2006-04-28 06:01 EST ------- I'd like to see this in extras too. -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug, or are watching the QA contact.

1 0

[Bug 187964] Review Request: bsd-games - A collection of text-based games
by Red Hat Bugzilla 28 Apr '06

28 Apr '06

Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: bsd-games - A collection of text-based games https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=187964 ------- Additional Comments From j.w.r.degoede(a)hhs.nl 2006-04-28 04:34 EST ------- Looking good, almost there! MUST: ----- * rpmlint output is: E: bsd-games configure-without-libdir-spec E: bsd-games zero-length /var/games/robots_roll E: bsd-games non-standard-executable-perm /usr/bin/canfield 02755 E: bsd-games non-standard-gid /var/games/phantasia/characs gamephant E: bsd-games zero-length /var/games/phantasia/characs E: bsd-games non-standard-executable-perm /usr/bin/snake 02755 E: bsd-games non-standard-gid /var/games/phantasia gamephant E: bsd-games non-standard-dir-perm /var/games/phantasia 0775 E: bsd-games non-standard-gid /usr/bin/phantasia gamephant E: bsd-games setgid-binary /usr/bin/phantasia gamephant 02755 E: bsd-games non-standard-executable-perm /usr/bin/phantasia 02755 E: bsd-games non-standard-executable-perm /usr/bin/robots 02755 E: bsd-games non-standard-gid /var/games/hack gamehack E: bsd-games non-standard-dir-perm /var/games/hack 0775 E: bsd-games non-standard-gid /var/games/phantasia/motd gamephant E: bsd-games zero-length /var/games/phantasia/motd E: bsd-games non-standard-executable-perm /usr/bin/atc 02755 E: bsd-games zero-length /var/games/cfscores E: bsd-games zero-length /var/games/atc_score E: bsd-games non-standard-gid /var/games/hack/record gamehack E: bsd-games zero-length /var/games/hack/record E: bsd-games non-standard-executable-perm /usr/bin/battlestar 02755 E: bsd-games non-standard-gid /var/games/saillog gamesail E: bsd-games zero-length /var/games/saillog E: bsd-games non-standard-executable-perm /usr/bin/tetris-bsd 02755 E: bsd-games non-standard-gid /usr/bin/sail gamesail E: bsd-games setgid-binary /usr/bin/sail gamesail 02755 E: bsd-games non-standard-executable-perm /usr/bin/sail 02755 E: bsd-games zero-length /var/games/tetris-bsd.scores E: bsd-games non-standard-gid /var/games/phantasia/monsters gamephant E: bsd-games non-standard-executable-perm /usr/bin/cribbage 02755 E: bsd-games zero-length /var/games/criblog E: bsd-games non-standard-gid /var/games/phantasia/scoreboard gamephant E: bsd-games zero-length /var/games/phantasia/scoreboard E: bsd-games non-standard-gid /var/games/phantasia/mess gamephant E: bsd-games zero-length /var/games/phantasia/mess E: bsd-games non-standard-gid /var/games/hack/perm gamehack E: bsd-games zero-length /var/games/hack/perm E: bsd-games non-standard-gid /var/games/sail gamesail E: bsd-games non-standard-dir-perm /var/games/sail 0775 E: bsd-games zero-length /var/games/battlestar.log E: bsd-games non-standard-gid /var/games/phantasia/void gamephant E: bsd-games zero-length /var/games/phantasia/void E: bsd-games zero-length /var/games/snakerawscores E: bsd-games non-standard-gid /var/games/phantasia/lastdead gamephant E: bsd-games zero-length /var/games/phantasia/lastdead E: bsd-games non-standard-gid /var/games/phantasia/gold gamephant E: bsd-games zero-length /var/games/phantasia/gold E: bsd-games zero-length /var/games/snake.log E: bsd-games non-standard-gid /usr/bin/hack gamehack E: bsd-games setgid-binary /usr/bin/hack gamehack 02755 E: bsd-games non-standard-executable-perm /usr/bin/hack 02755 These are all not a problem, see discussion above. * Package and spec file named appropriately * Packaged according to packaging guidelines * License ok, license file included * spec file is legible and in Am. English. * Source matches upstream * Compiles and builds on devel-x86_64 * BR: ok (see below) * No locales * No shared libraries * Not relocatable * Package owns all dirs it installs, with one exception see below. * No duplicate files & Permissions ok * %clean & macro usage OK * Contains code and permissable content * %doc does not affect runtime, and isn't large enough to warrent a sub package * no -devel package needed, no libs / .la files. * no gui -> no .desktop file required MUST Fix: --------- * Add missing "Requires(Pre): /usr/sbin/groupadd" * Package must own /usr/share/bsd-games Should Fix: ----------- * "# It looks like textutils became coreutils at some point. I'm not sure # what is needed from it, so I'm commenting it out until I can find out. #Requires: textutils" * Maybe use "BSD" as license, as all games eem to be under one or the other variant of the BSD license? * Shouldn't the highscore files be marked %config(noreplace) ? * Suspicious compiler warnings: "canfield/cfscores/cfscores.c:130: warning: comparison of unsigned expression < 0 is always false" "hunt/hunt/playit.c:117: warning: comparison is always true due to limited range of data type" "hunt/hunt/playit.c:652: warning: comparison is always true due to limited range of data type "phantasia/setup.c:71: warning: 'path' may be used uninitialized in this function" " -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug, or are watching the QA contact.

1 0

[Bug 183439] Review Request: papyrus (Canvas drawing library based on cairo/cairomm)
by Red Hat Bugzilla 28 Apr '06

28 Apr '06

Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: papyrus (Canvas drawing library based on cairo/cairomm) https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=183439 bugzilla(a)redhat.com changed: What |Removed |Added ---------------------------------------------------------------------------- QAContact|fedora-extras- |fedora-package- |list(a)redhat.com |review(a)redhat.com ------- Additional Comments From mpeters(a)mac.com 2006-04-28 04:18 EST ------- Are you in need of a sponsor? I don't see the e-mail that opened this bug in the owners.list file. If you are in need of a sponsor, you should add bug #177841 the the Bug 183439 blocks field -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug, or are watching the QA contact.

1 0

← Newer
1
...
14
15
16
17
18
19
20
...
91
Older →

Jump to page:

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

2007

2006

package-review April 2006