package-review April 2006

package-review@lists.fedoraproject.org

1 participants
906 discussions

[Bug 187964] Review Request: bsd-games - A collection of text-based games
by Red Hat Bugzilla 28 Apr '06

28 Apr '06

Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: bsd-games - A collection of text-based games https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=187964 ------- Additional Comments From wart(a)kobold.org 2006-04-28 01:57 EST ------- I've addressed the issues from comment 30 and comment 31. The hack gid patch has a lot of changes to limit the setgid portions of code. Fortunately, phantasia was easier to deal with, and sail was already done upstream. dm has also been dropped. http://www.kobold.org/~wart/fedora/bsd-games-2.17-7.src.rpm http://www.kobold.org/~wart/fedora/bsd-games.spec -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug, or are watching the QA contact.

1 0

[Bug 188208] Review Request: wings - A polygon mesh modeler
by Red Hat Bugzilla 28 Apr '06

28 Apr '06

Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: wings - A polygon mesh modeler https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=188208 tibbs(a)math.uh.edu changed: What |Removed |Added ---------------------------------------------------------------------------- OtherBugsDependingO|163778 |163779 nThis| | ------- Additional Comments From tibbs(a)math.uh.edu 2006-04-28 01:46 EST ------- Everything looks good. APPROVED -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug, or are watching the QA contact.

1 0

[Bug 188168] Review Request: gauche - Scheme script interpreter with multibyte character handling
by Red Hat Bugzilla 28 Apr '06

28 Apr '06

1 0

[Bug 188168] Review Request: gauche - Scheme script interpreter with multibyte character handling
by Red Hat Bugzilla 28 Apr '06

28 Apr '06

Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: gauche - Scheme script interpreter with multibyte character handling https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=188168 ------- Additional Comments From tibbs(a)math.uh.edu 2006-04-28 01:29 EST ------- Something seems to have busted; now I can't build any of the packages you've submitted on the development branch. Things start to go off here: os_dep.c:20:30: error: linux/version.h: No such file or directory In file included from /usr/include/asm/signal.h:5, from os_dep.c:27: /usr/include/asm-x86_64/signal.h:6:27: error: linux/linkage.h: No such file or directory In file included from /usr/include/asm-x86_64/signal.h:7, from /usr/include/asm/signal.h:5, from os_dep.c:27: /usr/include/linux/time.h:9: error: redefinition of 'struct timespec' /usr/include/linux/time.h:15: error: redefinition of 'struct timeval' /usr/include/linux/time.h:42: error: redefinition of 'struct itimerspec' In file included from /usr/include/asm/signal.h:5, from os_dep.c:27: /usr/include/asm-x86_64/signal.h:15: error: conflicting types for 'sigset_t' /usr/include/signal.h:50: error: previous declaration of 'sigset_t' was here In file included from /usr/include/asm/signal.h:5, from os_dep.c:27: /usr/include/asm-x86_64/signal.h:102: error: redefinition of 'struct sigaction' /usr/include/asm-x86_64/signal.h:103: error: expected ':', ',', ';', '}' or '__attribute__' before '.' token /usr/include/asm-x86_64/signal.h:113: error: redefinition of 'struct sigaltstack' I'll attach a build log, but fortunately things still build on the FC5 release branch, and that's all that's required, so I'll proceed with the review on that basis. I think something must have busted since I last pulled from rawhide a couple of days ago. The first file it can't find, /usr/include/linux/version.h, is in FC5 part of glibc-kernheaders but it's not there in current rawhide. Issues: You should package the COPYING file as %doc. I'm inclined to ignore the remaining rpmlint complaint. In reality fixing gauche-config should be a simple matter of patching src/genconfig.in, but I have no way of knowing what that might break. And anyway, compilers tend to be something of a special case (c.f. gcc). There's a test suite that you don't call; I added %check cd src; LD_LIBRARY_PATH=$RPM_BUILD_ROOT%{_libdir} make test and it runs and, most importantly, passes. Review: * package meets naming and packaging guidelines. * specfile is properly named, is cleanly written and uses macros consistently. * license field matches the actual license. X license is open source-compatible and is included upstream but is not included in the package. * source files match upstream: 5c7cb6eba7455c9877aec884b0088a25 Gauche-0.8.7.tgz 5c7cb6eba7455c9877aec884b0088a25 Gauche-0.8.7.tgz-srpm * BuildRequires are proper. * package builds in mock (fc5, i386 and x86_64). O rpmlint is silent. * final provides and requires are sane. * shared libraries are present; ldconfig is called as necessary. * package is not relocatable. * owns the directories it creates. * doesn't own any directories it shouldn't. * no duplicates in %files. * file permissions are appropriate. * %clean is present. X %check is not present, but upstream includes one that can easily be run. * code, not content. * documentation is small, so no -docs subpackage is necessary. * %docs are not necessary for the proper functioning of the package. * headers present and in a -devel package. * no pkgconfig files. * no libtool .la droppings. * not a GUI app. -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug, or are watching the QA contact.

1 0

[Bug 174546] Review Request: trac
by Red Hat Bugzilla 28 Apr '06

28 Apr '06

Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: trac https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=174546 ------- Additional Comments From joshuadfranklin(a)yahoo.com 2006-04-27 23:34 EST ------- Well, the wiki may be the place to make this change, but its example currently has: sudo trac-admin /srv/trac/foobar initenv This will fail unless /srv/trac already exists, so it could be included in the rpm. Alternatively the wiki could be updated to do just sudo trac-admin /srv/trac initenv though first-time users might be confused that they are creating a trac environment actually named "trac". -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug, or are watching someone who is.

1 0

[Bug 181450] Review Request: clamav-exim - Clam AV support files for Exim
by Red Hat Bugzilla 27 Apr '06

27 Apr '06

Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: clamav-exim - Clam AV support files for Exim https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=181450 bugzilla(a)redhat.com changed: What |Removed |Added ---------------------------------------------------------------------------- QAContact|fedora-extras- |fedora-package- |list(a)redhat.com |review(a)redhat.com ------- Additional Comments From rpm(a)timj.co.uk 2006-04-27 18:44 EST ------- OK, I've looked into this. The /usr/share/clamav/clamd-wrapper script, provided by clamav-server, hardcodes "clamd.XXX" as the service name in several places. So either we stick with clamd.exim as the service name or have to file a bug with Enrico and get him to patch the main ClamAV package. I presume there was some reason why clamd.XXX was chosen. Also, this package should possibly be renamed clamav-server-exim. -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug, or are watching the QA contact.

1 0

[Bug 188542] Review Request: hylafax
by Red Hat Bugzilla 27 Apr '06

27 Apr '06

Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: hylafax https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=188542 ------- Additional Comments From faxguy(a)howardsilvan.com 2006-04-27 18:37 EST ------- Okay, I'm hoping this took care of the problem. Now please try: Spec URL: http://osdn.dl.sourceforge.net/sourceforge/hylafax/hylafax.spec SRPM URL: http://osdn.dl.sourceforge.net/sourceforge/hylafax/hylafax-4.3.0.1-1.src.rpm -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug, or are watching the QA contact.

1 0

[Bug 187964] Review Request: bsd-games - A collection of text-based games
by Red Hat Bugzilla 27 Apr '06

27 Apr '06

Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: bsd-games - A collection of text-based games https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=187964 ------- Additional Comments From j.w.r.degoede(a)hhs.nl 2006-04-27 18:10 EST ------- I'm all for dropping dm, its a strange beast, especially since there is no similar functionality for any of the other games we package. -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug, or are watching the QA contact.

1 0

[Bug 187625] Review Request: ices IceS is a source client for a streaming server
by Red Hat Bugzilla 27 Apr '06

27 Apr '06

Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: ices IceS is a source client for a streaming server https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=187625 ivazquez(a)ivazquez.net changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |CLOSED Resolution| |WONTFIX OtherBugsDependingO|163778 | nThis| | ------- Additional Comments From ivazquez(a)ivazquez.net 2006-04-27 17:09 EST ------- So it turns out that someone had already submitted ices for review. Silly me for not noticing. -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug, or are watching the QA contact.

1 0

[Bug 178904] Review Request: Monodevelop
by Red Hat Bugzilla 27 Apr '06

27 Apr '06

Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: Monodevelop https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=178904 ------- Additional Comments From paul(a)all-the-johnsons.co.uk 2006-04-27 17:07 EST ------- Spec Name or Url: http://www.smmp.salford.ac.uk/packages/monodevelop.spec SRPM Name or Url: http://www.smmp.salford.ac.uk/packages/monodevelop-0.10-8.src.rpm Boo and java support are now built as part of the package. As before, the x86_64 version has problems due to packaging, but the i386 version works fine on both x86_64 and i386 without a hitch. -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug, or are watching the QA contact.

1 0

← Newer
1
...
15
16
17
18
19
20
21
...
91
Older →

Jump to page:

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

2007

2006

package-review April 2006