[Bug 1759940] Review Request: htslib - C library for high-throughput sequencing data formats
https://bugzilla.redhat.com/show_bug.cgi?id=1759940
Jun Aruga <jaruga(a)redhat.com> changed:
What |Removed |Added
----------------------------------------------------------------------------
Flags| |needinfo?(John.W.Marshall@g
| |lasgow.ac.uk)
--- Comment #16 from Jun Aruga <jaruga(a)redhat.com> ---
2. In %files, I suggest using %{_libexecdir}/%{name}/hfile_*.so
rather than explicitly listing the three that currently exist.
According to following document, so files in %files should not be listed by
using a glob. The example 's pattern "libfoo.so*" is different from the
pattern
"hfile_*.so".
But I feel I need to be conscious for each so file.
So, I would prefer the explicitly listing way.
https://docs.fedoraproject.org/en-US/packaging-guidelines/#_listing_share...
Shared libraries installed directly into %{_libdir} SHOULD NOT be listed in the %files
section of the spec by using a glob in a way that conceals important parts of the file
name (e.g. libfoo.so*), since changes to the SONAME also result in a changed file name in
most cases.
Other parts you mentioned make sense for me. I updated it following your
suggestions.
I rebased the pull-request, including the man5 pages to the main package.
Could you review again?
https://src.fedoraproject.org/rpms/htslib/pull-request/1
Thanks for your review.
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component