https://bugzilla.redhat.com/show_bug.cgi?id=1759940 Jun Aruga <jaruga(a)redhat.com&gt; changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |zebob.m(a)gmail.com Link ID| |Red Hat Bugzilla 1326504 Blocks| |177841 (FE-NEEDSPONSOR), | |1131121, 1738176 Flags| |fedora-review? | |needinfo?(zebob.m(a)gmail.com | |) --- Comment #1 from Jun Aruga <jaruga(a)redhat.com&gt; --- This is an inheritance ticket from https://bugzilla.redhat.com/show_bug.cgi?id=1326504 . The ticket is created to request the Fedora dist-git repository by my account. The Spec URL and SRPM URL and the contents are same as the last ones of the ticket https://bugzilla.redhat.com/show_bug.cgi?id=1326504#c26 * Koji scratch build: ok https://koji.fedoraproject.org/koji/taskinfo?taskID=38010659 * Test to install RPMs: ok * rpmlint: ok Robert, can I ask you to change "fedora-review+" again like following comment? https://bugzilla.redhat.com/show_bug.cgi?id=1326504#c34 Referenced Bugs: https://bugzilla.redhat.com/show_bug.cgi?id=177841 [Bug 177841] Tracker: Review requests from new Fedora packagers who need a sponsor https://bugzilla.redhat.com/show_bug.cgi?id=1131121 [Bug 1131121] samtools-1.9 is available https://bugzilla.redhat.com/show_bug.cgi?id=1738176 [Bug 1738176] samtools depends on Python 2 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component

https://bugzilla.redhat.com/show_bug.cgi?id=1759940 Jun Aruga <jaruga(a)redhat.com&gt; changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks|177841 (FE-NEEDSPONSOR), | |201449 (FE-DEADREVIEW) | Referenced Bugs: https://bugzilla.redhat.com/show_bug.cgi?id=177841 [Bug 177841] Tracker: Review requests from new Fedora packagers who need a sponsor https://bugzilla.redhat.com/show_bug.cgi?id=201449 [Bug 201449] FE-DEADREVIEW -- Reviews stalled due to lack of submitter response should be blocking this bug. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component

https://bugzilla.redhat.com/show_bug.cgi?id=1759940 --- Comment #4 from Jun Aruga <jaruga(a)redhat.com&gt; --- Zbigniew, thanks for your review again! Now I am requesting the repository. ``` $ fedpkg request-repo htslib 1759940 https://pagure.io/releng/fedora-scm-requests/issue/18058 ``` -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component

https://bugzilla.redhat.com/show_bug.cgi?id=1759940 Robert-André Mauchin <zebob.m(a)gmail.com&gt; changed: What |Removed |Added ---------------------------------------------------------------------------- Flags| |fedora-review+ --- Comment #5 from Robert-André Mauchin <zebob.m(a)gmail.com&gt; --- Re-request now. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component

https://bugzilla.redhat.com/show_bug.cgi?id=1759940 --- Comment #7 from Gwyn Ciesla <gwync(a)protonmail.com&gt; --- (fedscm-admin): The Pagure repository was created at https://src.fedoraproject.org/rpms/htslib -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component

https://bugzilla.redhat.com/show_bug.cgi?id=1759940 Robert-André Mauchin <zebob.m(a)gmail.com&gt; changed: What |Removed |Added ---------------------------------------------------------------------------- Flags|needinfo?(zebob.m(a)gmail.com | |) | --- Comment #9 from Robert-André Mauchin <zebob.m(a)gmail.com&gt; --- (In reply to Jun Aruga from comment #8) Because the Assignee was me and the person who set the fedora-review+ flag was Zbigniew Jędrzejewski-Szmek: both need to be the same in order to fedpkg request-repo to work. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component

https://bugzilla.redhat.com/show_bug.cgi?id=1759940 --- Comment #11 from John Marshall <John.W.Marshall(a)glasgow.ac.uk&gt; --- HTSlib uses the usual configure/make/make install build system, and falls back to a basic configuration if you didn't run configure. So your spec file should use configure, via %configure as appropriate. In particular Fedora should provide a fully-featured HTSlib build by configuring with ./configure --enable-plugins --with-plugin-path='/usr/local/libexec/htslib:$(plugindir)' --enable-libcurl --enable-gcs --enable-s3 See HTSlib's INSTALL file for details. This will activate HTSlib's plugin mechanism so that the Fedora-supplied libhts.so will be able to use any other file access plugins that the user may have installed, and will make Fedora's libhts.so use libcurl (thus variously incurring dependencies on libcurl and libcurl-devel) to enable HTTPS and related file access methods. Your current build can do basic FTP and HTTP but not HTTPS, which means it is of rapidly decreasing usefulness. The file format man pages (sam.5 etc) are aimed at users of tools eg samtools, not only at developers using the API. So IMHO they would fit better in the htslib-tools subpackage alongside the other manual pages. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component

https://bugzilla.redhat.com/show_bug.cgi?id=1759940 --- Comment #13 from Jun Aruga <jaruga(a)redhat.com&gt; --- Robert-André and Zbigniew, Sure, thanks for your help, and also for your comment on devel@ mailing list about htslib. I am still reading it. It's useful for foolib packagers :) Review swap (htslib) https://lists.fedoraproject.org/archives/list/devel@lists.fedoraproject.o... -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component

https://bugzilla.redhat.com/show_bug.cgi?id=1759940 John Marshall <John.W.Marshall(a)glasgow.ac.uk&gt; changed: What |Removed |Added ---------------------------------------------------------------------------- Flags|needinfo?(John.W.Marshall@g | |lasgow.ac.uk) | --- Comment #15 from John Marshall <John.W.Marshall(a)glasgow.ac.uk&gt; --- 1. The plugins are loaded when libhts.so.2 is used. Hence they should be in the main package, not the -devel subpackage. 2. In %files, I suggest using %{_libexecdir}/%{name}/hfile_*.so rather than explicitly listing the three that currently exist. 3. You are building from an htslib release tarball, which already has configure built. So there is no need to run autoheader/autoconf or to build-require autoconf. They are for users, not just developers, so it is not appropriate to put them in the -devel package. If you don't want to put them in the -tools package, then put them in the main package -- in fact, that's probably an even better fit as some users will fool-hardily omit to install htslib-tools. That is incorrect -- libbind.spec puts the majority of its man pages in the main package. So your survey of other spec files reinforces putting htslib's *.5 in the main package. John -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component

https://bugzilla.redhat.com/show_bug.cgi?id=1759940 Jun Aruga <jaruga(a)redhat.com&gt; changed: What |Removed |Added ---------------------------------------------------------------------------- Fixed In Version| |htslib-1.9-2.fc32 Flags|needinfo?(John.W.Marshall@g | |lasgow.ac.uk) | --- Comment #17 from Jun Aruga <jaruga(a)redhat.com&gt; --- I merged and built it. https://koji.fedoraproject.org/koji/taskinfo?taskID=38532540 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component

https://bugzilla.redhat.com/show_bug.cgi?id=1759940 --- Comment #19 from Fedora Update System <updates(a)fedoraproject.org&gt; --- FEDORA-2019-21ca0b0c3c has been submitted as an update to Fedora 30. https://bodhi.fedoraproject.org/updates/FEDORA-2019-21ca0b0c3c -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component

https://bugzilla.redhat.com/show_bug.cgi?id=1759940 Fedora Update System <updates(a)fedoraproject.org&gt; changed: What |Removed |Added ---------------------------------------------------------------------------- Status|MODIFIED |ON_QA --- Comment #21 from Fedora Update System <updates(a)fedoraproject.org&gt; --- htslib-1.9-2.fc30 has been pushed to the Fedora 30 testing repository. If problems still persist, please make note of it in this bug report. See https://fedoraproject.org/wiki/QA:Updates_Testing for instructions on how to install test updates. You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2019-21ca0b0c3c -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component

https://bugzilla.redhat.com/show_bug.cgi?id=1759940 --- Comment #23 from Fedora Update System <updates(a)fedoraproject.org&gt; --- htslib-1.9-2.fc29 has been pushed to the Fedora 29 testing repository. If problems still persist, please make note of it in this bug report. See https://fedoraproject.org/wiki/QA:Updates_Testing for instructions on how to install test updates. You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2019-36fd2ef2e1 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component

https://bugzilla.redhat.com/show_bug.cgi?id=1759940 Jun Aruga <jaruga(a)redhat.com&gt; changed: What |Removed |Added ---------------------------------------------------------------------------- Fixed In Version|htslib-1.9-2.fc32 |htslib-1.9-3.fc32 --- Comment #25 from Jun Aruga <jaruga(a)redhat.com&gt; --- (In reply to John Marshall from comment #22) Sure, let me do without a glob for now. If it's hard to maintain it in the future, I like to use the glob for that. Thanks for checking! I fixed the issue on following pull-request now. https://src.fedoraproject.org/rpms/htslib/pull-request/2 I used %%dir for the directory. It looks safer as we can specify the files in the directory in %files. I will apply the new build htslib-1.9-3 to master and fNN branches one by one. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component

https://bugzilla.redhat.com/show_bug.cgi?id=1759940 --- Comment #27 from Fedora Update System <updates(a)fedoraproject.org&gt; --- FEDORA-2019-139769256b has been submitted as an update to Fedora 30. https://bodhi.fedoraproject.org/updates/FEDORA-2019-139769256b -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component

https://bugzilla.redhat.com/show_bug.cgi?id=1759940 Fedora Update System <updates(a)fedoraproject.org&gt; changed: What |Removed |Added ---------------------------------------------------------------------------- Status|MODIFIED |CLOSED Resolution|--- |ERRATA Last Closed| |2019-11-05 03:56:53 --- Comment #29 from Fedora Update System <updates(a)fedoraproject.org&gt; --- htslib-1.9-3.fc30 has been pushed to the Fedora 30 stable repository. If problems still persist, please make note of it in this bug report. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component

https://bugzilla.redhat.com/show_bug.cgi?id=1759940 --- Comment #31 from Fedora Update System <updates(a)fedoraproject.org&gt; --- htslib-1.9-3.fc29 has been pushed to the Fedora 29 stable repository. If problems still persist, please make note of it in this bug report. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component