[Bug 871604] Review Request: fedup - fedora upgrade tool
https://bugzilla.redhat.com/show_bug.cgi?id=871604
Kevin Fenzi <kevin(a)scrye.com> changed:
What |Removed |Added
----------------------------------------------------------------------------
Flags|fedora-review? |
Flags| |fedora-review+
--- Comment #2 from Kevin Fenzi <kevin(a)scrye.com> ---
OK - Package meets naming and packaging guidelines
OK - Spec file matches base package name.
OK - Spec has consistant macro usage.
OK - Meets Packaging Guidelines.
OK - License (GPLv2+)
OK - License field in spec matches
OK - License file included in package
OK - Spec in American English
OK - Spec is legible.
OK - Sources match upstream md5sum:
No checksum, but diff of checkout matches unpacked tar.xz
OK - BuildRequires correct
OK - Package has %defattr and permissions on files is good.
OK - Package has a correct %clean section.
OK - Package has correct buildroot
OK - Package is code or permissible content.
OK - Packages %doc files don't affect runtime.
OK - Package has rm -rf RPM_BUILD_ROOT at top of %install
OK - Package compiles and builds on at least one arch.
OK - Package has no duplicate files in %files.
OK - Package doesn't own any directories other packages own.
OK - Package owns all the directories it creates.
OK - Package obey's FHS standard (except for 2 exceptions)
See below - No rpmlint output.
OK - final provides and requires are sane.
SHOULD Items:
OK - Should build in mock.
OK - Should build on all supported archs
OK - Should have dist tag
OK - Should package latest version
OK - Should not use file requires outside of /etc, /bin, /sbin, /usr/bin, or
/usr/sbin
Issues:
1. Would be good to include commands needed to checkout source if there's
not a direct download link:
http://fedoraproject.org/wiki/Packaging:SourceURL#Using_Revision_Control
A direct Source0 link would be nice if possible.
2. rpmlint says:
fedup.noarch: W: summary-not-capitalized C the Fedora Upgrade tool
Change the 'to' to 'To' ?
fedup.noarch: W: no-manual-page-for-binary fedup-cli
man page would be nice, but of course not required.
fedup.src:44: W: macro-in-comment %files
fedup.src:45: W: macro-in-comment %{_bindir}
fedup.src:46: W: macro-in-comment %{_datadir}
fedup.src: W: invalid-url Source0: fedup-0.7.tar.xz
Remove % from those commented lines, or use %%
None of those are blockers. If you could address them before import that would
be great. Otherwise, this package is APPROVED.
--
You are receiving this mail because:
You are on the CC list for the bug.