[Bug 1374982] Review Request: python-robosignatory - A fedmsg consumer that automatically signs artifacts
https://bugzilla.redhat.com/show_bug.cgi?id=1374982
Peter Robinson <pbrobinson(a)gmail.com> changed:
What |Removed |Added
----------------------------------------------------------------------------
Flags| |fedora-review+
--- Comment #3 from Peter Robinson <pbrobinson(a)gmail.com> ---
Looks fine so APPROVED.
Only a couple of things to note:
* generally packages are named python2-XXX as opposed to python-
* no python3 package. Presumably due to lack of support in deps such as koji
(and also likely the reason for the python-XX above?
* man page or more detailed README would be nice but that's RFE ;-)
+ rpmlint output
pmlint -i download/python-robosignatory-0.0.2-1.fc26.src.rpm
1 packages and 0 specfiles checked; 0 errors, 0 warnings.
+ package name satisfies the packaging naming guidelines
+ specfile name matches the package base name
+ package should satisfy packaging guidelines
+ license meets guidelines and is acceptable to Fedora
+ license matches the actual package license
+ latest version packaged
+ %doc includes license file
+ spec file written in American English
+ spec file is legible
+ upstream sources match sources in the srpm
+ package successfully builds on at least one architecture
tested using koji scratch build
+ BuildRequires list all build dependencies
n/a %find_lang instead of %{_datadir}/locale/*
n/a binary RPM with shared library files must call ldconfig in %post and
%postun+ does not use Prefix: /usr
n/a package owns all directories it creates
n/a no duplicate files in %files
+ Package perserves timestamps on install
Permissions on files must be set properly
+ consistent use of macros
+ package must contain code or permissible content
n/a large documentation files should go in -doc subpackage
+ files marked %doc should not affect package runtime
n/a header files should be in -devel
n/a static libraries should be in -static
n/a packages containing pkgconfig (.pc) files need 'Requires: pkgconfig'
n/a libfoo.so must go in -devel
n/a devel must require the fully versioned base
+ packages should not contain libtool .la files
n/a packages containing GUI apps must include %{name}.desktop file
+ packages must not own files or directories owned by other packages
+ filenames must be valid UTF-8
Optional:
n/a if there is no license file, packager should query upstream to include it
n/a translations of description and summary for non-English languages, if
available
+ reviewer should build the package in mock/koji
n/a the package should build into binary RPMs on all supported architectures
n/a review should test the package functions as described
+ scriptlets should be sane
n/a non -devel packages should require fully versioned base
n/a pkgconfig files should go in -devel
+ shouldn't have file dependencies outside /etc /bin /sbin /usr/bin or
/usr/sbin
- Package should have man files
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component