[Bug 812674] Review Request: gnome-nettool - Graphical front-ends to various networking command-line tools
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=812674
--- Comment #6 from Kalev Lember <kalevlember(a)gmail.com> 2012-04-18 16:46:38 EDT
---
(In reply to comment #1)
I'll take this one.
Quick spec review:
1. %global is preferred over %define[1].
Fixed.
2. I've never seen desktop-file-validate put in %check. I think
that's usually
for "make test" type unit testing to kill builds that fail their tests even if
they build. I usually put it in %install.
There's a section in the packaging guidelines which explicitly says that it's
fine to place it in either %check or %install. In any case, we want the build
to fail if the validation fails, what's the whole point of using
desktop-file-validate.
"one MUST run /.../ desktop-file-validate (in %check or %install)"
http://fedoraproject.org/wiki/Packaging:Guidelines#desktop-file-install_u...
* Wed Apr 18 2012 Kalev Lember <kalevlember(a)gmail.com> - 3.2.0-2
- Use %%global instead of %%define (#812674)
Spec URL: http://kalev.fedorapeople.org/gnome-nettool.spec
SRPM URL: http://kalev.fedorapeople.org/gnome-nettool-3.2.0-2.fc17.src.rpm
Scratch build for rawhide with new gnome-doc-utils in buildroot:
http://koji.fedoraproject.org/koji/taskinfo?taskID=4003063
gnome-doc-utils update if you want to try and give karma:
https://admin.fedoraproject.org/updates/gnome-doc-utils-0.20.10-2.fc17
--
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.